diff mbox

[1/1] package/gcc: fix ARC failure to build in 2 phases.

Message ID 1435848294-5891-1-git-send-email-talz@ezchip.com
State Accepted
Headers show

Commit Message

tal zilcer July 2, 2015, 2:44 p.m. UTC 
From: Tal Zilcer <talz@ezchip.com>

When working with GCC initial at override source dir mode the
HOST_GCC_INITIAL_POST_PATCH_HOOKS is not called and compilation failes.
The solution is to use HOST_GCC_INITIAL_POST_RSYNC_HOOKS since this hook
is being called at override source dir mode.

Signed-off-by: Tal Zilcer <talz@ezchip.com>
---
 package/gcc/gcc-initial/gcc-initial.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Yann E. MORIN July 2, 2015, 9:02 p.m. UTC | #1 
Tal, All,

On 2015-07-02 17:44 +0300, Tal Zilcer spake thusly:
> From: Tal Zilcer <talz@ezchip.com>
> 
> When working with GCC initial at override source dir mode the
> HOST_GCC_INITIAL_POST_PATCH_HOOKS is not called and compilation failes.
> The solution is to use HOST_GCC_INITIAL_POST_RSYNC_HOOKS since this hook
> is being called at override source dir mode.
> 
> Signed-off-by: Tal Zilcer <talz@ezchip.com>

Based on the feedback from Alexey:
    http://lists.busybox.net/pipermail/buildroot/2015-July/131358.html

a post-rsync hook seems the most appropriate solution short- and
mid-term, so:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/gcc/gcc-initial/gcc-initial.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/gcc/gcc-initial/gcc-initial.mk b/package/gcc/gcc-initial/gcc-initial.mk
> index 0fa2353..6bb7997 100644
> --- a/package/gcc/gcc-initial/gcc-initial.mk
> +++ b/package/gcc/gcc-initial/gcc-initial.mk
> @@ -34,6 +34,7 @@ define HOST_GCC_INITIAL_DISABLE_LIBGMON
>  		$(@D)/libgcc/config.host
>  endef
>  HOST_GCC_INITIAL_POST_PATCH_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
> +HOST_GCC_INITIAL_POST_RSYNC_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
>  endif
>  
>  HOST_GCC_INITIAL_CONF_OPTS = \
> -- 
> 1.7.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni July 2, 2015, 9:45 p.m. UTC | #2 
Dear Tal Zilcer,

On Thu, 2 Jul 2015 17:44:54 +0300, Tal Zilcer wrote:
> From: Tal Zilcer <talz@ezchip.com>
> 
> When working with GCC initial at override source dir mode the
> HOST_GCC_INITIAL_POST_PATCH_HOOKS is not called and compilation failes.
> The solution is to use HOST_GCC_INITIAL_POST_RSYNC_HOOKS since this hook
> is being called at override source dir mode.
> 
> Signed-off-by: Tal Zilcer <talz@ezchip.com>
> ---
>  package/gcc/gcc-initial/gcc-initial.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/gcc/gcc-initial/gcc-initial.mk b/package/gcc/gcc-initial/gcc-initial.mk
index 0fa2353..6bb7997 100644
--- a/package/gcc/gcc-initial/gcc-initial.mk
+++ b/package/gcc/gcc-initial/gcc-initial.mk
@@ -34,6 +34,7 @@  define HOST_GCC_INITIAL_DISABLE_LIBGMON
 		$(@D)/libgcc/config.host
 endef
 HOST_GCC_INITIAL_POST_PATCH_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
+HOST_GCC_INITIAL_POST_RSYNC_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
 endif
 
 HOST_GCC_INITIAL_CONF_OPTS = \