diff mbox

[U-Boot,01/11] imx: mx6ul: Add i.MX6UL CPU type

Message ID 1435834988-13032-2-git-send-email-Peng.Fan@freescale.com
State Changes Requested
Delegated to: Stefano Babic
Headers show

Commit Message

Peng Fan July 2, 2015, 11:02 a.m. UTC 
Add MXC_CPU_MX6UL for i.MX6UL CPU type which is got at runtime.
The 0x64 is defined as i.MX6UL CPU type value in Reference mannual,
but the value has been occupied by i.MX6D as a dummy CPU type.
So we also change i.MX6D to value 0x67.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
Signed-off-by: Ye.Li <B37916@freescale.com>
---
 arch/arm/imx-common/cpu.c           | 2 ++
 arch/arm/include/asm/arch-imx/cpu.h | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Marek Vasut July 2, 2015, 6:27 p.m. UTC | #1 
On Thursday, July 02, 2015 at 01:02:58 PM, Peng Fan wrote:
> Add MXC_CPU_MX6UL for i.MX6UL CPU type which is got at runtime.
> The 0x64 is defined as i.MX6UL CPU type value in Reference mannual,

nit: manual, one N .

> but the value has been occupied by i.MX6D as a dummy CPU type.

Isn't the dummy ID for Solo ? ;-)

> So we also change i.MX6D to value 0x67.
> 
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Signed-off-by: Ye.Li <B37916@freescale.com>

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Peng Fan July 3, 2015, 1:17 a.m. UTC | #2 
Hi Marek,

On Thu, Jul 02, 2015 at 08:27:09PM +0200, Marek Vasut wrote:
>On Thursday, July 02, 2015 at 01:02:58 PM, Peng Fan wrote:
>> Add MXC_CPU_MX6UL for i.MX6UL CPU type which is got at runtime.
>> The 0x64 is defined as i.MX6UL CPU type value in Reference mannual,
>
>nit: manual, one N .
>
>> but the value has been occupied by i.MX6D as a dummy CPU type.
>
>Isn't the dummy ID for Solo ? ;-)

About the dummy Id, it does not matter what the value is. 
You can look into function get_cpu_rev for i.MX6.

>
>> So we also change i.MX6D to value 0x67.
>> 
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>> Signed-off-by: Ye.Li <B37916@freescale.com>
>
>Acked-by: Marek Vasut <marex@denx.de>
>
>Best regards,
>Marek Vasut

Regards,
Peng.
Marek Vasut July 3, 2015, 1:33 p.m. UTC | #3 
On Friday, July 03, 2015 at 03:17:28 AM, Peng Fan wrote:
> Hi Marek,

Hi!

> On Thu, Jul 02, 2015 at 08:27:09PM +0200, Marek Vasut wrote:
> >On Thursday, July 02, 2015 at 01:02:58 PM, Peng Fan wrote:
> >> Add MXC_CPU_MX6UL for i.MX6UL CPU type which is got at runtime.
> >> The 0x64 is defined as i.MX6UL CPU type value in Reference mannual,
> >
> >nit: manual, one N .
> >
> >> but the value has been occupied by i.MX6D as a dummy CPU type.
> >
> >Isn't the dummy ID for Solo ? ;-)
> 
> About the dummy Id, it does not matter what the value is.
> You can look into function get_cpu_rev for i.MX6.

Your patch description is incorrect nonetheless ;-)

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
index 096d22e..e27546c 100644
--- a/arch/arm/imx-common/cpu.c
+++ b/arch/arm/imx-common/cpu.c
@@ -138,6 +138,8 @@  const char *get_imx_type(u32 imxtype)
 		return "6SL";	/* Solo-Lite version of the mx6 */
 	case MXC_CPU_MX6SX:
 		return "6SX";   /* SoloX version of the mx6 */
+	case MXC_CPU_MX6UL:
+		return "6UL";   /* Ultra-Lite version of the mx6 */
 	case MXC_CPU_MX51:
 		return "51";
 	case MXC_CPU_MX53:
diff --git a/arch/arm/include/asm/arch-imx/cpu.h b/arch/arm/include/asm/arch-imx/cpu.h
index 99e0e32..c7f9fff 100644
--- a/arch/arm/include/asm/arch-imx/cpu.h
+++ b/arch/arm/include/asm/arch-imx/cpu.h
@@ -10,8 +10,9 @@ 
 #define MXC_CPU_MX6DL		0x61
 #define MXC_CPU_MX6SX		0x62
 #define MXC_CPU_MX6Q		0x63
-#define MXC_CPU_MX6D		0x64
+#define MXC_CPU_MX6UL		0x64
 #define MXC_CPU_MX6SOLO		0x65 /* dummy ID */
+#define MXC_CPU_MX6D		0x67
 #define MXC_CPU_MX6DP		0x68
 #define MXC_CPU_MX6QP		0x69