diff mbox

[U-Boot,3/5] sf: sf_dataflash: Remove CONFIG_SPI_DATAFLASH_WRITE_VERIFY option

Message ID 1435828372-8573-3-git-send-email-haikun.wang@freescale.com
State Superseded
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Haikun.Wang@freescale.com July 2, 2015, 9:12 a.m. UTC 
Signed-off-by: Haikun Wang <haikun.wang@freescale.com>
---
 drivers/mtd/spi/sf_dataflash.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Simon Glass July 6, 2015, 5:33 p.m. UTC | #1 
Hi,

On 2 July 2015 at 03:12, Haikun Wang <haikun.wang@freescale.com> wrote:
> Signed-off-by: Haikun Wang <haikun.wang@freescale.com>

Missing commit message. Doesn't this mean it will always do the verify?

> ---
>  drivers/mtd/spi/sf_dataflash.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c
> index 8f91527..6bf628b 100644
> --- a/drivers/mtd/spi/sf_dataflash.c
> +++ b/drivers/mtd/spi/sf_dataflash.c
> @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
>                         goto release_bus;
>                 }
>
> -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY
>                 /* (3) Compare to Buffer1 */
>                 addr = pageaddr << dataflash->page_offset;
>                 command[0] = OP_COMPARE_BUF1;
> @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
>                         status = 0;
>                 }
>
> -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */
>                 remaining = remaining - writelen;
>                 pageaddr++;
>                 to = 0;
> --
> 2.1.0.27.g96db324
>

Regards,
Simon
Haikun.Wang@freescale.com July 7, 2015, 2:49 a.m. UTC | #2 
On 7/7/2015 1:33 AM, Simon Glass wrote:
> Hi,
>
> On 2 July 2015 at 03:12, Haikun Wang <haikun.wang@freescale.com> wrote:
>> Signed-off-by: Haikun Wang <haikun.wang@freescale.com>
>
> Missing commit message. Doesn't this mean it will always do the verify?
OK, I will add the commit message.
It will always do the verify.
>
>> ---
>>   drivers/mtd/spi/sf_dataflash.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c
>> index 8f91527..6bf628b 100644
>> --- a/drivers/mtd/spi/sf_dataflash.c
>> +++ b/drivers/mtd/spi/sf_dataflash.c
>> @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
>>                          goto release_bus;
>>                  }
>>
>> -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY
>>                  /* (3) Compare to Buffer1 */
>>                  addr = pageaddr << dataflash->page_offset;
>>                  command[0] = OP_COMPARE_BUF1;
>> @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
>>                          status = 0;
>>                  }
>>
>> -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */
>>                  remaining = remaining - writelen;
>>                  pageaddr++;
>>                  to = 0;
>> --
>> 2.1.0.27.g96db324
>>
>
> Regards,
> Simon
>
Haikun.Wang@freescale.com July 20, 2015, 5:57 a.m. UTC | #3 
On 7/7/2015 1:33 AM, Simon Glass wrote:
> Hi,
>
> On 2 July 2015 at 03:12, Haikun Wang <haikun.wang@freescale.com> wrote:
>> Signed-off-by: Haikun Wang <haikun.wang@freescale.com>
>
> Missing commit message. Doesn't this mean it will always do the verify?
>
>> ---
>>   drivers/mtd/spi/sf_dataflash.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c
>> index 8f91527..6bf628b 100644
>> --- a/drivers/mtd/spi/sf_dataflash.c
>> +++ b/drivers/mtd/spi/sf_dataflash.c
>> @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
>>                          goto release_bus;
>>                  }
>>
>> -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY
>>                  /* (3) Compare to Buffer1 */
>>                  addr = pageaddr << dataflash->page_offset;
>>                  command[0] = OP_COMPARE_BUF1;
>> @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
>>                          status = 0;
>>                  }
>>
>> -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */
>>                  remaining = remaining - writelen;
>>                  pageaddr++;
>>                  to = 0;
>> --
>> 2.1.0.27.g96db324
>>
>
> Regards,
> Simon
>
Update my email address.
diff mbox

Patch

diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c
index 8f91527..6bf628b 100644
--- a/drivers/mtd/spi/sf_dataflash.c
+++ b/drivers/mtd/spi/sf_dataflash.c
@@ -371,7 +371,6 @@  int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
 			goto release_bus;
 		}
 
-#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY
 		/* (3) Compare to Buffer1 */
 		addr = pageaddr << dataflash->page_offset;
 		command[0] = OP_COMPARE_BUF1;
@@ -404,7 +403,6 @@  int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len,
 			status = 0;
 		}
 
-#endif	/* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */
 		remaining = remaining - writelen;
 		pageaddr++;
 		to = 0;