diff mbox

ipv6: Make MLD packets to only be processed locally.

Message ID 5594C731.8000706@alliedtelesis.co.nz
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Angga July 2, 2015, 5:08 a.m. UTC 
Before commit daad151263cf334 ("ipv6: Make ipv6_is_mld() inline and use it
from ip6_mc_input()." MLD packets were only processed locally. After the
change, a copy of MLD packet goes through ip6_mr_input, causing
MRT6MSG_NOCACHE message to be generated to user space.

Make MLD packet only processed locally.

Fixes: daad151263cf334 ("ipv6: Make ipv6_is_mld() inline and use it from 
ip6_mc_input().")

Signed-off-by: Hermin Anggawijaya <hermin.anggawijaya@alliedtelesis.co.nz>

---

Comments

David Miller July 2, 2015, 7:05 a.m. UTC | #1 
Your patch is severely corrupted by your email client, for example
TAB characters have been transformed into sequences of SPACE
characters.

Please read Documentation/email-clients.txt, fix your setup, and
then send a test patch to yourself and only when you can successfully
apply that patch you receive should you try resubmitting it again
here.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/linux/net/ipv6/ip6_input.c.orig b/linux/net/ipv6/ip6_input.c
index f2e464e..57990c9 100644
--- a/linux/net/ipv6/ip6_input.c.orig
+++ b/linux/net/ipv6/ip6_input.c
@@ -331,10 +331,10 @@  int ip6_mc_input(struct sk_buff *skb)
                                 if (offset < 0)
                                         goto out;

-                               if (!ipv6_is_mld(skb, nexthdr, offset))
-                                       goto out;
+                               if (ipv6_is_mld(skb, nexthdr, offset))
+                                       deliver = true;

-                               deliver = true;
+                               goto out;
                         }
                         /* unknown RA - process it normally */
                 }