Patchwork [1/1] UBUNTU: (pre-stable): input: ALPS - Add signature for HP Pavilion dm3 laptops

login
register
mail settings
Submitter Chase Douglas
Date March 30, 2010, 7:49 p.m.
Message ID <1269978570-22963-2-git-send-email-chase.douglas@canonical.com>
Download mbox | patch
Permalink /patch/49035/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Chase Douglas - March 30, 2010, 7:49 p.m.
Tested by a user running Ubuntu 9.10 in the following bug report.

BugLink: http://bugs.launchpad.net/bugs/545307

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/input/mouse/alps.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Andy Whitcroft - March 30, 2010, 8:07 p.m.
On Tue, Mar 30, 2010 at 03:49:30PM -0400, Chase Douglas wrote:
> Tested by a user running Ubuntu 9.10 in the following bug report.
> 
> BugLink: http://bugs.launchpad.net/bugs/545307
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
>  drivers/input/mouse/alps.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 2803853..21550ee 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -62,6 +62,7 @@ static const struct alps_model_info alps_model_data[] = {
>  	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },		  /* Dell Vostro 1400 */
> +	{ { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },			  /* HP Pavilion dm3 */
>  };

Seems reasonable.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Stefan Bader - March 31, 2010, 9:41 a.m.
Patch looks acceptable. Main issue would be to have had it put into the stable
class by CCing them. Has that been done?

Chase Douglas wrote:
> Tested by a user running Ubuntu 9.10 in the following bug report.
> 
> BugLink: http://bugs.launchpad.net/bugs/545307
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  drivers/input/mouse/alps.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 2803853..21550ee 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -62,6 +62,7 @@ static const struct alps_model_info alps_model_data[] = {
>  	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },		  /* Dell Vostro 1400 */
> +	{ { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },			  /* HP Pavilion dm3 */
>  };
>  
>  /*
Chase Douglas - March 31, 2010, 12:11 p.m.
On Wed, Mar 31, 2010 at 5:41 AM, Stefan Bader
<stefan.bader@canonical.com> wrote:
> Patch looks acceptable. Main issue would be to have had it put into the stable
> class by CCing them. Has that been done?
>

The commit I sent to linux-input has the "Cc: stable@kernel.org" line,
so when it gets applied to linux-2.6 it'll get sent there
automatically.

> Chase Douglas wrote:
>> Tested by a user running Ubuntu 9.10 in the following bug report.
>>
>> BugLink: http://bugs.launchpad.net/bugs/545307
>>
>> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
>> ---
>>  drivers/input/mouse/alps.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
>> index 2803853..21550ee 100644
>> --- a/drivers/input/mouse/alps.c
>> +++ b/drivers/input/mouse/alps.c
>> @@ -62,6 +62,7 @@ static const struct alps_model_info alps_model_data[] = {
>>       { { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
>>               ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
>>       { { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },               /* Dell Vostro 1400 */
>> +     { { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },                          /* HP Pavilion dm3 */
>>  };
>>
>>  /*
>
>

Patch

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 2803853..21550ee 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -62,6 +62,7 @@  static const struct alps_model_info alps_model_data[] = {
 	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },		  /* Dell Vostro 1400 */
+	{ { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },			  /* HP Pavilion dm3 */
 };
 
 /*