gpio: msm: Remove empty msm_gpio_{request,free}()
diff mbox

Message ID 1435753639-13627-1-git-send-email-geert+renesas@glider.be
State New
Headers show

Commit Message

Geert Uytterhoeven July 1, 2015, 12:27 p.m. UTC
gpio_chip.request() and gpio_chip.free() are optional, and can just be
left unimplemented.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
---
 drivers/gpio/gpio-msm-v2.c | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Stephen Boyd July 1, 2015, 5:40 p.m. UTC | #1
On 07/01/2015 05:27 AM, Geert Uytterhoeven wrote:
> gpio_chip.request() and gpio_chip.free() are optional, and can just be
> left unimplemented.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Untested due to lack of hardware.

Actually we should just delete this driver now that we have an msm8660
pinctrl implementation.

Patch
diff mbox

diff --git a/drivers/gpio/gpio-msm-v2.c b/drivers/gpio/gpio-msm-v2.c
index 52ff18229fdc874a..d9ea0c8e5f0aa82d 100644
--- a/drivers/gpio/gpio-msm-v2.c
+++ b/drivers/gpio/gpio-msm-v2.c
@@ -169,16 +169,6 @@  static int msm_gpio_direction_output(struct gpio_chip *chip,
 	return 0;
 }
 
-static int msm_gpio_request(struct gpio_chip *chip, unsigned offset)
-{
-	return 0;
-}
-
-static void msm_gpio_free(struct gpio_chip *chip, unsigned offset)
-{
-	return;
-}
-
 static int msm_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
 {
 	struct msm_gpio_dev *g_dev = to_msm_gpio_dev(chip);
@@ -404,8 +394,6 @@  static int msm_gpio_probe(struct platform_device *pdev)
 	msm_gpio.gpio_chip.get = msm_gpio_get;
 	msm_gpio.gpio_chip.set = msm_gpio_set;
 	msm_gpio.gpio_chip.to_irq = msm_gpio_to_irq;
-	msm_gpio.gpio_chip.request = msm_gpio_request;
-	msm_gpio.gpio_chip.free = msm_gpio_free;
 
 	ret = gpiochip_add(&msm_gpio.gpio_chip);
 	if (ret < 0) {