Patchwork Bug in boot code memcmp with zero length

login
register
mail settings
Submitter Mike Ditto
Date Oct. 17, 2008, 7:27 p.m.
Message ID <48F8E737.9090904@consentry.com>
Download mbox | patch
Permalink /patch/4901/
State Accepted
Headers show

Comments

Mike Ditto - Oct. 17, 2008, 7:27 p.m.
I noticed, when trying to use, e.g.,
node = find_node_by_prop_value(prev, "booleanprop", "", 0))
to search for all nodes with a certain boolean property, that memcmp()
returns garbage when comparing zero bytes.  It should return zero.

Patch

Index: arch/powerpc/boot/string.S
===================================================================
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 string.S
--- arch/powerpc/boot/string.S	11 Oct 2008 02:51:35 -0000	1.1.1.1
+++ arch/powerpc/boot/string.S	17 Oct 2008 19:11:18 -0000
@@ -235,7 +235,7 @@ 
 	.globl	memcmp
 memcmp:
 	cmpwi	0,r5,0
-	blelr
+	ble	2f
 	mtctr	r5
 	addi	r6,r3,-1
 	addi	r4,r4,-1
@@ -243,6 +243,8 @@ 
 	lbzu	r0,1(r4)
 	subf.	r3,r0,r3
 	bdnzt	2,1b
+	blr
+2:	li	r3,0
 	blr