| Message ID | 5593CFE4.10100@foss.arm.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Jul 1, 2015 at 12:32 PM, Matthew Wahab <matthew.wahab@foss.arm.com> wrote: > Hello, > > Tests I recently added for the code generated by the ARM backend for the > __sync > builtins had > > - 'do-require-effective-target', instead of the directive > 'dg-require-effective-target' and > - 'stlex' instead of 'strex' in the expected output for > armv8-sync-op-acquire.c > > This meant the tests ran on targets that did not support them and reported a > failure for correct code. This patch fixes both mistakes. > > Tested arm-none-linux-gnueabihf with check-gcc. > > Ok for trunk? > Matthew OK - I must be going blind. Ramana > > gcc/testsuite > 2015-07-01 Matthew Wahab <matthew.wahab@arm.com> > > * gcc.target/arm/armv8-sync-comp-swap.c: Replace > 'do-require-effective-target' with 'dg-require-effective-target'. > * gcc.target/arm/armv8-sync-op-full.c: Likewise. > * gcc.target/arm/armv8-sync-op-release.c: Likewise. > * gcc.target/arm/armv8-sync-op-acquire.c: Likewise. Also, replace > 'stlex' with 'strex' as the expected output.
diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c b/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c index f96c81a..0e95986 100644 --- a/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c +++ b/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { do-require-effective-target arm_arch_v8a_ok } */ +/* { dg-require-effective-target arm_arch_v8a_ok } */ /* { dg-options "-O2" } */ /* { dg-add-options arm_arch_v8a } */ diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c b/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c index 8d6659b..c448599 100644 --- a/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c +++ b/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c @@ -1,10 +1,10 @@ /* { dg-do compile } */ -/* { do-require-effective-target arm_arch_v8a_ok } */ +/* { dg-require-effective-target arm_arch_v8a_ok } */ /* { dg-options "-O2" } */ /* { dg-add-options arm_arch_v8a } */ #include "../aarch64/sync-op-acquire.x" /* { dg-final { scan-assembler-times "ldrex" 1 } } */ -/* { dg-final { scan-assembler-times "stlex" 1 } } */ +/* { dg-final { scan-assembler-times "strex" 1 } } */ /* { dg-final { scan-assembler-times "dmb" 1 } } */ diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c b/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c index a5ad3bd..cce9e00 100644 --- a/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c +++ b/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { do-require-effective-target arm_arch_v8a_ok } */ +/* { dg-require-effective-target arm_arch_v8a_ok } */ /* { dg-options "-O2" } */ /* { dg-add-options arm_arch_v8a } */ diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c b/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c index 0d3be7b..502a266 100644 --- a/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c +++ b/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { do-require-effective-target arm_arch_v8a_ok } */ +/* { dg-require-effective-target arm_arch_v8a_ok } */ /* { dg-options "-O2" } */ /* { dg-add-options arm_arch_v8a } */
Hello, Tests I recently added for the code generated by the ARM backend for the __sync builtins had - 'do-require-effective-target', instead of the directive 'dg-require-effective-target' and - 'stlex' instead of 'strex' in the expected output for armv8-sync-op-acquire.c This meant the tests ran on targets that did not support them and reported a failure for correct code. This patch fixes both mistakes. Tested arm-none-linux-gnueabihf with check-gcc. Ok for trunk? Matthew gcc/testsuite 2015-07-01 Matthew Wahab <matthew.wahab@arm.com> * gcc.target/arm/armv8-sync-comp-swap.c: Replace 'do-require-effective-target' with 'dg-require-effective-target'. * gcc.target/arm/armv8-sync-op-full.c: Likewise. * gcc.target/arm/armv8-sync-op-release.c: Likewise. * gcc.target/arm/armv8-sync-op-acquire.c: Likewise. Also, replace 'stlex' with 'strex' as the expected output.