Patchwork [2/3] squashfs: gather everything block device specific into block.c

login
register
mail settings
Submitter Ferenc Wagner
Date March 30, 2010, 4:50 p.m.
Message ID <8739zhu52t.fsf@tac.ki.iif.hu>
Download mbox | patch
Permalink /patch/48993/
State New
Headers show

Comments

Ferenc Wagner - March 30, 2010, 4:50 p.m.
---
I lost this free somehow.  Does squashfs_put_super() need protection
from multiple invocation?  If not, this kfree could be removed from
there, and the condition from both places.

 fs/squashfs/backend.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Patch

diff --git a/fs/squashfs/backend.c b/fs/squashfs/backend.c
index a6136ca..0ae37ab 100644
--- a/fs/squashfs/backend.c
+++ b/fs/squashfs/backend.c
@@ -24,6 +24,10 @@  int squashfs_find_backend(struct file_system_type *fs_type, int flags,
 
 void squashfs_kill_super(struct super_block *sb)
 {
+	if (sb->s_fs_info) {
+		kfree(sb->s_fs_info);
+		sb->s_fs_info = NULL;
+	}
 #ifdef CONFIG_BLOCK
 	if (sb->s_bdev) {
 		kill_block_super(sb);