diff mbox

[v1,02/10] i2c: core: Have clients point to their firmware nodes

Message ID 1435676108-20590-3-git-send-email-tomeu.vizoso@collabora.com
State Awaiting Upstream
Headers show

Commit Message

Tomeu Vizoso June 30, 2015, 2:55 p.m. UTC
This is needed by platform-independent code that needs to do something
with devices based on the data provided by the firmware.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---

 drivers/i2c/i2c-core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Wolfram Sang July 31, 2015, 10:36 a.m. UTC | #1
On Tue, Jun 30, 2015 at 04:55:00PM +0200, Tomeu Vizoso wrote:
> This is needed by platform-independent code that needs to do something
> with devices based on the data provided by the firmware.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Dunno the status of this series, but the i2c change is trivial enough.
So in case, the rest is accepted:

Acked-by: Wolfram Sang <wsa@the-dreams.de>
Tomeu Vizoso Aug. 6, 2015, 2:17 p.m. UTC | #2
On 31 July 2015 at 12:36, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Tue, Jun 30, 2015 at 04:55:00PM +0200, Tomeu Vizoso wrote:
>> This is needed by platform-independent code that needs to do something
>> with devices based on the data provided by the firmware.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>
> Dunno the status of this series, but the i2c change is trivial enough.
> So in case, the rest is accepted:
>
> Acked-by: Wolfram Sang <wsa@the-dreams.de>

Currently my series is moving away from fwnode because the current
approach is very much dependent on the firmware, but I think this fix
is worth in its own because someone else will find this problem sooner
or later.

Regards,

Tomeu
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang Aug. 6, 2015, 9:06 p.m. UTC | #3
On Thu, Aug 06, 2015 at 04:17:28PM +0200, Tomeu Vizoso wrote:
> On 31 July 2015 at 12:36, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Tue, Jun 30, 2015 at 04:55:00PM +0200, Tomeu Vizoso wrote:
> >> This is needed by platform-independent code that needs to do something
> >> with devices based on the data provided by the firmware.
> >>
> >> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> >
> > Dunno the status of this series, but the i2c change is trivial enough.
> > So in case, the rest is accepted:
> >
> > Acked-by: Wolfram Sang <wsa@the-dreams.de>
> 
> Currently my series is moving away from fwnode because the current
> approach is very much dependent on the firmware, but I think this fix
> is worth in its own because someone else will find this problem sooner
> or later.

If you think it is a bugfix, then please resend this individually. If
not, we will just wait until someone needs it.
diff mbox

Patch

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 069a41f..707850a 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1295,6 +1295,7 @@  static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
 	}
 
 	info.of_node = of_node_get(node);
+	info.fwnode = info.of_node ? &info.of_node->fwnode : NULL;
 	info.archdata = &dev_ad;
 
 	if (of_get_property(node, "wakeup-source", NULL))