| Message ID | 1435654329-19960-2-git-send-email-stephen.finucane@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Jun 30, 2015 at 09:51:59AM +0100, Stephen Finucane wrote: > The 'patchwork: Explicitly load states fixtures' change introduced > explicit state loading into many of the tests, but missed one. > Correct this oversight. > > Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> This patch adds unrelated white space changes, which is usually frowned upon. That goes towards the right direction though and make the test suite pass again so: Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> > --- > patchwork/tests/test_xmlrpc.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/patchwork/tests/test_xmlrpc.py b/patchwork/tests/test_xmlrpc.py > index 2b459b2..b7c629e 100644 > --- a/patchwork/tests/test_xmlrpc.py > +++ b/patchwork/tests/test_xmlrpc.py > @@ -28,13 +28,14 @@ from patchwork.tests.utils import defaults > @unittest.skipUnless(settings.ENABLE_XMLRPC, > "requires xmlrpc interface (use the ENABLE_XMLRPC setting)") > class XMLRPCTest(LiveServerTestCase): > + fixtures = ['default_states'] > > def setUp(self): > settings.STATIC_URL = '/' > - self.url = (self.live_server_url + > + self.url = (self.live_server_url + > reverse('patchwork.views.xmlrpc.xmlrpc')) > self.rpc = xmlrpclib.Server(self.url) > - > + > def testGetRedirect(self): > response = self.client.get(self.url) > self.assertRedirects(response, > -- > 2.0.0 > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
diff --git a/patchwork/tests/test_xmlrpc.py b/patchwork/tests/test_xmlrpc.py index 2b459b2..b7c629e 100644 --- a/patchwork/tests/test_xmlrpc.py +++ b/patchwork/tests/test_xmlrpc.py @@ -28,13 +28,14 @@ from patchwork.tests.utils import defaults @unittest.skipUnless(settings.ENABLE_XMLRPC, "requires xmlrpc interface (use the ENABLE_XMLRPC setting)") class XMLRPCTest(LiveServerTestCase): + fixtures = ['default_states'] def setUp(self): settings.STATIC_URL = '/' - self.url = (self.live_server_url + + self.url = (self.live_server_url + reverse('patchwork.views.xmlrpc.xmlrpc')) self.rpc = xmlrpclib.Server(self.url) - + def testGetRedirect(self): response = self.client.get(self.url) self.assertRedirects(response,
The 'patchwork: Explicitly load states fixtures' change introduced explicit state loading into many of the tests, but missed one. Correct this oversight. Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> --- patchwork/tests/test_xmlrpc.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)