Patchwork [2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

login
register
mail settings
Submitter Anton Vorontsov
Date Oct. 17, 2008, 6:57 p.m.
Message ID <20081017185709.GB30008@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/4895/
State Accepted
Delegated to: Kumar Gala
Headers show

Comments

Anton Vorontsov - Oct. 17, 2008, 6:57 p.m.
MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
provide soft power-off function, but also exports two GPIOs (wired to
the LEDs and also available from the external headers).

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 arch/powerpc/boot/dts/mpc8315erdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8349emitx.dts |    8 ++++++++
 arch/powerpc/boot/dts/mpc8377_rdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8378_rdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8379_rdb.dts  |    8 ++++++++
 5 files changed, 40 insertions(+), 0 deletions(-)
Kumar Gala - Oct. 21, 2008, 4:39 a.m.
On Oct 17, 2008, at 1:57 PM, Anton Vorontsov wrote:

> MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> provide soft power-off function, but also exports two GPIOs (wired to
> the LEDs and also available from the external headers).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8315erdb.dts  |    8 ++++++++
> arch/powerpc/boot/dts/mpc8349emitx.dts |    8 ++++++++
> arch/powerpc/boot/dts/mpc8377_rdb.dts  |    8 ++++++++
> arch/powerpc/boot/dts/mpc8378_rdb.dts  |    8 ++++++++
> arch/powerpc/boot/dts/mpc8379_rdb.dts  |    8 ++++++++
> 5 files changed, 40 insertions(+), 0 deletions(-)

applied

- k
Timur Tabi - Dec. 3, 2008, 11:10 p.m.
On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> provide soft power-off function, but also exports two GPIOs (wired to
> the LEDs and also available from the external headers).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Kumar, I think you merged this patch incorrectly ...

> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> index 7fc5414..4bdbaf4 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> @@ -91,6 +91,14 @@
>                                interrupts = <18 0x8>;
>                                interrupt-parent = <&ipic>;
>                        };
> +
> +                       mcu_pio: mcu@a {
> +                               #gpio-cells = <2>;
> +                               compatible = "fsl,mc9s08qg8-mpc8349emitx",
> +                                            "fsl,mcu-mpc8349emitx";
> +                               reg = <0x0a>;
> +                               gpio-controller;
> +                       };

This node is supposed to go under the I2C node, but you put it under
the DMA node.
Anton Vorontsov - Dec. 3, 2008, 11:44 p.m.
On Wed, Dec 03, 2008 at 05:10:30PM -0600, Timur Tabi wrote:
> On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> > provide soft power-off function, but also exports two GPIOs (wired to
> > the LEDs and also available from the external headers).
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> Kumar, I think you merged this patch incorrectly ...
[...]
> This node is supposed to go under the I2C node, but you put it under
> the DMA node.

I've noticed this on the other 'stg pull', when it told me that the
patch isn't empty (stg patch becomes empty if merged).

This should be fixed already:

http://ozlabs.org/pipermail/linuxppc-dev/2008-November/065666.html

Anyway, thanks for heads up!

Patch

diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/boot/dts/mpc8315erdb.dts
index 7449e54..6b85067 100644
--- a/arch/powerpc/boot/dts/mpc8315erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
@@ -121,6 +121,14 @@ 
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8315erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		spi@7000 {
diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 7fc5414..4bdbaf4 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -91,6 +91,14 @@ 
 				interrupts = <18 0x8>;
 				interrupt-parent = <&ipic>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8349emitx",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		spi@7000 {
diff --git a/arch/powerpc/boot/dts/mpc8377_rdb.dts b/arch/powerpc/boot/dts/mpc8377_rdb.dts
index 53191ba..435ef3d 100644
--- a/arch/powerpc/boot/dts/mpc8377_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc8377_rdb.dts
@@ -121,6 +121,14 @@ 
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8377erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
diff --git a/arch/powerpc/boot/dts/mpc8378_rdb.dts b/arch/powerpc/boot/dts/mpc8378_rdb.dts
index 4a09153..b11e68f 100644
--- a/arch/powerpc/boot/dts/mpc8378_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc8378_rdb.dts
@@ -121,6 +121,14 @@ 
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8378erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
diff --git a/arch/powerpc/boot/dts/mpc8379_rdb.dts b/arch/powerpc/boot/dts/mpc8379_rdb.dts
index bbd884a..337af6e 100644
--- a/arch/powerpc/boot/dts/mpc8379_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc8379_rdb.dts
@@ -121,6 +121,14 @@ 
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8379erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {