Patchwork [1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

login
register
mail settings
Submitter Anton Vorontsov
Date Oct. 17, 2008, 6:56 p.m.
Message ID <20081017185659.GA30008@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/4894/
State Accepted, archived
Commit 672e806ee103c1709bcdcafabe65ba9c8ab5a63d
Delegated to: Kumar Gala
Headers show

Comments

Anton Vorontsov - Oct. 17, 2008, 6:56 p.m.
The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt signal
is connected to the IPIC's EXT2 interrupt line, the line is shared with
Vitesse 8201 Ethernet PHY.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 arch/powerpc/boot/dts/mpc8349emitx.dts   |    8 ++++++++
 arch/powerpc/boot/dts/mpc8349emitxgp.dts |    8 ++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)
Kumar Gala - Oct. 21, 2008, 4:39 a.m.
On Oct 17, 2008, at 1:56 PM, Anton Vorontsov wrote:

> The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt  
> signal
> is connected to the IPIC's EXT2 interrupt line, the line is shared  
> with
> Vitesse 8201 Ethernet PHY.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8349emitx.dts   |    8 ++++++++
> arch/powerpc/boot/dts/mpc8349emitxgp.dts |    8 ++++++++
> 2 files changed, 16 insertions(+), 0 deletions(-)

applied

- k
Scott Wood - Oct. 21, 2008, 6:23 p.m.
On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> index 5cedf37..7fc5414 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> @@ -83,6 +83,14 @@
>  			interrupts = <15 0x8>;
>  			interrupt-parent = <&ipic>;
>  			dfsrr;
> +
> +			rtc@68 {
> +				device_type = "rtc";
> +				compatible = "dallas,ds1339";
> +				reg = <0x68>;
> +				interrupts = <18 0x8>;
> +				interrupt-parent = <&ipic>;
> +			};

Why are we adding more device_types?

-Scott
Kumar Gala - Oct. 21, 2008, 6:35 p.m.
On Oct 21, 2008, at 1:23 PM, Scott Wood wrote:

> On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
>> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/ 
>> boot/dts/mpc8349emitx.dts
>> index 5cedf37..7fc5414 100644
>> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
>> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
>> @@ -83,6 +83,14 @@
>> 			interrupts = <15 0x8>;
>> 			interrupt-parent = <&ipic>;
>> 			dfsrr;
>> +
>> +			rtc@68 {
>> +				device_type = "rtc";
>> +				compatible = "dallas,ds1339";
>> +				reg = <0x68>;
>> +				interrupts = <18 0x8>;
>> +				interrupt-parent = <&ipic>;
>> +			};
>
> Why are we adding more device_types?

I think the 'rtc' device_type is legacy from OF.

- k
Scott Wood - Oct. 21, 2008, 6:39 p.m.
Kumar Gala wrote:
> On Oct 21, 2008, at 1:23 PM, Scott Wood wrote:
>> Why are we adding more device_types?
> 
> I think the 'rtc' device_type is legacy from OF.

Yes, and it advertises a run-time service that we do not and cannot 
support.  We should not have it in flat trees.

-Scott
Anton Vorontsov - Oct. 21, 2008, 6:41 p.m.
On Tue, Oct 21, 2008 at 01:23:44PM -0500, Scott Wood wrote:
> On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
> > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > index 5cedf37..7fc5414 100644
> > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > @@ -83,6 +83,14 @@
> >  			interrupts = <15 0x8>;
> >  			interrupt-parent = <&ipic>;
> >  			dfsrr;
> > +
> > +			rtc@68 {
> > +				device_type = "rtc";
> > +				compatible = "dallas,ds1339";
> > +				reg = <0x68>;
> > +				interrupts = <18 0x8>;
> > +				interrupt-parent = <&ipic>;
> > +			};
> 
> Why are we adding more device_types?

It seems that CHRP is using the device_type for rtc devices, which
means that real OF also provide it. But I guess we don't need it,
right? Then we should cleanup all the boards.

Patch

diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 5cedf37..7fc5414 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -83,6 +83,14 @@ 
 			interrupts = <15 0x8>;
 			interrupt-parent = <&ipic>;
 			dfsrr;
+
+			rtc@68 {
+				device_type = "rtc";
+				compatible = "dallas,ds1339";
+				reg = <0x68>;
+				interrupts = <18 0x8>;
+				interrupt-parent = <&ipic>;
+			};
 		};
 
 		spi@7000 {
diff --git a/arch/powerpc/boot/dts/mpc8349emitxgp.dts b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
index 81ae1d3..fa40647 100644
--- a/arch/powerpc/boot/dts/mpc8349emitxgp.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
@@ -81,6 +81,14 @@ 
 			interrupts = <15 0x8>;
 			interrupt-parent = <&ipic>;
 			dfsrr;
+
+			rtc@68 {
+				device_type = "rtc";
+				compatible = "dallas,ds1339";
+				reg = <0x68>;
+				interrupts = <18 0x8>;
+				interrupt-parent = <&ipic>;
+			};
 		};
 
 		spi@7000 {