| Message ID | 1435428843-29750-8-git-send-email-jteki@openedev.com |
|---|---|
| State | Accepted |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Hi Jagan, On 27 June 2015 at 12:13, Jagan Teki <jteki@openedev.com> wrote: > Added SPI_FLASH_DATAFLASH entry on Kconfig with help description > > Signed-off-by: Jagan Teki <jteki@openedev.com> > Cc: Haikun Wang <haikun.wang@freescale.com> > Cc: Simon Glass <sjg@chromium.org> > --- > drivers/mtd/spi/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org> > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > index 217e4d7..6b38ffc 100644 > --- a/drivers/mtd/spi/Kconfig > +++ b/drivers/mtd/spi/Kconfig > @@ -35,6 +35,14 @@ config SPI_FLASH > > If unsure, say N > > +config SPI_FLASH_DATAFLASH > + bool "AT45xxx DataFlash support" > + depends on SPI_FLASH && DM_SPI_FLASH > + help > + Enable the access for SPI Flash based AT45xxx DataFlash chips. nit: SPI-flash-based You could talk a little more about the chips capabilities? Normally we try to have 4 lines here. > + > + If unsure, say N > + > config SPI_FLASH_MTD > bool "SPI Flash MTD support" > depends on SPI_FLASH > -- > 1.9.1 > Regards, Simon
On 1 July 2015 at 01:18, Simon Glass <sjg@chromium.org> wrote: > Hi Jagan, > > On 27 June 2015 at 12:13, Jagan Teki <jteki@openedev.com> wrote: >> Added SPI_FLASH_DATAFLASH entry on Kconfig with help description >> >> Signed-off-by: Jagan Teki <jteki@openedev.com> >> Cc: Haikun Wang <haikun.wang@freescale.com> >> Cc: Simon Glass <sjg@chromium.org> >> --- >> drivers/mtd/spi/Kconfig | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > Reviewed-by: Simon Glass <sjg@chromium.org> > >> >> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig >> index 217e4d7..6b38ffc 100644 >> --- a/drivers/mtd/spi/Kconfig >> +++ b/drivers/mtd/spi/Kconfig >> @@ -35,6 +35,14 @@ config SPI_FLASH >> >> If unsure, say N >> >> +config SPI_FLASH_DATAFLASH >> + bool "AT45xxx DataFlash support" >> + depends on SPI_FLASH && DM_SPI_FLASH >> + help >> + Enable the access for SPI Flash based AT45xxx DataFlash chips. > > nit: SPI-flash-based > > You could talk a little more about the chips capabilities? Normally we > try to have 4 lines here. > >> + >> + If unsure, say N >> + >> config SPI_FLASH_MTD >> bool "SPI Flash MTD support" >> depends on SPI_FLASH >> -- Applied to u-boot-spi/master thanks!
diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig index 217e4d7..6b38ffc 100644 --- a/drivers/mtd/spi/Kconfig +++ b/drivers/mtd/spi/Kconfig @@ -35,6 +35,14 @@ config SPI_FLASH If unsure, say N +config SPI_FLASH_DATAFLASH + bool "AT45xxx DataFlash support" + depends on SPI_FLASH && DM_SPI_FLASH + help + Enable the access for SPI Flash based AT45xxx DataFlash chips. + + If unsure, say N + config SPI_FLASH_MTD bool "SPI Flash MTD support" depends on SPI_FLASH
Added SPI_FLASH_DATAFLASH entry on Kconfig with help description Signed-off-by: Jagan Teki <jteki@openedev.com> Cc: Haikun Wang <haikun.wang@freescale.com> Cc: Simon Glass <sjg@chromium.org> --- drivers/mtd/spi/Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+)