diff mbox

m68k: remove useless file m68k-qreg.h

Message ID 1435104444-2550-1-git-send-email-laurent@vivier.eu
State New
Headers show

Commit Message

Laurent Vivier June 24, 2015, 12:07 a.m. UTC
Unused since:

    commit e1f3808e03f73e7a7fa966afbed2455dd052202e
    Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
    Date:   Sat May 24 22:29:16 2008 +0000

        Convert m68k target to TCG.

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 target-m68k/m68k-qreg.h | 11 -----------
 1 file changed, 11 deletions(-)
 delete mode 100644 target-m68k/m68k-qreg.h

Comments

Peter Crosthwaite June 24, 2015, 12:19 a.m. UTC | #1
On Tue, Jun 23, 2015 at 5:07 PM, Laurent Vivier <laurent@vivier.eu> wrote:
> Unused since:
>
>     commit e1f3808e03f73e7a7fa966afbed2455dd052202e
>     Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>     Date:   Sat May 24 22:29:16 2008 +0000
>
>         Convert m68k target to TCG.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>

You should cc qemu-trivial on dead-code deletions and the like. This
is also a patch queue in its own right so there is no need to identify
m68k owner for this.

Regards,
Peter

> ---
>  target-m68k/m68k-qreg.h | 11 -----------
>  1 file changed, 11 deletions(-)
>  delete mode 100644 target-m68k/m68k-qreg.h
>
> diff --git a/target-m68k/m68k-qreg.h b/target-m68k/m68k-qreg.h
> deleted file mode 100644
> index c224d5e..0000000
> --- a/target-m68k/m68k-qreg.h
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -enum {
> -#define DEFO32(name, offset) QREG_##name,
> -#define DEFR(name, reg, mode) QREG_##name,
> -#define DEFF64(name, offset) QREG_##name,
> -    QREG_NULL,
> -#include "qregs.def"
> -    TARGET_NUM_QREGS = 0x100
> -#undef DEFO32
> -#undef DEFR
> -#undef DEFF64
> -};
> --
> 2.4.3
>
>
Laurent Vivier June 24, 2015, 12:21 a.m. UTC | #2
Le 24/06/2015 02:19, Peter Crosthwaite a écrit :
> On Tue, Jun 23, 2015 at 5:07 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>> Unused since:
>>
>>     commit e1f3808e03f73e7a7fa966afbed2455dd052202e
>>     Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>>     Date:   Sat May 24 22:29:16 2008 +0000
>>
>>         Convert m68k target to TCG.
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> 
> You should cc qemu-trivial on dead-code deletions and the like. This
> is also a patch queue in its own right so there is no need to identify
> m68k owner for this.

OK, thank you. Should I resend them ?

Laurent
Peter Crosthwaite June 24, 2015, 12:23 a.m. UTC | #3
On Tue, Jun 23, 2015 at 5:21 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>
>
> Le 24/06/2015 02:19, Peter Crosthwaite a écrit :
>> On Tue, Jun 23, 2015 at 5:07 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>>> Unused since:
>>>
>>>     commit e1f3808e03f73e7a7fa966afbed2455dd052202e
>>>     Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>>>     Date:   Sat May 24 22:29:16 2008 +0000
>>>
>>>         Convert m68k target to TCG.
>>>
>>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>>
>> You should cc qemu-trivial on dead-code deletions and the like. This
>> is also a patch queue in its own right so there is no need to identify
>> m68k owner for this.
>
> OK, thank you. Should I resend them ?
>

No should be ok, I think the maintainer can handle it via
after-the-fact CCs. I have ccd this one just now.

Regards,
Peter


> Laurent
>
Thomas Huth June 24, 2015, 7:12 p.m. UTC | #4
On Wed, 24 Jun 2015 02:07:24 +0200
Laurent Vivier <laurent@vivier.eu> wrote:

> Unused since:
> 
>     commit e1f3808e03f73e7a7fa966afbed2455dd052202e
>     Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>     Date:   Sat May 24 22:29:16 2008 +0000
> 
>         Convert m68k target to TCG.
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  target-m68k/m68k-qreg.h | 11 -----------
>  1 file changed, 11 deletions(-)
>  delete mode 100644 target-m68k/m68k-qreg.h
> 
> diff --git a/target-m68k/m68k-qreg.h b/target-m68k/m68k-qreg.h
> deleted file mode 100644
> index c224d5e..0000000
> --- a/target-m68k/m68k-qreg.h
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -enum {
> -#define DEFO32(name, offset) QREG_##name,
> -#define DEFR(name, reg, mode) QREG_##name,
> -#define DEFF64(name, offset) QREG_##name,
> -    QREG_NULL,
> -#include "qregs.def"
> -    TARGET_NUM_QREGS = 0x100
> -#undef DEFO32
> -#undef DEFR
> -#undef DEFF64
> -};

Reviewed-by: Thomas Huth <huth@tuxfamily.org>
diff mbox

Patch

diff --git a/target-m68k/m68k-qreg.h b/target-m68k/m68k-qreg.h
deleted file mode 100644
index c224d5e..0000000
--- a/target-m68k/m68k-qreg.h
+++ /dev/null
@@ -1,11 +0,0 @@ 
-enum {
-#define DEFO32(name, offset) QREG_##name,
-#define DEFR(name, reg, mode) QREG_##name,
-#define DEFF64(name, offset) QREG_##name,
-    QREG_NULL,
-#include "qregs.def"
-    TARGET_NUM_QREGS = 0x100
-#undef DEFO32
-#undef DEFR
-#undef DEFF64
-};