From patchwork Sat Mar 27 13:35:37 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 48747 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 26B68B7CF0 for ; Sun, 28 Mar 2010 00:37:45 +1100 (EST) Received: from localhost ([127.0.0.1]:34960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvWCr-0002JO-W1 for incoming@patchwork.ozlabs.org; Sat, 27 Mar 2010 09:37:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvWB9-0001t8-GS for qemu-devel@nongnu.org; Sat, 27 Mar 2010 09:35:55 -0400 Received: from [140.186.70.92] (port=49654 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvWB7-0001pA-Iy for qemu-devel@nongnu.org; Sat, 27 Mar 2010 09:35:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvWAw-0000Qm-CM for qemu-devel@nongnu.org; Sat, 27 Mar 2010 09:35:43 -0400 Received: from isrv.corpit.ru ([81.13.33.159]:37563) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvWAw-0000QI-5S for qemu-devel@nongnu.org; Sat, 27 Mar 2010 09:35:42 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.10.88]) by isrv.corpit.ru (Postfix) with ESMTP id 3255C43CC5; Sat, 27 Mar 2010 16:35:38 +0300 (MSK) (envelope-from mjt@tls.msk.ru) Message-ID: <4BAE09A9.8020505@msgid.tls.msk.ru> Date: Sat, 27 Mar 2010 16:35:37 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706) MIME-Version: 1.0 To: Aurelien Jarno Subject: Re: [Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages References: <4B9F3AEA.8010408@msgid.tls.msk.ru> <20100327123350.GA19617@volta.aurel32.net> In-Reply-To: <20100327123350.GA19617@volta.aurel32.net> X-Enigmail-Version: 0.95.0 OpenPGP: id=804465C5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: qemu-devel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Aurelien Jarno wrote: > On Tue, Mar 16, 2010 at 11:01:46AM +0300, Michael Tokarev wrote: >> The error message qemu gives when hugetlbfs is not >> accessible is cryptic at best: >> >> mkstemp: Permission denied >> >> Make it a bit more specific instead: >> >> unable to create backing store for hugepages: Permission denied >> >> Thanks! > > It looks good, but needs a Signed-off-by: line. Are we now requiring such S-o-b lines even for such trivial stuff? Oh well..... Ok, here we go, with another perror() case converted to be a bit less cryptic. Thanks! Signed-Off-By: Michael Tokarev diff --git a/exec.c b/exec.c index fcffb0f..90032a5 100644 --- a/exec.c +++ b/exec.c @@ -2438,7 +2438,7 @@ static long gethugepagesize(const char *path) } while (ret != 0 && errno == EINTR); if (ret != 0) { - perror("statfs"); + perror(path); return 0; } @@ -2483,7 +2483,7 @@ static void *file_ram_alloc(ram_addr_t memory, const char *path) fd = mkstemp(filename); if (fd < 0) { - perror("mkstemp"); + perror("unable to create backing store for hugepages"); free(filename); return NULL; }