diff mbox

radius: Fix NULL dereference issue

Message ID 1434943935-4232-1-git-send-email-maneesh.jain@samsung.com
State Accepted
Headers show

Commit Message

Maneesh Jain June 22, 2015, 3:32 a.m. UTC 
In case malloc return fail, "data->pac_opaque_encr_key" may be NULL
and lead to possible crash.

Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
---
 src/radius/radius_server.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--
1.7.9.5

Comments

Jouni Malinen June 26, 2015, 10:08 p.m. UTC | #1 
On Mon, Jun 22, 2015 at 09:02:15AM +0530, Maneesh Jain wrote:
> In case malloc return fail, "data->pac_opaque_encr_key" may be NULL
> and lead to possible crash.

Thanks, applied.
diff mbox

Patch

diff --git a/src/radius/radius_server.c b/src/radius/radius_server.c
index 1c69955..8b99521
--- a/src/radius/radius_server.c
+++ b/src/radius/radius_server.c
@@ -1711,8 +1711,9 @@  radius_server_init(struct radius_server_conf *conf)
 	data->ipv6 = conf->ipv6;
 	if (conf->pac_opaque_encr_key) {
 		data->pac_opaque_encr_key = os_malloc(16);
-		os_memcpy(data->pac_opaque_encr_key, conf->pac_opaque_encr_key,
-			  16);
+		if(data->pac_opaque_encr_key)
+			os_memcpy(data->pac_opaque_encr_key, conf->pac_opaque_encr_key,
+				16);
 	}
 	if (conf->eap_fast_a_id) {
 		data->eap_fast_a_id = os_malloc(conf->eap_fast_a_id_len);