| Message ID | 1434885903-22713-1-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Accepted |
| Headers | show |
Gustavo, All, On 2015-06-21 08:25 -0300, Gustavo Zacarias spake thusly: > In ab71dff0 it was moved to SUBDIR, but this was never reflected for the > legal-info files, update this to fix: > http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/ > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/openvmtools/openvmtools.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk > index 9819640..e22153b 100644 > --- a/package/openvmtools/openvmtools.mk > +++ b/package/openvmtools/openvmtools.mk > @@ -7,7 +7,7 @@ > OPENVMTOOLS_VERSION = stable-9.10.0 > OPENVMTOOLS_SITE = $(call github,vmware,open-vm-tools,$(OPENVMTOOLS_VERSION)) > OPENVMTOOLS_LICENSE = LGPLv2.1 > -OPENVMTOOLS_LICENSE_FILES = COPYING > +OPENVMTOOLS_LICENSE_FILES = $(OPENVMTOOLS_SUBDIR)/COPYING I know this has no impact in Makefiles, but I prefer when we define variables before we use them, it's easier to understand. So, I'd prefer we define OPENVMTOOLS_SUBDIR before we use it. Otherwise: Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > # Autoreconf needed or config/missing will run configure again at buildtime > OPENVMTOOLS_AUTORECONF = YES > OPENVMTOOLS_SUBDIR = open-vm-tools > -- > 2.3.6 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Gustavo, all, sorry, I missed this one. Tested with make legal-info. > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > Reviewed-by: Karoly Kasza <kaszak@gmail.com> Tested-by: Karoly Kasza <kaszak@gmail.com> Best regards, Karoly
On 21/06/15 09:05, Károly Kasza wrote: > Hi Gustavo, all, > > sorry, I missed this one. Hi all. I wonder if it wouldn't be better to just use subdir in the legal info, i don't think there's any package using/needing to fetch the files outside of it. Regards.
Dear Gustavo Zacarias, On Sun, 21 Jun 2015 08:25:03 -0300, Gustavo Zacarias wrote: > In ab71dff0 it was moved to SUBDIR, but this was never reflected for the > legal-info files, update this to fix: > http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/ > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/openvmtools/openvmtools.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied after adjusting the variable order, as suggested by Yann. Thanks! Thomas
Dear Gustavo, Gustavo Zacarias wrote: > > > On 21/06/15 09:05, Károly Kasza wrote: > >> Hi Gustavo, all, >> >> sorry, I missed this one. > > Hi all. > I wonder if it wouldn't be better to just use subdir in the legal info, Looks like a good idea, but... > i don't think there's any package using/needing to fetch the files > outside of it. ...we have them! :( Here's a couple examples: $ git grep -E '_(LICENSE_FILES|SUBDIR) =' -- package/samba package/berkeleydb/ package/berkeleydb/berkeleydb.mk:BERKELEYDB_SUBDIR = build_unix package/berkeleydb/berkeleydb.mk:BERKELEYDB_LICENSE_FILES = LICENSE package/samba/samba.mk:SAMBA_SUBDIR = source3 package/samba/samba.mk:SAMBA_LICENSE_FILES = COPYING $ Setting SAMBA_LICENSE_FILES to ../COPYING does not look very nice to me.
On 22/06/15 11:03, Luca Ceresoli wrote: > ...we have them! :( Here's a couple examples: > > $ git grep -E '_(LICENSE_FILES|SUBDIR) =' -- package/samba > package/berkeleydb/ > package/berkeleydb/berkeleydb.mk:BERKELEYDB_SUBDIR = build_unix > package/berkeleydb/berkeleydb.mk:BERKELEYDB_LICENSE_FILES = LICENSE > package/samba/samba.mk:SAMBA_SUBDIR = source3 > package/samba/samba.mk:SAMBA_LICENSE_FILES = COPYING > $ > > Setting SAMBA_LICENSE_FILES to ../COPYING does not look very nice to me. D'oh! Samba is going away, it's already deprecated in favour of samba4, but it still leaves berkeleydb. Regards.
Dear Gustavo, Gustavo Zacarias wrote: > > > On 22/06/15 11:03, Luca Ceresoli wrote: > >> ...we have them! :( Here's a couple examples: >> >> $ git grep -E '_(LICENSE_FILES|SUBDIR) =' -- package/samba >> package/berkeleydb/ >> package/berkeleydb/berkeleydb.mk:BERKELEYDB_SUBDIR = build_unix >> package/berkeleydb/berkeleydb.mk:BERKELEYDB_LICENSE_FILES = LICENSE >> package/samba/samba.mk:SAMBA_SUBDIR = source3 >> package/samba/samba.mk:SAMBA_LICENSE_FILES = COPYING >> $ >> >> Setting SAMBA_LICENSE_FILES to ../COPYING does not look very nice to me. > > D'oh! > Samba is going away, it's already deprecated in favour of samba4, but it > still leaves berkeleydb. These are the first two examples I found. Most likely there are more.
diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk index 9819640..e22153b 100644 --- a/package/openvmtools/openvmtools.mk +++ b/package/openvmtools/openvmtools.mk @@ -7,7 +7,7 @@ OPENVMTOOLS_VERSION = stable-9.10.0 OPENVMTOOLS_SITE = $(call github,vmware,open-vm-tools,$(OPENVMTOOLS_VERSION)) OPENVMTOOLS_LICENSE = LGPLv2.1 -OPENVMTOOLS_LICENSE_FILES = COPYING +OPENVMTOOLS_LICENSE_FILES = $(OPENVMTOOLS_SUBDIR)/COPYING # Autoreconf needed or config/missing will run configure again at buildtime OPENVMTOOLS_AUTORECONF = YES OPENVMTOOLS_SUBDIR = open-vm-tools
In ab71dff0 it was moved to SUBDIR, but this was never reflected for the legal-info files, update this to fix: http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/ Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/openvmtools/openvmtools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)