Patchwork [18/48] make cursor grab optional

login
register
mail settings
Submitter Riku Voipio
Date March 26, 2010, 4:06 p.m.
Message ID <44f3433411b5c623f402cf63039b95d66188cd7c.1269617186.git.riku.voipio@nokia.com>
Download mbox | patch
Permalink /patch/48674/
State New
Headers show

Comments

Riku Voipio - March 26, 2010, 4:06 p.m.
From: Riku Voipio <riku.voipio@nokia.com>

Signed-Off-By: Riku Voipio <riku.voipio@nokia.com>

---
 sysemu.h |    1 +
 vl.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Aurelien Jarno - April 8, 2010, 7:10 p.m.
On Fri, Mar 26, 2010 at 04:06:38PM +0000, Riku Voipio wrote:
> From: Riku Voipio <riku.voipio@nokia.com>
> 
> Signed-Off-By: Riku Voipio <riku.voipio@nokia.com>
> 
> ---
>  sysemu.h |    1 +
>  vl.c     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sysemu.h b/sysemu.h
> index 525efd1..5b4ddd8 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -128,6 +128,7 @@ extern int usb_enabled;
>  extern int smp_cpus;
>  extern int max_cpus;
>  extern int cursor_hide;
> +extern int cursor_allow_grab;
>  extern int graphic_rotate;
>  extern int no_quit;
>  extern int semihosting_enabled;
> diff --git a/vl.c b/vl.c
> index b4dfb2e..bc7635c 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -224,6 +224,7 @@ int fd_bootchk = 1;
>  int no_reboot = 0;
>  int no_shutdown = 0;
>  int cursor_hide = 1;
> +int cursor_allow_grab = 1;
>  int graphic_rotate = 0;
>  uint8_t irq0override = 1;
>  #ifndef _WIN32

It looks like this patch is not complete. Adding a new variable won't
add the feature automatically ;-)
andrzej zaborowski - April 22, 2010, 2:01 a.m.
On 26 March 2010 18:06, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Riku Voipio <riku.voipio@nokia.com>
>
> Signed-Off-By: Riku Voipio <riku.voipio@nokia.com>
>
> ---
>  sysemu.h |    1 +
>  vl.c     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sysemu.h b/sysemu.h
> index 525efd1..5b4ddd8 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -128,6 +128,7 @@ extern int usb_enabled;
>  extern int smp_cpus;
>  extern int max_cpus;
>  extern int cursor_hide;
> +extern int cursor_allow_grab;
>  extern int graphic_rotate;
>  extern int no_quit;
>  extern int semihosting_enabled;
> diff --git a/vl.c b/vl.c
> index b4dfb2e..bc7635c 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -224,6 +224,7 @@ int fd_bootchk = 1;
>  int no_reboot = 0;
>  int no_shutdown = 0;
>  int cursor_hide = 1;
> +int cursor_allow_grab = 1;
>  int graphic_rotate = 0;
>  uint8_t irq0override = 1;
>  #ifndef _WIN32
> --
> 1.6.5
>
>
>
>

The n900 uses a touchscreen, right?  For absolute pointer devices
there's no need to do the grab so unless something else is broken, you
shouldn't need to disallow it from command line.

Cheers

Patch

diff --git a/sysemu.h b/sysemu.h
index 525efd1..5b4ddd8 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -128,6 +128,7 @@  extern int usb_enabled;
 extern int smp_cpus;
 extern int max_cpus;
 extern int cursor_hide;
+extern int cursor_allow_grab;
 extern int graphic_rotate;
 extern int no_quit;
 extern int semihosting_enabled;
diff --git a/vl.c b/vl.c
index b4dfb2e..bc7635c 100644
--- a/vl.c
+++ b/vl.c
@@ -224,6 +224,7 @@  int fd_bootchk = 1;
 int no_reboot = 0;
 int no_shutdown = 0;
 int cursor_hide = 1;
+int cursor_allow_grab = 1;
 int graphic_rotate = 0;
 uint8_t irq0override = 1;
 #ifndef _WIN32