diff mbox

tap: fix non-linux build

Message ID 1434699834-27593-1-git-send-email-mst@redhat.com
State New
Headers show

Commit Message

Michael S. Tsirkin June 19, 2015, 7:44 a.m. UTC 
tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
fix it up.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 net/tap-aix.c     | 10 ++++++++++
 net/tap-bsd.c     | 10 ++++++++++
 net/tap-haiku.c   | 10 ++++++++++
 net/tap-solaris.c | 10 ++++++++++
 net/tap-win32.c   | 10 ++++++++++
 5 files changed, 50 insertions(+)

Comments

Thomas Huth June 19, 2015, 8:16 a.m. UTC | #1 
On Fri, 19 Jun 2015 09:44:00 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
> fix it up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  net/tap-aix.c     | 10 ++++++++++
>  net/tap-bsd.c     | 10 ++++++++++
>  net/tap-haiku.c   | 10 ++++++++++
>  net/tap-solaris.c | 10 ++++++++++
>  net/tap-win32.c   | 10 ++++++++++
>  5 files changed, 50 insertions(+)
> 
> diff --git a/net/tap-aix.c b/net/tap-aix.c
> index 18fdbf3..e84fc39 100644
> --- a/net/tap-aix.c
> +++ b/net/tap-aix.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index 5889920..7028d9b 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-haiku.c b/net/tap-haiku.c
> index d18590c..2e738ec 100644
> --- a/net/tap-haiku.c
> +++ b/net/tap-haiku.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> index 90b2fd1..0f60f78 100644
> --- a/net/tap-solaris.c
> +++ b/net/tap-solaris.c
> @@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index f6fc961..625d53c 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
>  {
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>
Greg Kurz June 19, 2015, 9:26 a.m. UTC | #2 
On Fri, 19 Jun 2015 09:44:00 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
> fix it up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  net/tap-aix.c     | 10 ++++++++++
>  net/tap-bsd.c     | 10 ++++++++++
>  net/tap-haiku.c   | 10 ++++++++++
>  net/tap-solaris.c | 10 ++++++++++
>  net/tap-win32.c   | 10 ++++++++++
>  5 files changed, 50 insertions(+)
> 
> diff --git a/net/tap-aix.c b/net/tap-aix.c
> index 18fdbf3..e84fc39 100644
> --- a/net/tap-aix.c
> +++ b/net/tap-aix.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
> 
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index 5889920..7028d9b 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
> 
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-haiku.c b/net/tap-haiku.c
> index d18590c..2e738ec 100644
> --- a/net/tap-haiku.c
> +++ b/net/tap-haiku.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
> 
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> index 90b2fd1..0f60f78 100644
> --- a/net/tap-solaris.c
> +++ b/net/tap-solaris.c
> @@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
> 
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index f6fc961..625d53c 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
> 
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
>  {
>  }

I couldn't setup a build environment on a non-linux platform (tried AIX
but I miss to many packages), so I won't give a Tested-by... patch is trivial
though so:

Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
diff mbox

Patch

diff --git a/net/tap-aix.c b/net/tap-aix.c
index 18fdbf3..e84fc39 100644
--- a/net/tap-aix.c
+++ b/net/tap-aix.c
@@ -55,6 +55,16 @@  void tap_fd_set_vnet_hdr_len(int fd, int len)
 {
 }
 
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+    return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+    return -EINVAL;
+}
+
 void tap_fd_set_offload(int fd, int csum, int tso4,
                         int tso6, int ecn, int ufo)
 {
diff --git a/net/tap-bsd.c b/net/tap-bsd.c
index 5889920..7028d9b 100644
--- a/net/tap-bsd.c
+++ b/net/tap-bsd.c
@@ -196,6 +196,16 @@  void tap_fd_set_vnet_hdr_len(int fd, int len)
 {
 }
 
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+    return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+    return -EINVAL;
+}
+
 void tap_fd_set_offload(int fd, int csum, int tso4,
                         int tso6, int ecn, int ufo)
 {
diff --git a/net/tap-haiku.c b/net/tap-haiku.c
index d18590c..2e738ec 100644
--- a/net/tap-haiku.c
+++ b/net/tap-haiku.c
@@ -55,6 +55,16 @@  void tap_fd_set_vnet_hdr_len(int fd, int len)
 {
 }
 
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+    return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+    return -EINVAL;
+}
+
 void tap_fd_set_offload(int fd, int csum, int tso4,
                         int tso6, int ecn, int ufo)
 {
diff --git a/net/tap-solaris.c b/net/tap-solaris.c
index 90b2fd1..0f60f78 100644
--- a/net/tap-solaris.c
+++ b/net/tap-solaris.c
@@ -223,6 +223,16 @@  void tap_fd_set_vnet_hdr_len(int fd, int len)
 {
 }
 
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+    return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+    return -EINVAL;
+}
+
 void tap_fd_set_offload(int fd, int csum, int tso4,
                         int tso6, int ecn, int ufo)
 {
diff --git a/net/tap-win32.c b/net/tap-win32.c
index f6fc961..625d53c 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -688,6 +688,16 @@  void tap_fd_set_vnet_hdr_len(int fd, int len)
 {
 }
 
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+    return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+    return -EINVAL;
+}
+
 static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
 {
 }