| Message ID | 1434646944-24040-4-git-send-email-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 2015/6/19 1:02, Daniel P. Berrange wrote: > To prepare for a generic internal cipher API, move the > built-in D3DES implementation into the crypto/ directory. > > This is not in fact a normal D3DES implementation, it is > D3DES with double & triple length modes removed, and the > key bytes in reversed bit order. IOW it is crippled > specifically for the "benefit" of RFB, so call the new > files desrfb.c instead of d3des.c to make it clear that > it isn't a generally useful impl. > > Signed-off-by: Daniel P. Berrange <berrange@redhat.com> > --- > crypto/Makefile.objs | 1 + > ui/d3des.c => crypto/desrfb.c | 2 +- > ui/d3des.h => include/crypto/desrfb.h | 0 > ui/Makefile.objs | 2 +- > ui/vnc.c | 2 +- > 5 files changed, 4 insertions(+), 3 deletions(-) > rename ui/d3des.c => crypto/desrfb.c (99%) > rename ui/d3des.h => include/crypto/desrfb.h (100%) Reviewed-by: Gonglei <arei.gonglei@huawei.com>
diff --git a/crypto/Makefile.objs b/crypto/Makefile.objs index 9efc9b4..9f70294 100644 --- a/crypto/Makefile.objs +++ b/crypto/Makefile.objs @@ -1,3 +1,4 @@ util-obj-y += init.o util-obj-y += hash.o util-obj-y += aes.o +util-obj-y += desrfb.o diff --git a/ui/d3des.c b/crypto/desrfb.c similarity index 99% rename from ui/d3des.c rename to crypto/desrfb.c index 5bc99b8..fc20a30 100644 --- a/ui/d3des.c +++ b/crypto/desrfb.c @@ -26,7 +26,7 @@ * (GEnie : OUTER; CIS : [71755,204]) Graven Imagery, 1992. */ -#include "d3des.h" +#include "crypto/desrfb.h" static void scrunch(unsigned char *, unsigned long *); static void unscrun(unsigned long *, unsigned char *); diff --git a/ui/d3des.h b/include/crypto/desrfb.h similarity index 100% rename from ui/d3des.h rename to include/crypto/desrfb.h diff --git a/ui/Makefile.objs b/ui/Makefile.objs index 023914c..dd1f8e4 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -1,4 +1,4 @@ -vnc-obj-y += vnc.o d3des.o +vnc-obj-y += vnc.o vnc-obj-y += vnc-enc-zlib.o vnc-enc-hextile.o vnc-obj-y += vnc-enc-tight.o vnc-palette.o vnc-obj-y += vnc-enc-zrle.o diff --git a/ui/vnc.c b/ui/vnc.c index 69b605c..d86f9c2 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -46,7 +46,7 @@ static const struct timeval VNC_REFRESH_STATS = { 0, 500000 }; static const struct timeval VNC_REFRESH_LOSSY = { 2, 0 }; #include "vnc_keysym.h" -#include "d3des.h" +#include "crypto/desrfb.h" static QTAILQ_HEAD(, VncDisplay) vnc_displays = QTAILQ_HEAD_INITIALIZER(vnc_displays);
To prepare for a generic internal cipher API, move the built-in D3DES implementation into the crypto/ directory. This is not in fact a normal D3DES implementation, it is D3DES with double & triple length modes removed, and the key bytes in reversed bit order. IOW it is crippled specifically for the "benefit" of RFB, so call the new files desrfb.c instead of d3des.c to make it clear that it isn't a generally useful impl. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- crypto/Makefile.objs | 1 + ui/d3des.c => crypto/desrfb.c | 2 +- ui/d3des.h => include/crypto/desrfb.h | 0 ui/Makefile.objs | 2 +- ui/vnc.c | 2 +- 5 files changed, 4 insertions(+), 3 deletions(-) rename ui/d3des.c => crypto/desrfb.c (99%) rename ui/d3des.h => include/crypto/desrfb.h (100%)