Patchwork netdev/fec: fix compiling warning

login
register
mail settings
Submitter Bryan Wu
Date March 26, 2010, 9:03 a.m.
Message ID <1269594235-9628-1-git-send-email-bryan.wu@canonical.com>
Download mbox | patch
Permalink /patch/48621/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Bryan Wu - March 26, 2010, 9:03 a.m.
BugLink: http://bugs.launchpad.net/bugs/457878

Missed to set .ndo_do_ioctl as fec_enet_ioctl, so will generate a compiling
warning due to nobody uses fec_enet_ioctl. This patch fixed that.

Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 drivers/net/fec.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Amit Kucheria - March 26, 2010, 9:23 a.m.
On 10 Mar 26, Bryan Wu wrote:
> BugLink: http://bugs.launchpad.net/bugs/457878
> 
> Missed to set .ndo_do_ioctl as fec_enet_ioctl, so will generate a compiling
> warning due to nobody uses fec_enet_ioctl. This patch fixed that.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
Acked-by: Amit Kucheria <amit.kucheria@canonical.com>

> ---
>  drivers/net/fec.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 62fc74d..9d99359 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -1066,6 +1066,7 @@ static const struct net_device_ops fec_netdev_ops = {
>  	.ndo_validate_addr	= eth_validate_addr,
>  	.ndo_tx_timeout		= fec_timeout,
>  	.ndo_set_mac_address	= fec_set_mac_address,
> +	.ndo_do_ioctl		= fec_enet_ioctl,
>  };
>  
>   /*
> -- 
> 1.7.0.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Colin King - March 26, 2010, 9:28 a.m.
Very reasonable to me.

On Fri, 2010-03-26 at 17:03 +0800, Bryan Wu wrote:
> BugLink: http://bugs.launchpad.net/bugs/457878
> 
> Missed to set .ndo_do_ioctl as fec_enet_ioctl, so will generate a compiling
> warning due to nobody uses fec_enet_ioctl. This patch fixed that.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
>  drivers/net/fec.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 62fc74d..9d99359 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -1066,6 +1066,7 @@ static const struct net_device_ops fec_netdev_ops = {
>  	.ndo_validate_addr	= eth_validate_addr,
>  	.ndo_tx_timeout		= fec_timeout,
>  	.ndo_set_mac_address	= fec_set_mac_address,
> +	.ndo_do_ioctl		= fec_enet_ioctl,
>  };
>  
>   /*
> -- 
> 1.7.0.1
> 
> 
Acked-by: Colin King <colin.king@canonical.com>
Stefan Bader - March 26, 2010, 10:04 a.m.
Applied to Lucid fsl-imx51

Patch

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 62fc74d..9d99359 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1066,6 +1066,7 @@  static const struct net_device_ops fec_netdev_ops = {
 	.ndo_validate_addr	= eth_validate_addr,
 	.ndo_tx_timeout		= fec_timeout,
 	.ndo_set_mac_address	= fec_set_mac_address,
+	.ndo_do_ioctl		= fec_enet_ioctl,
 };
 
  /*