diff mbox

[01/30] acpi: acpitables: remove ECDT test as we now have a full ECDT test

Message ID 1434617382-9980-2-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King June 18, 2015, 8:49 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The trivial ECDT test in acpitables is now redundant since we
now have a more feature rich version.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/acpitables/acpitables.c | 28 ----------------------------
 1 file changed, 28 deletions(-)

Comments

Alex Hung June 23, 2015, 5:39 a.m. UTC | #1 
On 06/18/2015 04:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The trivial ECDT test in acpitables is now redundant since we
> now have a more feature rich version.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/acpitables/acpitables.c | 28 ----------------------------
>  1 file changed, 28 deletions(-)
> 
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 1d3eb0c..63c3605 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -25,33 +25,6 @@
>  
>  #include "fwts.h"
>  
> -static void acpi_table_check_ecdt(fwts_framework *fw, fwts_acpi_table_info *table)
> -{
> -	fwts_acpi_table_ecdt *ecdt = (fwts_acpi_table_ecdt*)table->data;
> -
> -	if ((ecdt->ec_control.address_space_id != 0) &&
> -            (ecdt->ec_control.address_space_id != 1)) {
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "ECDTECCtrlAddrSpaceID",
> -				"ECDT EC_CONTROL address space id = %" PRIu8
> -				", should be 0 or 1 (System I/O Space or System Memory Space)",
> -				ecdt->ec_control.address_space_id);
> -		fwts_advice(fw, "The ECDT EC_CONTROL address space id was invalid, however the kernel ACPI EC driver "
> -				"will just assume it an I/O port address.  This will not affect "
> -				"the system behaviour and can probably be ignored.");
> -	}
> -
> -	if ((ecdt->ec_data.address_space_id != 0) &&
> -            (ecdt->ec_data.address_space_id != 1)) {
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "ECDTECDataAddrSpaceID",
> -				"ECDT EC_CONTROL address space id = %" PRIu8
> -				", should be 0 or 1 (System I/O Space or System Memory Space)",
> -				ecdt->ec_data.address_space_id);
> -		fwts_advice(fw, "The ECDT EC_DATA address space id was invalid, however the kernel ACPI EC driver "
> -				"will just assume it an I/O port address.  This will not affect "
> -				"the system behaviour and can probably be ignored.");
> -	}
> -}
> -
>  static void acpi_table_check_hpet(fwts_framework *fw, fwts_acpi_table_info *table)
>  {
>  	fwts_acpi_table_hpet *hpet = (fwts_acpi_table_hpet*)table->data;
> @@ -720,7 +693,6 @@ typedef struct {
>  
>  static acpi_table_check_table check_table[] = {
>  	{ "APIC", acpi_table_check_madt },
> -	{ "ECDT", acpi_table_check_ecdt },
>  	{ "FACP", acpi_table_check_fadt },
>  	{ "GTDT", acpi_table_check_gtdt },
>  	{ "HPET", acpi_table_check_hpet },
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu June 24, 2015, 3:26 a.m. UTC | #2 
On 2015年06月18日 16:49, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The trivial ECDT test in acpitables is now redundant since we
> now have a more feature rich version.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/acpitables/acpitables.c | 28 ----------------------------
>   1 file changed, 28 deletions(-)
>
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 1d3eb0c..63c3605 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -25,33 +25,6 @@
>   
>   #include "fwts.h"
>   
> -static void acpi_table_check_ecdt(fwts_framework *fw, fwts_acpi_table_info *table)
> -{
> -	fwts_acpi_table_ecdt *ecdt = (fwts_acpi_table_ecdt*)table->data;
> -
> -	if ((ecdt->ec_control.address_space_id != 0) &&
> -            (ecdt->ec_control.address_space_id != 1)) {
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "ECDTECCtrlAddrSpaceID",
> -				"ECDT EC_CONTROL address space id = %" PRIu8
> -				", should be 0 or 1 (System I/O Space or System Memory Space)",
> -				ecdt->ec_control.address_space_id);
> -		fwts_advice(fw, "The ECDT EC_CONTROL address space id was invalid, however the kernel ACPI EC driver "
> -				"will just assume it an I/O port address.  This will not affect "
> -				"the system behaviour and can probably be ignored.");
> -	}
> -
> -	if ((ecdt->ec_data.address_space_id != 0) &&
> -            (ecdt->ec_data.address_space_id != 1)) {
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "ECDTECDataAddrSpaceID",
> -				"ECDT EC_CONTROL address space id = %" PRIu8
> -				", should be 0 or 1 (System I/O Space or System Memory Space)",
> -				ecdt->ec_data.address_space_id);
> -		fwts_advice(fw, "The ECDT EC_DATA address space id was invalid, however the kernel ACPI EC driver "
> -				"will just assume it an I/O port address.  This will not affect "
> -				"the system behaviour and can probably be ignored.");
> -	}
> -}
> -
>   static void acpi_table_check_hpet(fwts_framework *fw, fwts_acpi_table_info *table)
>   {
>   	fwts_acpi_table_hpet *hpet = (fwts_acpi_table_hpet*)table->data;
> @@ -720,7 +693,6 @@ typedef struct {
>   
>   static acpi_table_check_table check_table[] = {
>   	{ "APIC", acpi_table_check_madt },
> -	{ "ECDT", acpi_table_check_ecdt },
>   	{ "FACP", acpi_table_check_fadt },
>   	{ "GTDT", acpi_table_check_gtdt },
>   	{ "HPET", acpi_table_check_hpet },
Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
index 1d3eb0c..63c3605 100644
--- a/src/acpi/acpitables/acpitables.c
+++ b/src/acpi/acpitables/acpitables.c
@@ -25,33 +25,6 @@ 
 
 #include "fwts.h"
 
-static void acpi_table_check_ecdt(fwts_framework *fw, fwts_acpi_table_info *table)
-{
-	fwts_acpi_table_ecdt *ecdt = (fwts_acpi_table_ecdt*)table->data;
-
-	if ((ecdt->ec_control.address_space_id != 0) &&
-            (ecdt->ec_control.address_space_id != 1)) {
-		fwts_failed(fw, LOG_LEVEL_MEDIUM, "ECDTECCtrlAddrSpaceID",
-				"ECDT EC_CONTROL address space id = %" PRIu8
-				", should be 0 or 1 (System I/O Space or System Memory Space)",
-				ecdt->ec_control.address_space_id);
-		fwts_advice(fw, "The ECDT EC_CONTROL address space id was invalid, however the kernel ACPI EC driver "
-				"will just assume it an I/O port address.  This will not affect "
-				"the system behaviour and can probably be ignored.");
-	}
-
-	if ((ecdt->ec_data.address_space_id != 0) &&
-            (ecdt->ec_data.address_space_id != 1)) {
-		fwts_failed(fw, LOG_LEVEL_MEDIUM, "ECDTECDataAddrSpaceID",
-				"ECDT EC_CONTROL address space id = %" PRIu8
-				", should be 0 or 1 (System I/O Space or System Memory Space)",
-				ecdt->ec_data.address_space_id);
-		fwts_advice(fw, "The ECDT EC_DATA address space id was invalid, however the kernel ACPI EC driver "
-				"will just assume it an I/O port address.  This will not affect "
-				"the system behaviour and can probably be ignored.");
-	}
-}
-
 static void acpi_table_check_hpet(fwts_framework *fw, fwts_acpi_table_info *table)
 {
 	fwts_acpi_table_hpet *hpet = (fwts_acpi_table_hpet*)table->data;
@@ -720,7 +693,6 @@  typedef struct {
 
 static acpi_table_check_table check_table[] = {
 	{ "APIC", acpi_table_check_madt },
-	{ "ECDT", acpi_table_check_ecdt },
 	{ "FACP", acpi_table_check_fadt },
 	{ "GTDT", acpi_table_check_gtdt },
 	{ "HPET", acpi_table_check_hpet },