From patchwork Fri Mar 26 00:31:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Ilyevsky X-Patchwork-Id: 48608 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BCD85B7CEF for ; Fri, 26 Mar 2010 11:32:29 +1100 (EST) Received: from localhost ([127.0.0.1]:36921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuxTO-0006Vg-1F for incoming@patchwork.ozlabs.org; Thu, 25 Mar 2010 20:32:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuxSo-0006T9-23 for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:50 -0400 Received: from [140.186.70.92] (port=41662 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuxSm-0006S4-R2 for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuxSl-0008AQ-2m for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:48 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:48696) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuxSk-0008AF-Uc for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:47 -0400 Received: by wyb42 with SMTP id 42so3669967wyb.4 for ; Thu, 25 Mar 2010 17:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:received:message-id:subject:to:cc:content-type; bh=/ZUh2zp5SgfCeK+b+HeLR85gWMDmKnYyDsTprWfboDU=; b=u/ONzv1/RrSr8JVfL+EGABAbayh37fi93SASx2J03QkqPDhCPSCxxXdDfRDH0EKxE0 VvLZVYqx+PFP2IWde1uKqmTpjeLVFK7oEpJR9oLr2S94B1rGEoKp8/R872w6Dp9invHV bXCpIoPTjgijvMD69YRUsBHsy8hiGx6zRyx5Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=lNUNvgbYYvj2Sk5aXDcAqV/7EIPeCuyfmZpcwrROFFbe8Uccvra3YXJ+uHdERjQfwS FdqK1THiVSHluCCN3CSYauHzZQqSIiq/NN/Ih/62o3qHWkEq21hSxwoPUNvdMbQuq2zh 2pbXySrto3002SEapj4RFdAQi4ktw09NbINyE= MIME-Version: 1.0 Received: by 10.216.29.79 with HTTP; Thu, 25 Mar 2010 17:31:25 -0700 (PDT) In-Reply-To: <09F9B6EF-33C7-4755-82DB-CB0D60F49649@suse.de> References: <4aa8564b0912011033n68653e6dufc4bd87ccaf030a5@mail.gmail.com> <8F6B1156-5574-41A3-B2EE-978E77391EF7@suse.de> <4aa8564b1003241456y4851b964iafcc534324506666@mail.gmail.com> <09F9B6EF-33C7-4755-82DB-CB0D60F49649@suse.de> From: Dmitry Ilyevsky Date: Fri, 26 Mar 2010 03:31:25 +0300 Received: by 10.216.87.67 with SMTP id x45mr40619wee.18.1269563505109; Thu, 25 Mar 2010 17:31:45 -0700 (PDT) Message-ID: <4aa8564b1003251731o2e0dc66ci603cefa86d70d87@mail.gmail.com> Subject: Re: [Qemu-devel] TBL register permissions for PPC To: Alexander Graf X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: qemu-devel@nongnu.org X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Thu, Mar 25, 2010 at 10:53 AM, Alexander Graf wrote: > > On 24.03.2010, at 22:56, Dmitry Ilyevsky wrote: > >> >> Hello All, >> >> Please review patch for TBL SPR read access for generic PPC. >> >> Description: >> >> POWER specification docs define TBL/TBU SPRs as readable in user and privileged modes. Therefore SPRs permissions were changed in gen_tbl function in target-ppc/translate_init.c file. >> >> Testing: >> >> Tested with vxworks-6.2 bsp and OS on custom qemu board that includes ppc405 emulated core > > A couple of comments to this patch. > > 1) Please don't top-post. > 2) Always put a Signed-off-by: in the patch > 3) Put the patch description into the patch, so git knows what to do with it > 4) Don't use html features in mail :-) > > The patch looks good otherwise. > > > Alex > > Corrected. Thanks, Dmitry I. Acked-by: Alexander Graf From b5846b7df136c1eff7df8dada8800c81e1799cf4 Mon Sep 17 00:00:00 2001 From: Dmitry Ilyevsky Date: Fri, 26 Mar 2010 03:25:36 +0300 Subject: Generic PowerPC TBL Time base SPRs TBL/TBU should be accessible in user/priv modes for reading as specified in POWER ISA documentation. Therefore SPRs permissions were changed in gen_tbl function. Signed-off-by: Dmitry Ilyevsky --- target-ppc/translate_init.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index db4dc17..e8eadf4 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -777,16 +777,16 @@ static void gen_tbl (CPUPPCState *env) &spr_read_tbl, SPR_NOACCESS, 0x00000000); spr_register(env, SPR_TBL, "TBL", - SPR_NOACCESS, SPR_NOACCESS, - SPR_NOACCESS, &spr_write_tbl, + &spr_read_tbl, SPR_NOACCESS, + &spr_read_tbl, &spr_write_tbl, 0x00000000); spr_register(env, SPR_VTBU, "TBU", &spr_read_tbu, SPR_NOACCESS, &spr_read_tbu, SPR_NOACCESS, 0x00000000); spr_register(env, SPR_TBU, "TBU", - SPR_NOACCESS, SPR_NOACCESS, - SPR_NOACCESS, &spr_write_tbu, + &spr_read_tbu, SPR_NOACCESS, + &spr_read_tbu, &spr_write_tbu, 0x00000000); } -- 1.7.0