Patchwork Fix busted driftfix option

login
register
mail settings
Submitter Zachary Amsden
Date March 26, 2010, 8:21 p.m.
Message ID <4BAD1763.4040602@redhat.com>
Download mbox | patch
Permalink /patch/48590/
State New
Headers show

Comments

Zachary Amsden - March 26, 2010, 8:21 p.m.
For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
the code is dead.
CONFIG_TARGET_XXX is wrong

Signed-off-by: Zachary Amsden <zamsden@redhat.com>
Blue Swirl - March 27, 2010, 9:14 a.m.
On 3/26/10, Zachary Amsden <zamsden@redhat.com> wrote:
> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
>  the code is dead.

The code is also broken: it references undefined variable 'buf'
instead of 'value'.
Blue Swirl - March 29, 2010, 6:48 p.m.
On 3/30/10, Zachary Amsden <zamsden@redhat.com> wrote:
> On 03/26/10 23:14, Blue Swirl wrote:
>  > On 3/26/10, Zachary Amsden <zamsden@redhat.com> wrote:
>  >
>  >> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
>  >>  the code is dead.
>  >>
>  > The code is also broken: it references undefined variable 'buf'
>  > instead of 'value'.
>  >
>
>
> Sorry, that wasn't the case on the branch I ported from.  Can you apply
>  a trivial fix or should I send along a patch?

I've already committed the fix.
Zachary Amsden - March 30, 2010, 6:43 p.m.
On 03/26/10 23:14, Blue Swirl wrote:
> On 3/26/10, Zachary Amsden <zamsden@redhat.com> wrote:
>   
>> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
>>  the code is dead.
>>     
> The code is also broken: it references undefined variable 'buf'
> instead of 'value'.
>   

Sorry, that wasn't the case on the branch I ported from.  Can you apply
a trivial fix or should I send along a patch?

Thanks,

Zach

Patch

diff --git a/vl.c b/vl.c
index 6e35cc6..9720619 100644
--- a/vl.c
+++ b/vl.c
@@ -1565,7 +1565,7 @@  static void configure_rtc(QemuOpts *opts)
             exit(1);
         }
     }
-#ifdef CONFIG_TARGET_I386
+#ifdef TARGET_I386
     value = qemu_opt_get(opts, "driftfix");
     if (value) {
         if (!strcmp(buf, "slew")) {