Message ID | 1434554299-23443-4-git-send-email-shubhraj@xilinx.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-i2c-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9B85C140290 for <incoming@patchwork.ozlabs.org>; Thu, 18 Jun 2015 01:33:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755182AbbFQPdw (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Wed, 17 Jun 2015 11:33:52 -0400 Received: from mail-bn1bon0064.outbound.protection.outlook.com ([157.56.111.64]:38594 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753100AbbFQPdv (ORCPT <rfc822;linux-i2c@vger.kernel.org>); Wed, 17 Jun 2015 11:33:51 -0400 Received: from BN1BFFO11FD023.protection.gbl (10.58.144.31) by BN1BFFO11HUB001.protection.gbl (10.58.144.148) with Microsoft SMTP Server (TLS) id 15.1.190.9; Wed, 17 Jun 2015 15:18:29 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BN1BFFO11FD023.mail.protection.outlook.com (10.58.144.86) with Microsoft SMTP Server (TLS) id 15.1.190.9 via Frontend Transport; Wed, 17 Jun 2015 15:18:28 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:35134 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z5F6h-0000C6-MX for linux-i2c@vger.kernel.org; Wed, 17 Jun 2015 08:18:27 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z5F6h-0002ER-FP for linux-i2c@vger.kernel.org; Wed, 17 Jun 2015 08:18:27 -0700 Received: from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id t5HFI0lM005677; Wed, 17 Jun 2015 08:18:00 -0700 Received: from [172.23.146.171] (helo=xhdl3763.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <shubhraj@xilinx.com>) id 1Z5F6f-0002Dc-2U; Wed, 17 Jun 2015 08:18:25 -0700 Received: by xhdl3763.xilinx.com (Postfix, from userid 9049) id 44D722CE03E4; Wed, 17 Jun 2015 20:48:24 +0530 (IST) From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> To: <linux-i2c@vger.kernel.org> CC: Shubhrajyoti Datta <shubhraj@xilinx.com> Subject: [PATCHv2 3/9] i2c: xiic: Do not reset controller before every transfer Date: Wed, 17 Jun 2015 20:48:13 +0530 Message-ID: <1434554299-23443-4-git-send-email-shubhraj@xilinx.com> X-Mailer: git-send-email 1.7.4 In-Reply-To: <1434554299-23443-1-git-send-email-shubhraj@xilinx.com> References: <1434554299-23443-1-git-send-email-shubhraj@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21618.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD023; 1:fYxBCr9sf1lWvg/F+59mZTXcEV8xGvtUZcd7M3N+PVv3HfVypgtFLWAS9enMq1pug7M5R2Sz/HJ80DJIFTh5KSUtduTZlZoi2jCcP7piQKxTWw3nH+hNeVnFcFcbYNQue6vj69DgQepMq/VgUgC0bS06QgmUJ2iPNZhvlZhFKrQpAhilbX1qZfeXjfNn9iPXD/xihNOAsGg8BTLezcCR7k9/xBhBklr5RLO6va82myPfKNHts2vvhrjyOC/mZP7VsC+6xg2bjHQOS+4UpVO8xvghhMOcWYF/7VQLyKW14jE= X-Forefront-Antispam-Report: CIP:149.199.60.100; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(48376002)(450100001)(62966003)(77156002)(36386004)(2950100001)(36756003)(50466002)(33646002)(47776003)(50226001)(52956003)(92566002)(87936001)(6806004)(76176999)(50986999)(2351001)(229853001)(42186005)(46102003)(5001960100002)(189998001)(107886002)(110136002)(63266004)(86362001)(106466001)(46386002)(45336002)(103686003)(19580405001)(19580395003)(217423001)(107986001)(90966001)(4001430100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1BFFO11HUB001; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; MLV:ovrnspm; A:1; MX:1; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11HUB001; 2:eVlUsQRP5xPSkgUI7IDfIR/d2xZJQk6g5zkS4LZF+s85MVeli84MI3uFxki0/XAq; 2:YkJL2diz9XB1IXBgn1FIF2mUKUntsH7gLYTvr6KaS891/rpL94EBFJYBgC1/FqS1fIh8klQgzQtoJRb3O7grM13V6GnD5ePoySJvEoVWcxlik0VjDUVmFRomdHG/SfsJCJMDXXqI1qZEvws+YzuzW6rcKM1Yynk1t9JE46qhZcR7BKfRYsb1VflsHtvbtcji/E3T3+12sbuWGyiAp22ImVqOXtDe1ADVAgqF3/rJD+FS54zIlgV9FzYJ45cn1obE; 6:eFFKO8yU0VoBu8DOY9x7Tv9F56svziYIqTev1J9FL8H46cTbOVmtk9Eh+DiwU0bfN3SXBr0UnT3JBqZ0p3S2LvlaT28xDpraojLkyn4/veLskARSGszzemvay1KVGZvTJ/4tRzfpnWbFZwz4ii+fV9XM9mm7msacgYrm6r7Qu5VCquLCCWOKI/wm/E/auW0k85p9jfZfj1qrygBCzNy9+ZbM0L0wuRpg5RhLiAz7eDXqDAli1nZrAVKLyCp8aMjmLyxRfLnpt/z3Ue6EmqK0dov23aT06vi+CN7HVO/4pYYyN9dwqQQHP6bTQmkVYUjfR0dcPUfBXefXrSbauEb/QXrEJWeTZUzJrGJZ4W1hxVZmOObenl2Cd3VrDTJ6YllpbcaS3auU2HseBcF6WSNdc8Ka4T1fZqkruDxpE5I28xuNIMovBZteiY3pIPrT8nDTtElmyyQazmlMthTYcqtdaZZg1AF64sPNECCf1BF6PCVos+zjw/zJRThznuyosQqD X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB001; X-Microsoft-Antispam-PRVS: <BN1BFFO11HUB001CAD72B733468BD51C829EBA60@BN1BFFO11HUB001.protection.gbl> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:BN1BFFO11HUB001; BCL:0; PCL:0; RULEID:; SRVR:BN1BFFO11HUB001; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11HUB001; 3:mIkIn8rgkzQRWqCjenq9VaaZsMP+lcjAiRsjcMPrFud7/XZw1lRqzJER5SbZ/XZBogl5YsItVGwXJFd4M6w6JjMaUvhyHdTh8LpyT6oSZPTWNAEbG3m/jGAgRGQINeFEkrL5DUKpNB9ZSzRmZabkjIRx1gko6X7LTqLKyznarIGmF86kZNQjS00StHLYM++I6srxertfGMx9clVYBM6eTptr4T+RECpCnoRJmfHPEV/X5Bm3uiPheGMbiFzt0WZmiJYXJzcm1xM+7J+lsjogHTguBBY+b4oeAjP6rJfL087rAXAkHEpsCSRnzYVTCBnt X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1BFFO11HUB001; 9:Z2HyzGMxqKpGe9BrO0OG11nFTn53Rzlo6b7xo7Qv?= =?us-ascii?Q?deqDojV2051naTjkbYo446IWEKbtegt1VburddeQGZiZL3ILyn+nzdK9TIG9?= =?us-ascii?Q?8u7yACcw90jXOO5kWwL5sC4XWBnjJt650BjW3GSBmnvLroQNaypoT8gr8MsT?= =?us-ascii?Q?jSJBFD3WQ+B+H8JSlxnKIZ8+NiKa/BEjOySpqV2RzzSX4OcRfWundRiWdjD4?= =?us-ascii?Q?cD2ESC8vF7q5RxEGaHz47XIhcrXACtFVtnEJLmHdIWSutHp5859Uy+90EJOt?= =?us-ascii?Q?P+G8l058mB+uhrjXQgk7lUbNrJTKizUODl2uYO3nS6rsYQ4GAusO8q+vf/Uk?= =?us-ascii?Q?Y5TyPp+U4XqA7rI9CyUrsG3smXGBe0x2iJD4V9pM4byxW4Rdk52XDskd4XN9?= =?us-ascii?Q?XWqNS48pjQ3sCQgErGlmyxoqeZprqH+ytqDqVOWfGvW8JvqoLJvQLmCTQ5ix?= =?us-ascii?Q?fFZu2E3G4nDo19TMtqAKZZTEFPLDA+kuARFhdz5cC0d62MVjPx4LVTyQ/z69?= =?us-ascii?Q?2SIS7HkZZcBWlz+vxmd7aeAwi/83wZSirPOvptkRBdeZJFjwtUDxhh9G3N+N?= =?us-ascii?Q?ShBs2t8t5lXt3Dxbf3/s4/RLy5ftkEyiBeVdzSugArEove5MPnkiBdDYlyfk?= =?us-ascii?Q?Uyo4X0rwfygMeTuvsV58SqKQpdyF8u5NyfTdV+Vj/lDOR+Pu3o/Mal5C+Sju?= =?us-ascii?Q?Z6WevZBx47ZzufpZjuPb/vqiNI6J+jGQYRvZ0euYVYNgoZOBxigB09hwPirH?= =?us-ascii?Q?YhUgdA0Jnw5Gtk4RJKYNls/IBun+m54ENUptbPW94HpYQCEwUShFCRSw8rd9?= =?us-ascii?Q?42ZCbuMpNIjaaB3YraiD2lNFIHtO1zEleWN473FQVFnyOBxICsxOc5kCrexk?= =?us-ascii?Q?Sdh7wub70+Djywo65igF/hW+N/Yro13YuBGH71QoiVfZucA9w8eg48dfNgT7?= =?us-ascii?Q?l8PYNoBXZ4iodke0vEvAirXsSCnnEIXBPk0ZtTrPJKrSM31DHSBs+lJY/4Ot?= =?us-ascii?Q?hE+ki9gA4NkKeC891+V3BkkWFeivN+/u7FgMlVhaqfLCYKqRGJl1D9epFtKj?= =?us-ascii?Q?Omgs3riKwy97faydLNbImYOIe1rv?= X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11HUB001; 3:tgPPiIgRu3Th7PU88V3QWIBAKZBMBJcCaYboBf1S3rgYOV/E58xxWC9UtRpiQwEN4dZKL1OIf276Hzdq2b3nC3R8U52Z/htEefMgTO7OJ/Sc/7RBozibAlCgFtda1qsW/pHvLNMBF9hA4vv7FkR0LQ==; 10:R65Z7IU8CRHOElbg50e6DUvTlz7gHF2ICzk/OepeUveTIMQczqBC09Hmu9UpfBR5JXnL3cY5vX11s/vNe7UeWozaVJ8xa2XubyoIiGXI7yA= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 15:18:28.5849 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB001 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: <linux-i2c.vger.kernel.org> X-Mailing-List: linux-i2c@vger.kernel.org |
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 1a6e637..92ea52a 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -667,7 +667,6 @@ static void xiic_start_xfer(struct xiic_i2c *i2c) unsigned long flags; spin_lock_irqsave(&i2c->lock, flags); - xiic_reinit(i2c); /* disable interrupts globally */ xiic_setreg32(i2c, XIIC_DGIER_OFFSET, 0); spin_unlock_irqrestore(&i2c->lock, flags);
Currently before every transfer the controller is reinitialised. We are already resetting the controller upon errors so upon every transfer is a performance kill. Remove the same. Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)