Patchwork [1/1] pata_via: HDD of VT6410/6415/6330 cannot be detected issue

login
register
mail settings
Submitter JosephChan@via.com.tw
Date March 25, 2010, 8:57 a.m.
Message ID <9E058EE846170743AF7338FE064CB5AB38B400@exchtp04.taipei.via.com.tw>
Download mbox | patch
Permalink /patch/48504/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

JosephChan@via.com.tw - March 25, 2010, 8:57 a.m.
When using VT6410/6415/6330 chips on some VIA's platforms, the HDD connects to VT6410/6415/6330 cannot be detected.
It is because the driver detects wrong via_isa_bridge ID, and then cause the this issue happen.
This patch will fix this problem.


Signed-off-by: Joseph Chan<josephchan@via.com.tw>
Sergei Shtylyov - March 25, 2010, 12:02 p.m.
Hello.

JosephChan@via.com.tw wrote:

> When using VT6410/6415/6330 chips on some VIA's platforms, the HDD connects to VT6410/6415/6330 cannot be detected.
> It is because the driver detects wrong via_isa_bridge ID, and then cause the this issue happen.
> This patch will fix this problem.
>
>
> Signed-off-by: Joseph Chan<josephchan@via.com.tw>
>
> --- a/drivers/ata/pata_via.c	2010-03-16 06:00:01.000000000 -0400
> +++ b/drivers/ata/pata_via.c	2010-03-19 10:21:59.000000000 -0400
> @@ -576,6 +576,10 @@
> 			u8 rev = isa->revision;
> 			pci_dev_put(isa);
>  
> +			if ( (id->device == 0x0415 || id->device == 0x3164) &&
> +			      (config->id != id->device ))
>   

   Don't put spaces before parens.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
JosephChan@via.com.tw - March 25, 2010, 12:41 p.m.
ID4+ICAgRG9uJ3QgcHV0IHNwYWNlcyBiZWZvcmUgcGFyZW5zLg0KDQpTZXJnZWksDQoNClRoYW5r
cyBmb3IgcmVtaW5kaW5nLCBJIGZvcmdvdCB0byBjaGVjayBpdC4NCkkgd2lsbCByZS1zdWJtaXQg
dGhlIHBhdGNoIGxhdGVyLg0KDQpCUnMsDQpKb3NlcGggQ2hhbg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/ata/pata_via.c	2010-03-16 06:00:01.000000000 -0400

+++ b/drivers/ata/pata_via.c	2010-03-19 10:21:59.000000000 -0400

@@ -576,6 +576,10 @@ 

			u8 rev = isa->revision;
			pci_dev_put(isa);
 
+			if ( (id->device == 0x0415 || id->device == 0x3164) &&

+			      (config->id != id->device ))

+				continue;

+

 			if (rev >= config->rev_min && rev <= config->rev_max)
 				break;
 		}