diff mbox

[U-Boot] mx53loco: Use generic 'load' command instead of 'fatload'

Message ID 1434448128-16004-1-git-send-email-guillaume.gardet@free.fr
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Guillaume GARDET June 16, 2015, 9:48 a.m. UTC
This patch uses generic 'load' command instead of 'fatload' for 'loadbootscript', 'loadimage' and 'loadfdt' for mx53loco board.

This allows to use EXT partition instead of FAT, while keeping FAT compatibility.

Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>

Cc: Jason Liu <r64343@freescale.com>
Cc: Stefano Babic <sbabic@denx.de>

---
 include/configs/mx53loco.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Hui Liu June 16, 2015, 11:51 a.m. UTC | #1
> -----Original Message-----
> From: Guillaume GARDET [mailto:guillaume.gardet@free.fr]
> Sent: Tuesday, June 16, 2015 5:49 PM
> To: u-boot@lists.denx.de
> Cc: Guillaume GARDET; Liu Hui-R64343; Stefano Babic
> Subject: [U-Boot] [PATCH] mx53loco: Use generic 'load' command instead of
> 'fatload'
> 
> This patch uses generic 'load' command instead of 'fatload' for
> 'loadbootscript', 'loadimage' and 'loadfdt' for mx53loco board.
> 
> This allows to use EXT partition instead of FAT, while keeping FAT
> compatibility.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> 
> Cc: Jason Liu <r64343@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>

Acked-by: Jason Liu <r64343@freescale.com>

> 
> ---
>  include/configs/mx53loco.h | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
> index db551a9..b3ac5e2 100644
> --- a/include/configs/mx53loco.h
> +++ b/include/configs/mx53loco.h
> @@ -43,6 +43,7 @@
>  #define CONFIG_MMC
>  #define CONFIG_CMD_MMC
>  #define CONFIG_GENERIC_MMC
> +#define CONFIG_CMD_FS_GENERIC
>  #define CONFIG_CMD_FAT
>  #define CONFIG_CMD_EXT2
>  #define CONFIG_DOS_PARTITION
> @@ -116,11 +117,11 @@
>  	"mmcroot=/dev/mmcblk0p2 rw rootwait\0" \
>  	"mmcargs=setenv bootargs console=ttymxc0,${baudrate}
> root=${mmcroot}\0" \
>  	"loadbootscript=" \
> -		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> +		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>  	"bootscript=echo Running bootscript from mmc ...; " \
>  		"source\0" \
> -	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0"
> \
> -	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}
> ${fdt_file}\0" \
> +	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
> +	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>  	"mmcboot=echo Booting from mmc ...; " \
>  		"run mmcargs; " \
>  		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then "
> \
> --
> 1.8.4.5
Guillaume GARDET July 6, 2015, 10:10 a.m. UTC | #2
Le 16/06/2015 13:51, Liu Jason a écrit :
>> -----Original Message-----
>> From: Guillaume GARDET [mailto:guillaume.gardet@free.fr]
>> Sent: Tuesday, June 16, 2015 5:49 PM
>> To: u-boot@lists.denx.de
>> Cc: Guillaume GARDET; Liu Hui-R64343; Stefano Babic
>> Subject: [U-Boot] [PATCH] mx53loco: Use generic 'load' command instead of
>> 'fatload'
>>
>> This patch uses generic 'load' command instead of 'fatload' for
>> 'loadbootscript', 'loadimage' and 'loadfdt' for mx53loco board.
>>
>> This allows to use EXT partition instead of FAT, while keeping FAT
>> compatibility.
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>
>> Cc: Jason Liu <r64343@freescale.com>
>> Cc: Stefano Babic <sbabic@denx.de>
> Acked-by: Jason Liu <r64343@freescale.com>

Stefano, could you merge it, please? It would be nice to get it in 2015.07 release.


Guillaume

>
>> ---
>>   include/configs/mx53loco.h | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
>> index db551a9..b3ac5e2 100644
>> --- a/include/configs/mx53loco.h
>> +++ b/include/configs/mx53loco.h
>> @@ -43,6 +43,7 @@
>>   #define CONFIG_MMC
>>   #define CONFIG_CMD_MMC
>>   #define CONFIG_GENERIC_MMC
>> +#define CONFIG_CMD_FS_GENERIC
>>   #define CONFIG_CMD_FAT
>>   #define CONFIG_CMD_EXT2
>>   #define CONFIG_DOS_PARTITION
>> @@ -116,11 +117,11 @@
>>   	"mmcroot=/dev/mmcblk0p2 rw rootwait\0" \
>>   	"mmcargs=setenv bootargs console=ttymxc0,${baudrate}
>> root=${mmcroot}\0" \
>>   	"loadbootscript=" \
>> -		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>> +		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>>   	"bootscript=echo Running bootscript from mmc ...; " \
>>   		"source\0" \
>> -	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0"
>> \
>> -	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}
>> ${fdt_file}\0" \
>> +	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
>> +	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>>   	"mmcboot=echo Booting from mmc ...; " \
>>   		"run mmcargs; " \
>>   		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then "
>> \
>> --
>> 1.8.4.5
>
Stefano Babic July 6, 2015, 10:26 a.m. UTC | #3
Hi Guillaume,

On 06/07/2015 12:10, Guillaume Gardet wrote:
> 
> 
> Le 16/06/2015 13:51, Liu Jason a écrit :
>>> -----Original Message-----
>>> From: Guillaume GARDET [mailto:guillaume.gardet@free.fr]
>>> Sent: Tuesday, June 16, 2015 5:49 PM
>>> To: u-boot@lists.denx.de
>>> Cc: Guillaume GARDET; Liu Hui-R64343; Stefano Babic
>>> Subject: [U-Boot] [PATCH] mx53loco: Use generic 'load' command
>>> instead of
>>> 'fatload'
>>>
>>> This patch uses generic 'load' command instead of 'fatload' for
>>> 'loadbootscript', 'loadimage' and 'loadfdt' for mx53loco board.
>>>
>>> This allows to use EXT partition instead of FAT, while keeping FAT
>>> compatibility.
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>>
>>> Cc: Jason Liu <r64343@freescale.com>
>>> Cc: Stefano Babic <sbabic@denx.de>
>> Acked-by: Jason Liu <r64343@freescale.com>
> 
> Stefano, could you merge it, please? It would be nice to get it in
> 2015.07 release.
> 
> 

Yes, I do it.

Best regards,
Stefano Babic
Guillaume GARDET July 6, 2015, 11:31 a.m. UTC | #4
Le 06/07/2015 12:26, Stefano Babic a écrit :
> Hi Guillaume,
>
> On 06/07/2015 12:10, Guillaume Gardet wrote:
>>
>> Le 16/06/2015 13:51, Liu Jason a écrit :
>>>> -----Original Message-----
>>>> From: Guillaume GARDET [mailto:guillaume.gardet@free.fr]
>>>> Sent: Tuesday, June 16, 2015 5:49 PM
>>>> To: u-boot@lists.denx.de
>>>> Cc: Guillaume GARDET; Liu Hui-R64343; Stefano Babic
>>>> Subject: [U-Boot] [PATCH] mx53loco: Use generic 'load' command
>>>> instead of
>>>> 'fatload'
>>>>
>>>> This patch uses generic 'load' command instead of 'fatload' for
>>>> 'loadbootscript', 'loadimage' and 'loadfdt' for mx53loco board.
>>>>
>>>> This allows to use EXT partition instead of FAT, while keeping FAT
>>>> compatibility.
>>>>
>>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>>>
>>>> Cc: Jason Liu <r64343@freescale.com>
>>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Acked-by: Jason Liu <r64343@freescale.com>
>> Stefano, could you merge it, please? It would be nice to get it in
>> 2015.07 release.
>>
>>
> Yes, I do it.

Thanks!


Guillaume


>
> Best regards,
> Stefano Babic
>
>
diff mbox

Patch

diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index db551a9..b3ac5e2 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -43,6 +43,7 @@ 
 #define CONFIG_MMC
 #define CONFIG_CMD_MMC
 #define CONFIG_GENERIC_MMC
+#define CONFIG_CMD_FS_GENERIC
 #define CONFIG_CMD_FAT
 #define CONFIG_CMD_EXT2
 #define CONFIG_DOS_PARTITION
@@ -116,11 +117,11 @@ 
 	"mmcroot=/dev/mmcblk0p2 rw rootwait\0" \
 	"mmcargs=setenv bootargs console=ttymxc0,${baudrate} root=${mmcroot}\0" \
 	"loadbootscript=" \
-		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run mmcargs; " \
 		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \