diff mbox

[AArch64,Testsuite,obvious] Reinstate torture-init and torture-finalize in advsimd-intrinsics.exp

Message ID 1434446646-32215-1-git-send-email-james.greenhalgh@arm.com
State New
Headers show

Commit Message

James Greenhalgh June 16, 2015, 9:24 a.m. UTC 
Hi,

advsimd-intrinsics.exp is polluting set-torture-options without
cleaning up after itself. This manifests as a failure in
aarch64-none-linux-gnu testing:

  FAIL: gcc.dg/torture/builtin-cproj-1.c   -Og -g  (test for excess errors)

This test does not expect to be called with -Og and will fail if you
do so.

There is a different question about whether we want to enable -Og
testing in dg-torture.exp , in which case this test will need patched
up. But regardless of that decision, advsimd-intrinsics.exp should
not clobber the set-torture-options without good reason.

Fixed by wrapping the main loop of advsimd-intrinsics.exp in torture-init
and torture-finish.

Tested with an aarch64-none-linux-gnu cross build to ensure it
clears the issue I was seeing.

Applied as revision 224507.

Thanks,
James

---
2015-06-16  James Greenhalgh  <james.greenhalgh@arm.com>

	* gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp:
	Reinstate calls to torture-init and torture-finalize.
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
index f57da39..ceada83 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
@@ -49,6 +49,7 @@  if {[istarget arm*-*-*]} then {
     set dg-do-what-default run
 }
 
+torture-init
 set-torture-options $C_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS
 
 # Make sure Neon flags are provided, if necessary.
@@ -60,4 +61,5 @@  gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] \
 
 # All done.
 set dg-do-what-default ${save-dg-do-what-default}
+torture-finish
 dg-finish