Message ID | 1434381480-3042-7-git-send-email-shubhraj@xilinx.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <linux-i2c-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3F48A1402A2 for <incoming@patchwork.ozlabs.org>; Tue, 16 Jun 2015 01:18:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932144AbbFOPSY (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Mon, 15 Jun 2015 11:18:24 -0400 Received: from mail-bn1bon0058.outbound.protection.outlook.com ([157.56.111.58]:41131 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932153AbbFOPSW (ORCPT <rfc822;linux-i2c@vger.kernel.org>); Mon, 15 Jun 2015 11:18:22 -0400 X-Greylist: delayed 1439 seconds by postgrey-1.27 at vger.kernel.org; Mon, 15 Jun 2015 11:18:22 EDT Received: from BN1BFFO11FD047.protection.gbl (10.58.144.33) by BN1BFFO11HUB031.protection.gbl (10.58.144.178) with Microsoft SMTP Server (TLS) id 15.1.190.9; Mon, 15 Jun 2015 15:18:21 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BN1BFFO11FD047.mail.protection.outlook.com (10.58.145.2) with Microsoft SMTP Server (TLS) id 15.1.190.9 via Frontend Transport; Mon, 15 Jun 2015 15:18:19 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:39981 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z4W9T-0003H7-0P for linux-i2c@vger.kernel.org; Mon, 15 Jun 2015 08:18:19 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z4W9S-00067O-Qn for linux-i2c@vger.kernel.org; Mon, 15 Jun 2015 08:18:18 -0700 Received: from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id t5FFHkgU026632; Mon, 15 Jun 2015 08:17:46 -0700 Received: from [172.23.146.171] (helo=xhdl3763.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <shubhraj@xilinx.com>) id 1Z4W9H-00062f-05; Mon, 15 Jun 2015 08:18:07 -0700 Received: by xhdl3763.xilinx.com (Postfix, from userid 9049) id 38F4D2CE03D7; Mon, 15 Jun 2015 20:48:06 +0530 (IST) From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> To: <linux-i2c@vger.kernel.org> CC: Shubhrajyoti Datta <shubhraj@xilinx.com> Subject: [PATCH 7/9] i2c: xiic: Add a msg in case of timeout Date: Mon, 15 Jun 2015 20:47:58 +0530 Message-ID: <1434381480-3042-7-git-send-email-shubhraj@xilinx.com> X-Mailer: git-send-email 1.7.4 In-Reply-To: <1434381480-3042-1-git-send-email-shubhraj@xilinx.com> References: <1434381480-3042-1-git-send-email-shubhraj@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21614.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD047; 1:lYblEwyETCKtT9XwFgudoBwH8mbtjjufQsqSWWfyVHBpSEGuz5gck3k2C2yoQ7ZDKfTLvDwzDQSB3DQ/38VAOCZnesWTZ/Fto+lshV8DQ6Kp1AJEwumlFzeMlTucVMhjwQ+7MjFG3wn7szZBq77wJGkPiPupeVMbxTfv/r63GRpY5UsZmmgi2RPGPSAW8mXh7L11VjMnWbH6UqqAY3tfeQDwS3pq73jw8zskOyGOJ4HjAmgSrOtm4y6NRsMvnuo/JaQ5UHgJKQqLNtDSkyDuoZO3lmRO4wcMszZzGxP4gwc= X-Forefront-Antispam-Report: CIP:149.199.60.100; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(438002)(189002)(199003)(50986999)(229853001)(107886002)(86362001)(46102003)(50226001)(76176999)(2351001)(87936001)(106466001)(110136002)(5001960100002)(19580395003)(47776003)(52956003)(450100001)(62966003)(77156002)(189998001)(36756003)(48376002)(50466002)(92566002)(45336002)(46386002)(33646002)(19580405001)(2950100001)(103686003)(63266004)(42186005)(6806004)(107986001)(4001430100001)(90966001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1BFFO11HUB031; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11HUB031; 2:WSpwlB2RHKI1pdUgrGZGagaiYXeZXolamBzS3XZmkbKzpuE5Yuy1VzGneQCiIJd6; 2:F/6r/DNWW3DABk1dJCcSU22bZB9tWJqr5Cc2J9TBsEAePcLWgpK4goVGlFa/2PuwVOxJh8qw7gckwGCyu+e2nMwRwCo21jMA2mBLjA6+unvhzP/kB2J29PyiDjvKpHFGPpltrvDB0mszLdjcAPnzj34mq+j2JT9vnPN7KTcFysqjvAqoesORz/PSKuah49oULyR1qQ3bkLx3VaX6cbB4xrWVkgmA97qZKobGTQP2dE4LojLDVOQnDlfyXfuf+e05; 6:leTD//bShfXbd0GlFMCKRd8wvVhxJAU8f5gZ7DRny1IXeYzaXRXLeVc9+Go3k2r705hU3XT7o2tl/4ejUkC2RvQzuRxEUsLLF3uBriKLfd1mHQfekwtfhj9ojmLrAqjMpVexCuuWQH6xYm0pqJ2B4rBGKO8XEV7kt9UCw3E9F9bRilBGfwpMEX9gqoBPSZfSCAWIL3eVny0ie6enTYRSEUjGcczZzkX9kFo/uorE+IvTqmXBUHQ8nLbFa4PPeRsODoq/OITLXC6xLa68t725bHUuVinlYJC5rySpCZFceEY8A2nC35a0gY2nqLzpdu1v5Q7INZTNFYTW0Nn2UDYpzWCHyqSi/W8rCzGEy5Dpp+PChCLzCSrKzIszHxL+YtIRbCY6aBgpXwGoyv8kBqn7f1H+9zMPJmYkcv3GAKL5OpeD6vd3J2sfZkL1TKLgeO2ZW8zjc++9/v1CwksvUdPuEIElsI4qs2e1eFewESCtDGs/H2ASuXV8tbKBEGeZcKGs X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB031; X-Microsoft-Antispam-PRVS: <BN1BFFO11HUB03185FF85039D273A211FAEEBB80@BN1BFFO11HUB031.protection.gbl> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:BN1BFFO11HUB031; BCL:0; PCL:0; RULEID:; SRVR:BN1BFFO11HUB031; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11HUB031; 3:2ADCa+sMjAmZTeFjKKlbmdBkIbRD3fSs4Rg287ebzZsUUyd/4/dJtIZhEPIiVmAsSnUdM9iABTheGdYuSsocyMcyI7yFWS9B2HKRrRCUqkcGzc2F5X60nkuVZBdbzszlyvd2a5C66SmF7CS8BnhMIVj2N9JvPgeSjUu6v/XTuBfIV4YFP0ZGVK+j8+2m7RsJ/cEATLxL7DCz62/0wSDsx6u0bsxDpdWnhSpbv9MzG7ViON7D9upb3PneIxX+10zXax6DW4JAWIjG2iOW7gd5kVxuoocBzAq9g+ZExoN+UutXeJCakewa0LFZBFf79jkO X-Forefront-PRVS: 0608DEDB67 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1BFFO11HUB031; 9:mH9iExy3PRBT6EG1EisI1ss1jdAWeOeo3wc+TY74?= =?us-ascii?Q?+LJCMSdck5vbavuR/cU33XC6MKbVQ4V532trpdT1WnP6vdw5horJAKuAGfJ5?= =?us-ascii?Q?NMchzIjo8M8R9AKGhpvl3x55eNQWmB9wPmOCBixL1pe8aN0jFyJRw1Allw0F?= =?us-ascii?Q?nmlqi9pnkRJBjocNy3k1nE/cQ1P9kVzLSWRAHjEDuMGwslwzy6Y2wV9PxMU7?= =?us-ascii?Q?fJSsnjqQMNu3t28W+kaKMKUBXdLMwyCn39+NiR1hxJ69Zw2sp4QskAuOHUKB?= =?us-ascii?Q?GD06Zym5ZQPudjGklR5MIunbzUL15zwd6n6GHOnJw5R9l0iYh9hHObQlwDEI?= =?us-ascii?Q?hOa/Gu780XcucIpsZklhgxuA7c0MFkFjhiXEefJC0VpPVwpNtrL51TTgd8Xu?= =?us-ascii?Q?7V8ejrzWZBUfiqj3GoLRZKFmMqjuuDYoZ5Uvxk5kW/bwhLkTUy3weSTpmenG?= =?us-ascii?Q?3el8//9g9E3ldFPaeR4/TRHO329YIsuHOmRQ88D+iLgR7S3X6yyUXnhh13i/?= =?us-ascii?Q?OzcIaTmYfABViRMDXPYw82KjuBSj30VgmTsMX5+H5Q1QRuqY713buxOFZcPC?= =?us-ascii?Q?Pob6RbHg4E2Gxl+p6vy6oVdTd3Yjh8yUdQLPt5pTUmMRcc3t1u5UXTS/H/3F?= =?us-ascii?Q?/A/RRrMrJTCGGNMUh0OtuSu+QmfqRbtjYBXbx9SjTaAiUCqdFzCwnexw0K6m?= =?us-ascii?Q?EFoix1QTIre1gchu/fFHwJoVgVJHHj93oOjYPqWsE8yht6vPCBODHAf3eBMF?= =?us-ascii?Q?mbpgOVUi3ejwZv4szm2t6gfHUK2o4DZGlhesNovDLVE3evggcU60XfI8qJtO?= =?us-ascii?Q?EoN8BCps2/1CfEwy1MCSAp/lRgzpA7PQi6k/Q0hJNmg3i1OLjSw4OLRU78fB?= =?us-ascii?Q?42j5d4wewSZMV471/W7fsL7mN4veVZwpzh0nsYVM+4hwQFaje/9ohMnFHf+O?= =?us-ascii?Q?gvBlpMyEqcqCBQW0brMk4BjslFTLA4lqj0I+VvkhexKdNvgdzxKFaHaV5x5q?= =?us-ascii?Q?7+Ag5Ud1MgZc5DRFF1kHPOos?= X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11HUB031; 3:B9f/v4qh1KadbtXW1efUuDJ+/+qs0cH6v+30svoHYATXuK26NQ3aLZ7b46PO417s+td5KUH+Y5G3PfoS3v6n8BFWakiMiOjFPqOUWJCqu6WMqncvW3FnGtXKI/hfTcKbEbMyiCCnJ4G1ANDiTZnIGA==; 10:9eXW5qIYUvlNVQJfCnsA8ZLiOfQhUlRWZNUJDOMmO+uqvV/EPfaW61a/X5o/ofYyXawPtK4wg0G1Bfkuwo0tH/s3Xl5u2FfwDdGSKDTdymU= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2015 15:18:19.9080 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB031 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: <linux-i2c.vger.kernel.org> X-Mailing-List: linux-i2c@vger.kernel.org |
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 8142c2e..62f7138 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -694,6 +694,7 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) i2c->tx_msg = NULL; i2c->rx_msg = NULL; i2c->nmsgs = 0; + dev_err(adap->dev.parent, "Controller timed out\n"); return -ETIMEDOUT; } }
Timing out is one of the serious errors. Currently we return silently upon a timeout. Adding an error message. Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)