| Message ID | 4BA8CEF6.2010707@LiPPERTEmbedded.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jens Rottmann <JRottmann@LiPPERTEmbedded.de> Date: Tue, 23 Mar 2010 15:23:50 +0100 > ksz884x: fix return value of netdev_set_eeprom > > netdev_set_eeprom() confused ethtool by just returning 1 on error > instead of a proper -EINVAL. > > Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-2.6.34-rc2-git1/drivers/net/ksz884x.c +++ return_value_fixed/drivers/net/ksz884x.c @@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_ int len; if (eeprom->magic != EEPROM_MAGIC) - return 1; + return -EINVAL; len = (eeprom->offset + eeprom->len + 1) / 2; for (i = eeprom->offset / 2; i < len; i++)
ksz884x: fix return value of netdev_set_eeprom netdev_set_eeprom() confused ethtool by just returning 1 on error instead of a proper -EINVAL. Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de> ---