| Message ID | 1434098601-3498-2-git-send-email-yizhang@marvell.com |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
| robh/patch-applied | success |
On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang <yizhang@marvell.com> wrote: > 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the > register mapping are the same How do they compare to 80x/822/860 PMICs? > > Signed-off-by: Yi Zhang <yizhang@marvell.com> > --- > Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt > > diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt > new file mode 100644 > index 0000000..72e741c > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt > @@ -0,0 +1,33 @@ > +Marvell 88pm88x combo PMIC chip > + > +This series of chip integrates regulator, rtc, onkey, switch charger, > +fuelgauge, gpadc and a range of I/O pins. > + > +88pm886 and 88pm880 are two very similar chips, most of the registers mapping > +and functions are the same, the main difference is the latter has a separate > +i2c slave address to cover BUCK related setting > + > +Required properties: > +- compatible: one of the strings for a specific chip: > + "marvell,88pm886" > + "marvell,88pm880" > +- reg: the i2c address > +- interrupt-controller: it works as an interrupt controller managing its irqs > +- interrupt-cells: this value is 1 > + > +Optional properties: > +- marvell,88pm88x-irq-write-clear: the interrupt ack method The 80x/860 binding needs the same property. Please coordinate this with Vaibhav. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 23 June 2015 08:01 PM, Rob Herring wrote: > On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang <yizhang@marvell.com> wrote: >> 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the >> register mapping are the same > > How do they compare to 80x/822/860 PMICs? > Zhang, Sorry, I missed this patch-series. Is there any way we can get access to datahsheets of all these devices? >> >> Signed-off-by: Yi Zhang <yizhang@marvell.com> >> --- >> Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt >> new file mode 100644 >> index 0000000..72e741c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt >> @@ -0,0 +1,33 @@ >> +Marvell 88pm88x combo PMIC chip >> + >> +This series of chip integrates regulator, rtc, onkey, switch charger, >> +fuelgauge, gpadc and a range of I/O pins. >> + >> +88pm886 and 88pm880 are two very similar chips, most of the registers mapping >> +and functions are the same, the main difference is the latter has a separate >> +i2c slave address to cover BUCK related setting >> + >> +Required properties: >> +- compatible: one of the strings for a specific chip: >> + "marvell,88pm886" >> + "marvell,88pm880" >> +- reg: the i2c address >> +- interrupt-controller: it works as an interrupt controller managing its irqs >> +- interrupt-cells: this value is 1 >> + >> +Optional properties: >> +- marvell,88pm88x-irq-write-clear: the interrupt ack method > > The 80x/860 binding needs the same property. Please coordinate this > with Vaibhav. > Please refer to the patch https://lkml.org/lkml/2015/6/17/545 Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 23, 2015 at 09:31:00AM -0500, Rob Herring wrote: > On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang <yizhang@marvell.com> wrote: > > 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the > > register mapping are the same > > How do they compare to 80x/822/860 PMICs? Hi, Rob: 88pm80x/822/860 and 88pm886/88pm880 are two different series: - the register mapping is totally different, it's hard to reuse the existed code for 88pm80x - the latter is a chip which integrates the charger/fuelgauge/camera flash which doesn't exist in 88pm80x > > > > > Signed-off-by: Yi Zhang <yizhang@marvell.com> > > --- > > Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt > > new file mode 100644 > > index 0000000..72e741c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt > > @@ -0,0 +1,33 @@ > > +Marvell 88pm88x combo PMIC chip > > + > > +This series of chip integrates regulator, rtc, onkey, switch charger, > > +fuelgauge, gpadc and a range of I/O pins. > > + > > +88pm886 and 88pm880 are two very similar chips, most of the registers mapping > > +and functions are the same, the main difference is the latter has a separate > > +i2c slave address to cover BUCK related setting > > + > > +Required properties: > > +- compatible: one of the strings for a specific chip: > > + "marvell,88pm886" > > + "marvell,88pm880" > > +- reg: the i2c address > > +- interrupt-controller: it works as an interrupt controller managing its irqs > > +- interrupt-cells: this value is 1 > > + > > +Optional properties: > > +- marvell,88pm88x-irq-write-clear: the interrupt ack method > > The 80x/860 binding needs the same property. Please coordinate this > with Vaibhav. Thanks for your reminder, got it > > Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 23, 2015 at 08:16:01PM +0530, Vaibhav Hiremath wrote: > > > On Tuesday 23 June 2015 08:01 PM, Rob Herring wrote: > >On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang <yizhang@marvell.com> wrote: > >>88pm880 and 88pm886 are two combo PMIC chips, most of the function and the > >>register mapping are the same > > > >How do they compare to 80x/822/860 PMICs? > > > > Zhang, > > Sorry, I missed this patch-series. > > Is there any way we can get access to datahsheets of all these devices? Hi, Vaibhav: https://extranet.marvell.com/ is a useful place to access to them > > >> > >>Signed-off-by: Yi Zhang <yizhang@marvell.com> > >>--- > >> Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++ > >> 1 file changed, 33 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt > >> > >>diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt > >>new file mode 100644 > >>index 0000000..72e741c > >>--- /dev/null > >>+++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt > >>@@ -0,0 +1,33 @@ > >>+Marvell 88pm88x combo PMIC chip > >>+ > >>+This series of chip integrates regulator, rtc, onkey, switch charger, > >>+fuelgauge, gpadc and a range of I/O pins. > >>+ > >>+88pm886 and 88pm880 are two very similar chips, most of the registers mapping > >>+and functions are the same, the main difference is the latter has a separate > >>+i2c slave address to cover BUCK related setting > >>+ > >>+Required properties: > >>+- compatible: one of the strings for a specific chip: > >>+ "marvell,88pm886" > >>+ "marvell,88pm880" > >>+- reg: the i2c address > >>+- interrupt-controller: it works as an interrupt controller managing its irqs > >>+- interrupt-cells: this value is 1 > >>+ > >>+Optional properties: > >>+- marvell,88pm88x-irq-write-clear: the interrupt ack method > > > >The 80x/860 binding needs the same property. Please coordinate this > >with Vaibhav. > > > > Please refer to the patch > > https://lkml.org/lkml/2015/6/17/545 Thanks; > > Thanks, > Vaibhav -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt new file mode 100644 index 0000000..72e741c --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt @@ -0,0 +1,33 @@ +Marvell 88pm88x combo PMIC chip + +This series of chip integrates regulator, rtc, onkey, switch charger, +fuelgauge, gpadc and a range of I/O pins. + +88pm886 and 88pm880 are two very similar chips, most of the registers mapping +and functions are the same, the main difference is the latter has a separate +i2c slave address to cover BUCK related setting + +Required properties: +- compatible: one of the strings for a specific chip: + "marvell,88pm886" + "marvell,88pm880" +- reg: the i2c address +- interrupt-controller: it works as an interrupt controller managing its irqs +- interrupt-cells: this value is 1 + +Optional properties: +- marvell,88pm88x-irq-write-clear: the interrupt ack method + + +Example: + + pmic: 88pm886@30 { + compatible = "marvell,88pm886"; + reg = <0x30>; + interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>; + interrupt-parent = <&gic>; + interrupt-controller; + #interrupt-cells = <1>; + + marvell,88pm88x-irq-write-clear; + };
88pm880 and 88pm886 are two combo PMIC chips, most of the function and the register mapping are the same Signed-off-by: Yi Zhang <yizhang@marvell.com> --- Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt