Patchwork -next Mar 22: s390 build failure (drivers/s390/net/qeth_l3)

login
register
mail settings
Submitter frank.blaschka@de.ibm.com
Date March 22, 2010, 1 p.m.
Message ID <20100322130025.GA8558@tuxmaker.boeblingen.de.ibm.com>
Download mbox | patch
Permalink /patch/48295/
State Accepted
Delegated to: David Miller
Headers show

Comments

frank.blaschka@de.ibm.com - March 22, 2010, 1 p.m.
On Mon, Mar 22, 2010 at 02:40:59PM +0530, Sachin Sant wrote:
> Todays next fails to build on a s390 box with
> 
>  CC [M]  drivers/s390/net/qeth_l3_main.o
> drivers/s390/net/qeth_l3_main.c: In function 'qeth_l3_free_vlan_addresses6':
> drivers/s390/net/qeth_l3_main.c:1931: error: incompatible types in 
> assignment
> drivers/s390/net/qeth_l3_main.c:1931: error: 'struct inet6_ifaddr' has no 
> member named 'lst_next'
> make[2]: *** [drivers/s390/net/qeth_l3_main.o] Error 1
>

Hi, this patch should fix the problem

Thanks
	Frank

--- 
[PATCH] qeth: l3 fix build error in ipv6 addr list handling

From: Frank Blaschka <frank.blaschka@de.ibm.com>

Adapt qeth l3 to:
commit c2e21293c054817c42eb5fa9c613d2ad51954136
(ipv6: convert addrconf list to hlist)
converted lst_next member of inet6_ifaddr struct to a hlist.

Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
 drivers/s390/net/qeth_l3_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 22, 2010, 5 p.m.
From: Blaschka <frank.blaschka@de.ibm.com>
Date: Mon, 22 Mar 2010 14:00:25 +0100

> [PATCH] qeth: l3 fix build error in ipv6 addr list handling
> 
> From: Frank Blaschka <frank.blaschka@de.ibm.com>
> 
> Adapt qeth l3 to:
> commit c2e21293c054817c42eb5fa9c613d2ad51954136
> (ipv6: convert addrconf list to hlist)
> converted lst_next member of inet6_ifaddr struct to a hlist.
> 
> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>

Applied, thanks for fixing this Frank.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -1928,7 +1928,7 @@  static void qeth_l3_free_vlan_addresses6
 	in6_dev = in6_dev_get(vlan_group_get_device(card->vlangrp, vid));
 	if (!in6_dev)
 		return;
-	for (ifa = in6_dev->addr_list; ifa; ifa = ifa->lst_next) {
+	list_for_each_entry(ifa, &in6_dev->addr_list, if_list) {
 		addr = qeth_l3_get_addr_buffer(QETH_PROT_IPV6);
 		if (addr) {
 			memcpy(&addr->u.a6.addr, &ifa->addr,