Message ID | 1433944442-7054-1-git-send-email-fcooper@ti.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
On Wed, Jun 10, 2015 at 08:54:02AM -0500, Franklin S Cooper Jr wrote: > Currently there is no default value for NETARGS if CONFIG_CMD_NET=y isn't set. > This results in build errors which was first discovered when trying to run > make env. > > By defining a blank NETARGS these errors can be avoided. > > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> > --- > include/configs/ti_armv7_common.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h > index f882942..d1c390f 100644 > --- a/include/configs/ti_armv7_common.h > +++ b/include/configs/ti_armv7_common.h > @@ -301,7 +301,8 @@ > "run netloadfdt; " \ > "run netargs; " \ > "bootz ${loadaddr} - ${fdtaddr}\0" > - > +#else > +#define NETARGS "" > #endif > > #endif /* __CONFIG_TI_ARMV7_COMMON_H__ */ > -- Build tested for am335x_evm, am43xx_evm and omap5_uevm. Tested-by: Maxin B. John <maxin.john@enea.com> Best Regards, Maxin
On Wed, Jun 10, 2015 at 08:54:02AM -0500, Franklin S Cooper Jr wrote: > Currently there is no default value for NETARGS if CONFIG_CMD_NET=y isn't set. > This results in build errors which was first discovered when trying to run > make env. > > By defining a blank NETARGS these errors can be avoided. > > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Wed, Jun 10, 2015 at 08:54:02AM -0500, Cooper Jr., Franklin wrote: > Currently there is no default value for NETARGS if CONFIG_CMD_NET=y isn't set. > This results in build errors which was first discovered when trying to run > make env. > > By defining a blank NETARGS these errors can be avoided. > > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> > Tested-by: Maxin B. John <maxin.john@enea.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h index f882942..d1c390f 100644 --- a/include/configs/ti_armv7_common.h +++ b/include/configs/ti_armv7_common.h @@ -301,7 +301,8 @@ "run netloadfdt; " \ "run netargs; " \ "bootz ${loadaddr} - ${fdtaddr}\0" - +#else +#define NETARGS "" #endif #endif /* __CONFIG_TI_ARMV7_COMMON_H__ */
Currently there is no default value for NETARGS if CONFIG_CMD_NET=y isn't set. This results in build errors which was first discovered when trying to run make env. By defining a blank NETARGS these errors can be avoided. Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> --- include/configs/ti_armv7_common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)