| Message ID | 1433925663-3713-1-git-send-email-poeschel@lemonage.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Lars, On Wed, Jun 10, 2015 at 3:40 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > Users who want to use RBTREE can now select it by Kconfig. > Selecting it by board config include is still possible. > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > --- I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html Also, you need to use the tools/moveconfig.py tool to update the headers and defconfigs. So... NAK Thanks, -Joe
On Wed, Jun 10, 2015 at 08:49:28AM -0500, Joe Hershberger wrote: > Hi Lars, > > On Wed, Jun 10, 2015 at 3:40 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > > Users who want to use RBTREE can now select it by Kconfig. > > Selecting it by board config include is still possible. > > > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > > --- > > I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html Well, ... ok. You won ;-) Your patchset is by far more comprehensive than mine. If I see this right in the archives, you did not receive any comments since nearly a month. This was RFC will you resend this as a "real" PATCH ? Could you then include two of the dependencies from my patches: I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS has to depend on CMD_UBI. Thanks, Lars
Hi Lars, On Wed, Jun 10, 2015 at 10:08 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > On Wed, Jun 10, 2015 at 08:49:28AM -0500, Joe Hershberger wrote: >> Hi Lars, >> >> On Wed, Jun 10, 2015 at 3:40 AM, Lars Poeschel <poeschel@lemonage.de> wrote: >> > Users who want to use RBTREE can now select it by Kconfig. >> > Selecting it by board config include is still possible. >> > >> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> >> > --- >> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html > > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than > mine. > If I see this right in the archives, you did not receive any comments > since nearly a month. That is true. I really would like a little feedback on it... or maybe I can just drop the controversial one and only include these things... they seem to be mostly straightforward. > This was RFC will you resend this as a "real" PATCH ? Yes. > Could you then include two of the dependencies from my patches: > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS > has to depend on CMD_UBI. Will do. Cheers, -Joe
On Wed, Jun 10, 2015 at 10:40:59AM +0200, Lars Poeschel wrote: > Users who want to use RBTREE can now select it by Kconfig. > Selecting it by board config include is still possible. > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> Applied to u-boot/master, thanks!
Hey Tom, On Fri, Jun 19, 2015 at 3:24 PM, Tom Rini <trini@konsulko.com> wrote: > On Wed, Jun 10, 2015 at 10:40:59AM +0200, Lars Poeschel wrote: > >> Users who want to use RBTREE can now select it by Kconfig. >> Selecting it by board config include is still possible. >> >> Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > > Applied to u-boot/master, thanks! Please note the discussion on this. Did you mean to apply it? Thanks, -Joe
On Wed, Jun 10, 2015 at 08:49:28AM -0500, Joe Hershberger wrote: > Hi Lars, > > On Wed, Jun 10, 2015 at 3:40 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > > Users who want to use RBTREE can now select it by Kconfig. > > Selecting it by board config include is still possible. > > > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > > --- > > I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html > > Also, you need to use the tools/moveconfig.py tool to update the > headers and defconfigs. So... > > NAK Oh blarg, I missed this part somehow, dang it.. So now what?
On Fri, Jun 19, 2015 at 3:33 PM, Tom Rini <trini@konsulko.com> wrote: > On Wed, Jun 10, 2015 at 08:49:28AM -0500, Joe Hershberger wrote: > >> Hi Lars, >> >> On Wed, Jun 10, 2015 at 3:40 AM, Lars Poeschel <poeschel@lemonage.de> wrote: >> > Users who want to use RBTREE can now select it by Kconfig. >> > Selecting it by board config include is still possible. >> > >> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> >> > --- >> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html >> >> Also, you need to use the tools/moveconfig.py tool to update the >> headers and defconfigs. So... >> >> NAK > > Oh blarg, I missed this part somehow, dang it.. So now what? If you haven't pushed it yet you can back it out, right? -Joe
On Fri, Jun 19, 2015 at 03:39:44PM -0500, Joe Hershberger wrote: > On Fri, Jun 19, 2015 at 3:33 PM, Tom Rini <trini@konsulko.com> wrote: > > On Wed, Jun 10, 2015 at 08:49:28AM -0500, Joe Hershberger wrote: > > > >> Hi Lars, > >> > >> On Wed, Jun 10, 2015 at 3:40 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > >> > Users who want to use RBTREE can now select it by Kconfig. > >> > Selecting it by board config include is still possible. > >> > > >> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> > >> > --- > >> > >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html > >> > >> Also, you need to use the tools/moveconfig.py tool to update the > >> headers and defconfigs. So... > >> > >> NAK > > > > Oh blarg, I missed this part somehow, dang it.. So now what? > > If you haven't pushed it yet you can back it out, right? Yay for getting side-tracked. Dropping this series on the floor.
On Wed, Jun 10, 2015 at 10:40:59AM +0200, Lars Poeschel wrote: > Users who want to use RBTREE can now select it by Kconfig. > Selecting it by board config include is still possible. > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de> For the record, not applied to u-boot/master, thanks!
Hi Joe, On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: > >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html > > > > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than > > mine. > > If I see this right in the archives, you did not receive any comments > > since nearly a month. > > That is true. I really would like a little feedback on it... or maybe > I can just drop the controversial one and only include these things... > they seem to be mostly straightforward. > > > This was RFC will you resend this as a "real" PATCH ? > > Yes. > > > Could you then include two of the dependencies from my patches: > > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS > > has to depend on CMD_UBI. > > Will do. I saw no action from you on this one. Can I help out - at least for the decompression / ubi / ubifs part ? I think the setexpr / env location parts from your patchset can then go in as seperate patches. Regards, Lars
Hi Lars, On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > Hi Joe, > > On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: >> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html >> > >> > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than >> > mine. >> > If I see this right in the archives, you did not receive any comments >> > since nearly a month. >> >> That is true. I really would like a little feedback on it... or maybe >> I can just drop the controversial one and only include these things... >> they seem to be mostly straightforward. >> >> > This was RFC will you resend this as a "real" PATCH ? >> >> Yes. >> >> > Could you then include two of the dependencies from my patches: >> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS >> > has to depend on CMD_UBI. >> >> Will do. > > I saw no action from you on this one. Can I help out - at least for the > decompression / ubi / ubifs part ? Sorry about that... the end of last release got a little crazy. > I think the setexpr / env location parts from your patchset can then go > in as seperate patches. I agree. I'll split them apart and send these out. Cheers, -Joe
Hi Lars, On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger <joe.hershberger@gmail.com> wrote: > Hi Lars, > > On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: >> Hi Joe, >> >> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: >>> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html >>> > >>> > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than >>> > mine. >>> > If I see this right in the archives, you did not receive any comments >>> > since nearly a month. >>> >>> That is true. I really would like a little feedback on it... or maybe >>> I can just drop the controversial one and only include these things... >>> they seem to be mostly straightforward. >>> >>> > This was RFC will you resend this as a "real" PATCH ? >>> >>> Yes. >>> >>> > Could you then include two of the dependencies from my patches: >>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS >>> > has to depend on CMD_UBI. >>> >>> Will do. >> >> I saw no action from you on this one. Can I help out - at least for the >> decompression / ubi / ubifs part ? > > Sorry about that... the end of last release got a little crazy. > >> I think the setexpr / env location parts from your patchset can then go >> in as seperate patches. > > I agree. I'll split them apart and send these out. I haven't forgotten about this... I plan to get this sent out this week. -Joe
Hi Lars, On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger <joe.hershberger@gmail.com> wrote: > Hi Lars, > > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger > <joe.hershberger@gmail.com> wrote: >> Hi Lars, >> >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: >>> Hi Joe, >>> >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: >>>> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html >>>> > >>>> > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than >>>> > mine. >>>> > If I see this right in the archives, you did not receive any comments >>>> > since nearly a month. >>>> >>>> That is true. I really would like a little feedback on it... or maybe >>>> I can just drop the controversial one and only include these things... >>>> they seem to be mostly straightforward. >>>> >>>> > This was RFC will you resend this as a "real" PATCH ? >>>> >>>> Yes. >>>> >>>> > Could you then include two of the dependencies from my patches: >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over yet. Do you know what the dependency relationship is there? If not I'll dig into it a bit. >>>> > has to depend on CMD_UBI. >>>> >>>> Will do. >>> >>> I saw no action from you on this one. Can I help out - at least for the >>> decompression / ubi / ubifs part ? >> >> Sorry about that... the end of last release got a little crazy. >> >>> I think the setexpr / env location parts from your patchset can then go >>> in as seperate patches. >> >> I agree. I'll split them apart and send these out. > > I haven't forgotten about this... I plan to get this sent out this week. I had this ready to go, but conflicts with https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to regenerate the moves after that goes in. -Joe
On Tue, Aug 18, 2015 at 01:47:20PM -0500, Joe Hershberger wrote: > Hi Lars, > > On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger > <joe.hershberger@gmail.com> wrote: > > Hi Lars, > > > > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger > > <joe.hershberger@gmail.com> wrote: > >> Hi Lars, > >> > >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > >>> Hi Joe, > >>> > >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: > >>>> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html > >>>> > > >>>> > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than > >>>> > mine. > >>>> > If I see this right in the archives, you did not receive any comments > >>>> > since nearly a month. > >>>> > >>>> That is true. I really would like a little feedback on it... or maybe > >>>> I can just drop the controversial one and only include these things... > >>>> they seem to be mostly straightforward. > >>>> > >>>> > This was RFC will you resend this as a "real" PATCH ? > >>>> > >>>> Yes. > >>>> > >>>> > Could you then include two of the dependencies from my patches: > >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS > > I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over > yet. Do you know what the dependency relationship is there? If not > I'll dig into it a bit. > > >>>> > has to depend on CMD_UBI. > >>>> > >>>> Will do. > >>> > >>> I saw no action from you on this one. Can I help out - at least for the > >>> decompression / ubi / ubifs part ? > >> > >> Sorry about that... the end of last release got a little crazy. > >> > >>> I think the setexpr / env location parts from your patchset can then go > >>> in as seperate patches. > >> > >> I agree. I'll split them apart and send these out. > > > > I haven't forgotten about this... I plan to get this sent out this week. > > I had this ready to go, but conflicts with > https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to > regenerate the moves after that goes in. Note that since it's part of the E1000 series I gave it to you in patchwork :)
On Tue, Aug 18, 2015 at 2:27 PM, Tom Rini <trini@konsulko.com> wrote: > On Tue, Aug 18, 2015 at 01:47:20PM -0500, Joe Hershberger wrote: >> Hi Lars, >> >> On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger >> <joe.hershberger@gmail.com> wrote: >> > Hi Lars, >> > >> > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger >> > <joe.hershberger@gmail.com> wrote: >> >> Hi Lars, >> >> >> >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: >> >>> Hi Joe, >> >>> >> >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: >> >>>> >> I beat you to it: http://lists.denx.de/pipermail/u-boot/2015-May/214261.html >> >>>> > >> >>>> > Well, ... ok. You won ;-) Your patchset is by far more comprehensive than >> >>>> > mine. >> >>>> > If I see this right in the archives, you did not receive any comments >> >>>> > since nearly a month. >> >>>> >> >>>> That is true. I really would like a little feedback on it... or maybe >> >>>> I can just drop the controversial one and only include these things... >> >>>> they seem to be mostly straightforward. >> >>>> >> >>>> > This was RFC will you resend this as a "real" PATCH ? >> >>>> >> >>>> Yes. >> >>>> >> >>>> > Could you then include two of the dependencies from my patches: >> >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously CMD_UBIFS >> >> I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over >> yet. Do you know what the dependency relationship is there? If not >> I'll dig into it a bit. >> >> >>>> > has to depend on CMD_UBI. >> >>>> >> >>>> Will do. >> >>> >> >>> I saw no action from you on this one. Can I help out - at least for the >> >>> decompression / ubi / ubifs part ? >> >> >> >> Sorry about that... the end of last release got a little crazy. >> >> >> >>> I think the setexpr / env location parts from your patchset can then go >> >>> in as seperate patches. >> >> >> >> I agree. I'll split them apart and send these out. >> > >> > I haven't forgotten about this... I plan to get this sent out this week. >> >> I had this ready to go, but conflicts with >> https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to >> regenerate the moves after that goes in. > > Note that since it's part of the E1000 series I gave it to you in > patchwork :) Sure, I expect to take it in once all feedback is addressed on that series. :) -Joe
Am Dienstag, 18. August 2015, 13:47:20 schrieb Joe Hershberger: > Hi Lars, > > On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger > > <joe.hershberger@gmail.com> wrote: > > Hi Lars, > > > > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger > > > > <joe.hershberger@gmail.com> wrote: > >> Hi Lars, > >> > >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > >>> Hi Joe, > >>> > >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: > >>>> >> I beat you to it: > >>>> >> http://lists.denx.de/pipermail/u-boot/2015-May/214261.html>>>> > > >>>> > Well, ... ok. You won ;-) Your patchset is by far more comprehensive > >>>> > than > >>>> > mine. > >>>> > If I see this right in the archives, you did not receive any comments > >>>> > since nearly a month. > >>>> > >>>> That is true. I really would like a little feedback on it... or maybe > >>>> I can just drop the controversial one and only include these things... > >>>> they seem to be mostly straightforward. > >>>> > >>>> > This was RFC will you resend this as a "real" PATCH ? > >>>> > >>>> Yes. > >>>> > >>>> > Could you then include two of the dependencies from my patches: > >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously > >>>> > CMD_UBIFS > > I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over > yet. Do you know what the dependency relationship is there? If not > I'll dig into it a bit. Sorry, I am really not sure about this. I think in my configuration MTD_PARTITIONS worked even without MTD_DEVICE. But maybe looking into drivers/mtd/Makefile:8 helps here. It seems that MTD_PARTITIONS needs either MTD_DEVICE, CMD_NAND, CMD_ONENAND or CMD_SF. Lars
Am Dienstag, 18. August 2015, 14:32:13 schrieb Joe Hershberger: > On Tue, Aug 18, 2015 at 2:27 PM, Tom Rini <trini@konsulko.com> wrote: > > On Tue, Aug 18, 2015 at 01:47:20PM -0500, Joe Hershberger wrote: > >> Hi Lars, > >> > >> On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger > >> > >> <joe.hershberger@gmail.com> wrote: > >> > Hi Lars, > >> > > >> > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger > >> > > >> > <joe.hershberger@gmail.com> wrote: > >> >> Hi Lars, > >> >> > >> >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > >> >>> Hi Joe, > >> >>> > >> >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: > >> >>>> >> I beat you to it: > >> >>>> >> http://lists.denx.de/pipermail/u-boot/2015-May/214261.html>> >>>> > > >> >>>> > Well, ... ok. You won ;-) Your patchset is by far more > >> >>>> > comprehensive than > >> >>>> > mine. > >> >>>> > If I see this right in the archives, you did not receive any > >> >>>> > comments > >> >>>> > since nearly a month. > >> >>>> > >> >>>> That is true. I really would like a little feedback on it... or > >> >>>> maybe > >> >>>> I can just drop the controversial one and only include these > >> >>>> things... > >> >>>> they seem to be mostly straightforward. > >> >>>> > >> >>>> > This was RFC will you resend this as a "real" PATCH ? > >> >>>> > >> >>>> Yes. > >> >>>> > >> >>>> > Could you then include two of the dependencies from my patches: > >> >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously > >> >>>> > CMD_UBIFS > >> > >> I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over > >> yet. Do you know what the dependency relationship is there? If not > >> I'll dig into it a bit. > >> > >> >>>> > has to depend on CMD_UBI. > >> >>>> > >> >>>> Will do. > >> >>> > >> >>> I saw no action from you on this one. Can I help out - at least for > >> >>> the > >> >>> decompression / ubi / ubifs part ? > >> >> > >> >> Sorry about that... the end of last release got a little crazy. > >> >> > >> >>> I think the setexpr / env location parts from your patchset can then > >> >>> go > >> >>> in as seperate patches. > >> >> > >> >> I agree. I'll split them apart and send these out. > >> > > >> > I haven't forgotten about this... I plan to get this sent out this > >> > week. > >> > >> I had this ready to go, but conflicts with > >> https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to > >> regenerate the moves after that goes in. > > > > Note that since it's part of the E1000 series I gave it to you in > > patchwork :) > > Sure, I expect to take it in once all feedback is addressed on that series. > :) Joe, a gentle ping on this. I don't see RBTREE, MTD_PARTIONS and UBIFS in Kconfig yet. Regards, Lars
Hi Lars, On Tue, Dec 15, 2015 at 8:44 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > Am Dienstag, 18. August 2015, 14:32:13 schrieb Joe Hershberger: >> On Tue, Aug 18, 2015 at 2:27 PM, Tom Rini <trini@konsulko.com> wrote: >> > On Tue, Aug 18, 2015 at 01:47:20PM -0500, Joe Hershberger wrote: >> >> Hi Lars, >> >> >> >> On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger >> >> >> >> <joe.hershberger@gmail.com> wrote: >> >> > Hi Lars, >> >> > >> >> > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger >> >> > >> >> > <joe.hershberger@gmail.com> wrote: >> >> >> Hi Lars, >> >> >> >> >> >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel@lemonage.de> > wrote: >> >> >>> Hi Joe, >> >> >>> >> >> >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: >> >> >>>> >> I beat you to it: >> >> >>>> >> http://lists.denx.de/pipermail/u-boot/2015-May/214261.html>> >>>> >> >> >> >>>> > Well, ... ok. You won ;-) Your patchset is by far more >> >> >>>> > comprehensive than >> >> >>>> > mine. >> >> >>>> > If I see this right in the archives, you did not receive any >> >> >>>> > comments >> >> >>>> > since nearly a month. >> >> >>>> >> >> >>>> That is true. I really would like a little feedback on it... or >> >> >>>> maybe >> >> >>>> I can just drop the controversial one and only include these >> >> >>>> things... >> >> >>>> they seem to be mostly straightforward. >> >> >>>> >> >> >>>> > This was RFC will you resend this as a "real" PATCH ? >> >> >>>> >> >> >>>> Yes. >> >> >>>> >> >> >>>> > Could you then include two of the dependencies from my patches: >> >> >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously >> >> >>>> > CMD_UBIFS >> >> >> >> I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over >> >> yet. Do you know what the dependency relationship is there? If not >> >> I'll dig into it a bit. >> >> >> >> >>>> > has to depend on CMD_UBI. >> >> >>>> >> >> >>>> Will do. >> >> >>> >> >> >>> I saw no action from you on this one. Can I help out - at least for >> >> >>> the >> >> >>> decompression / ubi / ubifs part ? >> >> >> >> >> >> Sorry about that... the end of last release got a little crazy. >> >> >> >> >> >>> I think the setexpr / env location parts from your patchset can then >> >> >>> go >> >> >>> in as seperate patches. >> >> >> >> >> >> I agree. I'll split them apart and send these out. >> >> > >> >> > I haven't forgotten about this... I plan to get this sent out this >> >> > week. >> >> >> >> I had this ready to go, but conflicts with >> >> https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to >> >> regenerate the moves after that goes in. >> > >> > Note that since it's part of the E1000 series I gave it to you in >> > patchwork :) >> >> Sure, I expect to take it in once all feedback is addressed on that series. >> :) > > Joe, > a gentle ping on this. > I don't see RBTREE, MTD_PARTIONS and UBIFS in Kconfig yet. Argh! I forgot that I had this sitting in a branch that still had a few targets not building cleanly. This moving configs stuff is a pain when so many boards use them and in odd / slightly different ways. Now all the work has to be regenerated and reanalyzed for build failures. Maybe I'll just start with one dependency... get that in, then focus on the next, etc. There are so many boards that conflict readily if you have to spend any amount of time resolving issues. Sorry for the delay. -Joe
Am Dienstag, 15. Dezember 2015, 16:54:45 schrieb Joe Hershberger: > Hi Lars, > > On Tue, Dec 15, 2015 at 8:44 AM, Lars Poeschel <poeschel@lemonage.de> wrote: > > Am Dienstag, 18. August 2015, 14:32:13 schrieb Joe Hershberger: > >> On Tue, Aug 18, 2015 at 2:27 PM, Tom Rini <trini@konsulko.com> wrote: > >> > On Tue, Aug 18, 2015 at 01:47:20PM -0500, Joe Hershberger wrote: > >> >> Hi Lars, > >> >> > >> >> On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger > >> >> > >> >> <joe.hershberger@gmail.com> wrote: > >> >> > Hi Lars, > >> >> > > >> >> > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger > >> >> > > >> >> > <joe.hershberger@gmail.com> wrote: > >> >> >> Hi Lars, > >> >> >> > >> >> >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel > >> >> >> <poeschel@lemonage.de> > > > > wrote: > >> >> >>> Hi Joe, > >> >> >>> > >> >> >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: > >> >> >>>> >> I beat you to it: > >> >> >>>> >> http://lists.denx.de/pipermail/u-boot/2015-May/214261.html>> > >> >> >>>> >> >>>> > >> >> >>>> > > >> >> >>>> > Well, ... ok. You won ;-) Your patchset is by far more > >> >> >>>> > comprehensive than > >> >> >>>> > mine. > >> >> >>>> > If I see this right in the archives, you did not receive any > >> >> >>>> > comments > >> >> >>>> > since nearly a month. > >> >> >>>> > >> >> >>>> That is true. I really would like a little feedback on it... or > >> >> >>>> maybe > >> >> >>>> I can just drop the controversial one and only include these > >> >> >>>> things... > >> >> >>>> they seem to be mostly straightforward. > >> >> >>>> > >> >> >>>> > This was RFC will you resend this as a "real" PATCH ? > >> >> >>>> > >> >> >>>> Yes. > >> >> >>>> > >> >> >>>> > Could you then include two of the dependencies from my patches: > >> >> >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously > >> >> >>>> > CMD_UBIFS > >> >> > >> >> I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over > >> >> yet. Do you know what the dependency relationship is there? If not > >> >> I'll dig into it a bit. > >> >> > >> >> >>>> > has to depend on CMD_UBI. > >> >> >>>> > >> >> >>>> Will do. > >> >> >>> > >> >> >>> I saw no action from you on this one. Can I help out - at least > >> >> >>> for > >> >> >>> the > >> >> >>> decompression / ubi / ubifs part ? > >> >> >> > >> >> >> Sorry about that... the end of last release got a little crazy. > >> >> >> > >> >> >>> I think the setexpr / env location parts from your patchset can > >> >> >>> then > >> >> >>> go > >> >> >>> in as seperate patches. > >> >> >> > >> >> >> I agree. I'll split them apart and send these out. > >> >> > > >> >> > I haven't forgotten about this... I plan to get this sent out this > >> >> > week. > >> >> > >> >> I had this ready to go, but conflicts with > >> >> https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to > >> >> regenerate the moves after that goes in. > >> > > >> > Note that since it's part of the E1000 series I gave it to you in > >> > patchwork :) > >> > >> Sure, I expect to take it in once all feedback is addressed on that > >> series. > >> > >> :) > > > > Joe, > > a gentle ping on this. > > I don't see RBTREE, MTD_PARTIONS and UBIFS in Kconfig yet. > > Argh! I forgot that I had this sitting in a branch that still had a > few targets not building cleanly. This moving configs stuff is a pain > when so many boards use them and in odd / slightly different ways. > > Now all the work has to be regenerated and reanalyzed for build > failures. Maybe I'll just start with one dependency... get that in, > then focus on the next, etc. There are so many boards that conflict > readily if you have to spend any amount of time resolving issues. I had another idea: Is it reasonable to put the parameters into Kconfig and only change the non-problematic board configs and leave the rest as they are ? That shouldn't harm ? But I think you are right. It is propably the best if you do it step by step and bring one patch after the other in. Regards, Lars
diff --git a/lib/Kconfig b/lib/Kconfig index 3c8de86..fc2be56 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -47,6 +47,13 @@ config REGEX config LIB_RAND bool +config RBTREE + bool "Red-black Trees (rbtree)" + help + Red-black trees are a type of self-balancing binary search + tree, used for storing sortable key/value data pairs. + This is currently used in u-boot for ubi and ubifs. + source lib/rsa/Kconfig menu "Hashing Support"
Users who want to use RBTREE can now select it by Kconfig. Selecting it by board config include is still possible. Signed-off-by: Lars Poeschel <poeschel@lemonage.de> --- lib/Kconfig | 7 +++++++ 1 file changed, 7 insertions(+)