diff mbox

[1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

Message ID 1433918670-16552-1-git-send-email-jerzy.grzegorek@trzebnica.net
State Accepted
Headers show

Commit Message

Jerzy Grzegorek June 10, 2015, 6:44 a.m. UTC
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
 package/openvmtools/openvmtools.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Karoly Kasza June 10, 2015, 7:13 a.m. UTC | #1
Hi,

the official openvmtools repo is also moving to GitHub, maybe we should
modify the whole download process?
I thought I'll wait for the next release before moving from sourceforge to
github, but we could also do it now.
The back draw it that hash files can not be used with Github currently
(AFAIK).

Regards,
Karoly
Jerzy Grzegorek June 10, 2015, 8:24 a.m. UTC | #2
Hi Károly,

> Hi,
>
> the official openvmtools repo is also moving to GitHub, maybe we 
> should modify the whole download process?
> I thought I'll wait for the next release before moving from 
> sourceforge to github, but we could also do it now.

Thanks for the review.
Feel free to submit such a patch.

> The back draw it that hash files can not be used with Github currently 
> (AFAIK).

Let's wait and see what others think.

Regards,
Jerzy

>
> Regards,
> Karoly
Arnout Vandecappelle June 10, 2015, 9:25 p.m. UTC | #3
On 06/10/15 08:44, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Note that the proposed move to github is a good idea, but a separate patch anyway.

 Regards,
 Arnout

> ---
>  package/openvmtools/openvmtools.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk
> index ef6544a..92ecd36 100644
> --- a/package/openvmtools/openvmtools.mk
> +++ b/package/openvmtools/openvmtools.mk
> @@ -4,9 +4,10 @@
>  #
>  ################################################################################
>  
> -OPENVMTOOLS_VERSION = 9.10.0-2476743
> +OPENVMTOOLS_VERSION_MAJOR = 9.10.0
> +OPENVMTOOLS_VERSION = $(OPENVMTOOLS_VERSION_MAJOR)-2476743
>  OPENVMTOOLS_SOURCE = open-vm-tools-$(OPENVMTOOLS_VERSION).tar.gz
> -OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-9.10.0
> +OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-$(OPENVMTOOLS_VERSION_MAJOR)
>  OPENVMTOOLS_LICENSE = LGPLv2.1
>  OPENVMTOOLS_LICENSE_FILES = COPYING
>  # Autoreconf needed or config/missing will run configure again at buildtime
>
Thomas Petazzoni June 11, 2015, 8:09 p.m. UTC | #4
Dear Jerzy Grzegorek,

On Wed, 10 Jun 2015 08:44:30 +0200, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> ---
>  package/openvmtools/openvmtools.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk
index ef6544a..92ecd36 100644
--- a/package/openvmtools/openvmtools.mk
+++ b/package/openvmtools/openvmtools.mk
@@ -4,9 +4,10 @@ 
 #
 ################################################################################
 
-OPENVMTOOLS_VERSION = 9.10.0-2476743
+OPENVMTOOLS_VERSION_MAJOR = 9.10.0
+OPENVMTOOLS_VERSION = $(OPENVMTOOLS_VERSION_MAJOR)-2476743
 OPENVMTOOLS_SOURCE = open-vm-tools-$(OPENVMTOOLS_VERSION).tar.gz
-OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-9.10.0
+OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-$(OPENVMTOOLS_VERSION_MAJOR)
 OPENVMTOOLS_LICENSE = LGPLv2.1
 OPENVMTOOLS_LICENSE_FILES = COPYING
 # Autoreconf needed or config/missing will run configure again at buildtime