From patchwork Sat Mar 20 07:08:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: qemu-io: Fix return value handling of bdrv_open From: Ryota OZAKI X-Patchwork-Id: 48203 Message-Id: <1269068918-6163-1-git-send-email-ozaki.ryota@gmail.com> To: qemu-devel@nongnu.org Date: Sat, 20 Mar 2010 16:08:38 +0900 bdrv_open may return -errno so we have to check if the return value is '< 0', not '== -1'. Signed-off-by: Ryota Ozaki --- qemu-io.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index b2f2f5a..2f195bf 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1284,7 +1284,7 @@ static int openfile(char *name, int flags, int growable) flags |= BDRV_O_FILE; } - if (bdrv_open(bs, name, flags) == -1) { + if (bdrv_open(bs, name, flags) < 0) { fprintf(stderr, "%s: can't open device %s\n", progname, name); bs = NULL; return 1;