From patchwork Sat Mar 20 06:23:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/3] qemu-nbd: Fix return value handling of bdrv_open Date: Fri, 19 Mar 2010 20:23:22 -0000 From: Ryota OZAKI X-Patchwork-Id: 48200 Message-Id: <1269066204-4376-1-git-send-email-ozaki.ryota@gmail.com> To: qemu-devel@nongnu.org bdrv_open may return -errno so we have to check if the return value is '< 0', not '== -1'. Signed-off-by: Ryota Ozaki --- qemu-nbd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index a393583..b89c361 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -333,7 +333,7 @@ int main(int argc, char **argv) if (bs == NULL) return 1; - if (bdrv_open(bs, argv[optind], flags) == -1) + if (bdrv_open(bs, argv[optind], flags) < 0) return 1; fd_size = bs->total_sectors * 512;