From patchwork Sat Mar 20 06:23:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryota OZAKI X-Patchwork-Id: 48200 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 790AEB7D53 for ; Sat, 20 Mar 2010 17:34:13 +1100 (EST) Received: from localhost ([127.0.0.1]:47077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nss91-0003zF-5y for incoming@patchwork.ozlabs.org; Sat, 20 Mar 2010 02:26:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nss7j-0003zA-7t for qemu-devel@nongnu.org; Sat, 20 Mar 2010 02:25:27 -0400 Received: from [199.232.76.173] (port=49775 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nss7i-0003z2-Nf for qemu-devel@nongnu.org; Sat, 20 Mar 2010 02:25:26 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nss7i-00070N-1q for qemu-devel@nongnu.org; Sat, 20 Mar 2010 02:25:26 -0400 Received: from mx20.gnu.org ([199.232.41.8]:45478) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nss7g-0006zi-Pb for qemu-devel@nongnu.org; Sat, 20 Mar 2010 02:25:25 -0400 Received: from mail-yx0-f191.google.com ([209.85.210.191]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nss7f-0003bb-Ty for qemu-devel@nongnu.org; Sat, 20 Mar 2010 02:25:24 -0400 Received: by yxe29 with SMTP id 29so1350815yxe.4 for ; Fri, 19 Mar 2010 23:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:x-mailer; bh=nBdXyjTReANytcP+EpOgS+mqXhUAobNRDyosxvfFzwE=; b=fQzpzo/KlaAYGuW9UExFf5Qp0QhgwOm/EXSXacE1djQSs8wPoYFdzbT22KxAmUmDnt 3SL7zybTm+cuwmAx51epwdebDo8OVwBZ/AVgseyydizFcypSJUU/VS8jACKgMVx2N6z/ t/6i8lzCK+iPVdsQNtE0NpgTHEwKRJ7AFsBQs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer; b=l2rMnseUFBV2CV3iLd+f7+4KymYBXvDYwr3hcTf3HIX4fPxgh/SmPNme8voHWzBlNN XBHL1KPpPe0gEoEt7hmqKSUyHCjS+iZ5rgU3nWmB+kGtbWqk8/UYvql2dScHkXGs/Gye 7NGwxhNW0uhUwbM3SoD+dxrLutqkmbsPNAkV4= Received: by 10.101.186.8 with SMTP id n8mr9500335anp.229.1269066323151; Fri, 19 Mar 2010 23:25:23 -0700 (PDT) Received: from localhost.localdomain (host105.nvlab.org [122.1.115.105]) by mx.google.com with ESMTPS id 4sm688817ywd.13.2010.03.19.23.25.21 (version=SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 23:25:22 -0700 (PDT) From: Ryota Ozaki To: qemu-devel@nongnu.org Date: Sat, 20 Mar 2010 15:23:22 +0900 Message-Id: <1269066204-4376-1-git-send-email-ozaki.ryota@gmail.com> X-Mailer: git-send-email 1.6.5.2 X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org bdrv_open may return -errno so we have to check if the return value is '< 0', not '== -1'. Signed-off-by: Ryota Ozaki --- qemu-nbd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index a393583..b89c361 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -333,7 +333,7 @@ int main(int argc, char **argv) if (bs == NULL) return 1; - if (bdrv_open(bs, argv[optind], flags) == -1) + if (bdrv_open(bs, argv[optind], flags) < 0) return 1; fd_size = bs->total_sectors * 512;