diff mbox

[PULL,3/9] vl: Fail right after first bad -object

Message ID 1433786537-30874-4-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster June 8, 2015, 6:02 p.m. UTC 
Failure to create an object with -object is a fatal error.  However,
we delay the actual exit until all -object are processed.  On the one
hand, this permits detection of genuine additional errors.  On the
other hand, it can muddy the waters with uninteresting additional
errors, e.g. when a later -object tries to reference a prior one that
failed.

We generally stop right on the first bad option, so do that for
-object as well.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/vl.c b/vl.c
index 680f4d8..c9c3f33 100644
--- a/vl.c
+++ b/vl.c
@@ -4055,7 +4055,7 @@  int main(int argc, char **argv, char **envp)
     }
 
     if (qemu_opts_foreach(qemu_find_opts("object"),
-                          object_create, NULL, 0) != 0) {
+                          object_create, NULL, 1) != 0) {
         exit(1);
     }