mbox

[PULL,0/3] Initial vfio-platform support

Message ID 20150608170543.5497.53497.stgit@gimli.home
State New
Headers show

Pull-request

git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0

Message

Alex Williamson June 8, 2015, 5:06 p.m. UTC 
The following changes since commit 2e29dd7c44db30e3d3c108ab2a622cbdac6d16f0:

  Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2015-06-08 14:07:32 +0100)

are available in the git repository at:


  git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0

for you to fetch changes up to 88be7b6bf4c86d89e70585881b6b3326f9bac822:

  hw/vfio/platform: calxeda xgmac device (2015-06-08 09:25:26 -0600)

----------------------------------------------------------------
Initial VFIO platform device support (Eric Auger, et al.)

----------------------------------------------------------------
Eric Auger (3):
      hw/vfio/platform: vfio-platform skeleton
      hw/vfio/platform: add irq assignment
      hw/vfio/platform: calxeda xgmac device

 hw/vfio/Makefile.objs                |   2 +
 hw/vfio/calxeda-xgmac.c              |  54 +++
 hw/vfio/platform.c                   | 616 +++++++++++++++++++++++++++++++++++
 include/hw/vfio/vfio-calxeda-xgmac.h |  46 +++
 include/hw/vfio/vfio-common.h        |   1 +
 include/hw/vfio/vfio-platform.h      |  75 +++++
 trace-events                         |  12 +
 7 files changed, 806 insertions(+)
 create mode 100644 hw/vfio/calxeda-xgmac.c
 create mode 100644 hw/vfio/platform.c
 create mode 100644 include/hw/vfio/vfio-calxeda-xgmac.h
 create mode 100644 include/hw/vfio/vfio-platform.h

Comments

Peter Maydell June 8, 2015, 5:50 p.m. UTC | #1 
On 8 June 2015 at 18:06, Alex Williamson <alex.williamson@redhat.com> wrote:
> The following changes since commit 2e29dd7c44db30e3d3c108ab2a622cbdac6d16f0:
>
>   Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2015-06-08 14:07:32 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0
>
> for you to fetch changes up to 88be7b6bf4c86d89e70585881b6b3326f9bac822:
>
>   hw/vfio/platform: calxeda xgmac device (2015-06-08 09:25:26 -0600)
>
> ----------------------------------------------------------------
> Initial VFIO platform device support (Eric Auger, et al.)
>
> ----------------------------------------------------------------
> Eric Auger (3):
>       hw/vfio/platform: vfio-platform skeleton
>       hw/vfio/platform: add irq assignment
>       hw/vfio/platform: calxeda xgmac device

Hi. I'm afraid this doesn't build with clang:
  CC    m68k-softmmu/hw/virtio/vhost.o
/home/petmay01/linaro/qemu-for-merges/hw/vfio/calxeda-xgmac.c:26:33:
error: unused variable
      'vfio_platform_vmstate' [-Werror,-Wunused-const-variable]
static const VMStateDescription vfio_platform_vmstate = {
                                ^

Clang is pickier about some kinds of unused variable, and this
looks like a genuine bug -- you haven't actually connected the
VMStateDescription up to anything.

thanks
-- PMM
Alex Williamson June 8, 2015, 8:06 p.m. UTC | #2 
On Mon, 2015-06-08 at 18:50 +0100, Peter Maydell wrote:
> On 8 June 2015 at 18:06, Alex Williamson <alex.williamson@redhat.com> wrote:
> > The following changes since commit 2e29dd7c44db30e3d3c108ab2a622cbdac6d16f0:
> >
> >   Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2015-06-08 14:07:32 +0100)
> >
> > are available in the git repository at:
> >
> >
> >   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0
> >
> > for you to fetch changes up to 88be7b6bf4c86d89e70585881b6b3326f9bac822:
> >
> >   hw/vfio/platform: calxeda xgmac device (2015-06-08 09:25:26 -0600)
> >
> > ----------------------------------------------------------------
> > Initial VFIO platform device support (Eric Auger, et al.)
> >
> > ----------------------------------------------------------------
> > Eric Auger (3):
> >       hw/vfio/platform: vfio-platform skeleton
> >       hw/vfio/platform: add irq assignment
> >       hw/vfio/platform: calxeda xgmac device
> 
> Hi. I'm afraid this doesn't build with clang:
>   CC    m68k-softmmu/hw/virtio/vhost.o
> /home/petmay01/linaro/qemu-for-merges/hw/vfio/calxeda-xgmac.c:26:33:
> error: unused variable
>       'vfio_platform_vmstate' [-Werror,-Wunused-const-variable]
> static const VMStateDescription vfio_platform_vmstate = {
>                                 ^
> 
> Clang is pickier about some kinds of unused variable, and this
> looks like a genuine bug -- you haven't actually connected the
> VMStateDescription up to anything.

Thanks, Peter.  Eric, it looks like you meant to set dc->vmsd to the
address of this struct in the class init function.  Do you want to fix
that and I'll send a new pull request?  I'd just send a new version of
patch 3 with the fix rolled in.  Thanks,

Alex
Eric Auger June 8, 2015, 8:50 p.m. UTC | #3 
Hi Peter, Alex,

Sure I will send a fix tomorrow morning.

Best Regards

Eric

On 8 June 2015 at 22:06, Alex Williamson <alex.williamson@redhat.com> wrote:
> On Mon, 2015-06-08 at 18:50 +0100, Peter Maydell wrote:
>> On 8 June 2015 at 18:06, Alex Williamson <alex.williamson@redhat.com> wrote:
>> > The following changes since commit 2e29dd7c44db30e3d3c108ab2a622cbdac6d16f0:
>> >
>> >   Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2015-06-08 14:07:32 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >
>> >   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0
>> >
>> > for you to fetch changes up to 88be7b6bf4c86d89e70585881b6b3326f9bac822:
>> >
>> >   hw/vfio/platform: calxeda xgmac device (2015-06-08 09:25:26 -0600)
>> >
>> > ----------------------------------------------------------------
>> > Initial VFIO platform device support (Eric Auger, et al.)
>> >
>> > ----------------------------------------------------------------
>> > Eric Auger (3):
>> >       hw/vfio/platform: vfio-platform skeleton
>> >       hw/vfio/platform: add irq assignment
>> >       hw/vfio/platform: calxeda xgmac device
>>
>> Hi. I'm afraid this doesn't build with clang:
>>   CC    m68k-softmmu/hw/virtio/vhost.o
>> /home/petmay01/linaro/qemu-for-merges/hw/vfio/calxeda-xgmac.c:26:33:
>> error: unused variable
>>       'vfio_platform_vmstate' [-Werror,-Wunused-const-variable]
>> static const VMStateDescription vfio_platform_vmstate = {
>>                                 ^
>>
>> Clang is pickier about some kinds of unused variable, and this
>> looks like a genuine bug -- you haven't actually connected the
>> VMStateDescription up to anything.
>
> Thanks, Peter.  Eric, it looks like you meant to set dc->vmsd to the
> address of this struct in the class init function.  Do you want to fix
> that and I'll send a new pull request?  I'd just send a new version of
> patch 3 with the fix rolled in.  Thanks,
>
> Alex
>