diff mbox

[U-Boot] sunxi: Request macpwr gpio before using it

Message ID 1433689170-9554-1-git-send-email-hdegoede@redhat.com
State Accepted
Delegated to: Hans de Goede
Headers show

Commit Message

Hans de Goede June 7, 2015, 2:59 p.m. UTC
This fixes ethernet no longer working on boards which use a gpio to enable
the phy.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/cpu/armv7/sunxi/board.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ian Campbell June 7, 2015, 4:04 p.m. UTC | #1
On Sun, 2015-06-07 at 16:59 +0200, Hans de Goede wrote:
> This fixes ethernet no longer working on boards which use a gpio to enable
> the phy.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> ---
>  arch/arm/cpu/armv7/sunxi/board.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c
> index 215551f..bd0d819 100644
> --- a/arch/arm/cpu/armv7/sunxi/board.c
> +++ b/arch/arm/cpu/armv7/sunxi/board.c
> @@ -241,6 +241,7 @@ int cpu_eth_init(bd_t *bis)
>  	__maybe_unused int rc;
>  
>  #ifdef CONFIG_MACPWR
> +	gpio_request(CONFIG_MACPWR, "macpwr");
>  	gpio_direction_output(CONFIG_MACPWR, 1);
>  	mdelay(200);
>  #endif
maxin.john@enea.com June 7, 2015, 6 p.m. UTC | #2
Hi,

On Sun, Jun 07, 2015 at 04:59:30PM +0200, Hans de Goede wrote:
> This fixes ethernet no longer working on boards which use a gpio to enable
> the phy.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---

Looks like we sent the same patch to the mailing list today :)
http://lists.denx.de/pipermail/u-boot/2015-June/216084.html

>  arch/arm/cpu/armv7/sunxi/board.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c
> index 215551f..bd0d819 100644
> --- a/arch/arm/cpu/armv7/sunxi/board.c
> +++ b/arch/arm/cpu/armv7/sunxi/board.c
> @@ -241,6 +241,7 @@ int cpu_eth_init(bd_t *bis)
>  	__maybe_unused int rc;
>  
>  #ifdef CONFIG_MACPWR
> +	gpio_request(CONFIG_MACPWR, "macpwr");
>  	gpio_direction_output(CONFIG_MACPWR, 1);
>  	mdelay(200);
>  #endif
> -- 
> 2.4.2

Tested the same on a Banana Pi board and if it matters,

Tested-by: Maxin B. John <maxin.john@enea.com>

Best Regards,
Maxin
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c
index 215551f..bd0d819 100644
--- a/arch/arm/cpu/armv7/sunxi/board.c
+++ b/arch/arm/cpu/armv7/sunxi/board.c
@@ -241,6 +241,7 @@  int cpu_eth_init(bd_t *bis)
 	__maybe_unused int rc;
 
 #ifdef CONFIG_MACPWR
+	gpio_request(CONFIG_MACPWR, "macpwr");
 	gpio_direction_output(CONFIG_MACPWR, 1);
 	mdelay(200);
 #endif