| Message ID | 1433625766-12319-1-git-send-email-hauke@hauke-m.de |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Hauke Mehrtens <hauke@hauke-m.de> Date: Sat, 6 Jun 2015 23:22:46 +0200 > When the driver gets unregistered a call to netif_napi_del() was > missing. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> This patch is incomplete. All of that failure paths in b44_init_one() after the netif_napi_add() call have the same exact bug. Please fix those too and resubmit. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c index 77363d6..ebb9910 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -2480,6 +2480,7 @@ static void b44_remove_one(struct ssb_device *sdev) b44_unregister_phy_one(bp); ssb_device_disable(sdev, 0); ssb_bus_may_powerdown(sdev->bus); + netif_napi_del(&bp->napi); free_netdev(dev); ssb_pcihost_set_power_state(sdev, PCI_D3hot); ssb_set_drvdata(sdev, NULL);
When the driver gets unregistered a call to netif_napi_del() was missing. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- drivers/net/ethernet/broadcom/b44.c | 1 + 1 file changed, 1 insertion(+)