diff mbox

ofono: needs dynamic library support

Message ID 22ce3bf2a6a0a4284fc350731e0e52d005e50d5b.1433622461.git.baruch@tkos.co.il
State Accepted
Commit 86cd99aa958e12e82c83da34d77b81f7c0bdd4d9
Headers show

Commit Message

Baruch Siach June 6, 2015, 8:27 p.m. UTC
The only package selection ofono, connman, requires dynamic library already.

Fixes:
http://autobuild.buildroot.net/results/c5b/c5bb44c192c076b42538f805062a465318051df4/

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/ofono/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN June 6, 2015, 8:56 p.m. UTC | #1
Baruch, All,

On 2015-06-06 23:27 +0300, Baruch Siach spake thusly:
> The only package selection ofono, connman, requires dynamic library already.
> 
> Fixes:
> http://autobuild.buildroot.net/results/c5b/c5bb44c192c076b42538f805062a465318051df4/
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/ofono/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/ofono/Config.in b/package/ofono/Config.in
> index eb1856fdb794..f709b04180d4 100644
> --- a/package/ofono/Config.in
> +++ b/package/ofono/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_OFONO
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>  	depends on BR2_USE_MMU # dbus, libglib2
>  	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405 # libcap-ng
> +	depends on !BR2_STATIC_LIBS # dlopen()
>  	select BR2_PACKAGE_LIBCAP_NG
>  	select BR2_PACKAGE_DBUS
>  	select BR2_PACKAGE_LIBGLIB2
> @@ -15,7 +16,7 @@ config BR2_PACKAGE_OFONO
>  
>  	  http://ofono.org/
>  
> -comment "ofono needs a toolchain w/ wchar, threads"
> +comment "ofono needs a toolchain w/ dynamic library, wchar, threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard June 7, 2015, 9:59 p.m. UTC | #2
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > The only package selection ofono, connman, requires dynamic library already.
 > Fixes:
 > http://autobuild.buildroot.net/results/c5b/c5bb44c192c076b42538f805062a465318051df4/

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.
diff mbox

Patch

diff --git a/package/ofono/Config.in b/package/ofono/Config.in
index eb1856fdb794..f709b04180d4 100644
--- a/package/ofono/Config.in
+++ b/package/ofono/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_OFONO
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus, libglib2
 	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405 # libcap-ng
+	depends on !BR2_STATIC_LIBS # dlopen()
 	select BR2_PACKAGE_LIBCAP_NG
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
@@ -15,7 +16,7 @@  config BR2_PACKAGE_OFONO
 
 	  http://ofono.org/
 
-comment "ofono needs a toolchain w/ wchar, threads"
+comment "ofono needs a toolchain w/ dynamic library, wchar, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405