Patchwork UBUNTU: [Config] Enable musb/ehci on beagleboard

login
register
mail settings
Submitter robertcnelson@gmail.com
Date March 19, 2010, 12:06 p.m.
Message ID <4ba368c4.5644f10a.158a.4557@mx.google.com>
Download mbox | patch
Permalink /patch/48138/
State Not Applicable
Headers show

Comments

robertcnelson@gmail.com - March 19, 2010, 12:06 p.m.
From: Robert Nelson <robert.nelson@digikey.com>

BugLink: http://bugs.launchpad.net/bugs/541030

Signed-off-by: Robert Nelson <robert.nelson@digikey.com>
---
 debian.ti-omap/config/config.common.ubuntu |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Tim Gardner - March 19, 2010, 12:29 p.m.
On 03/19/2010 06:06 AM, robertcnelson@gmail.com wrote:
> From: Robert Nelson<robert.nelson@digikey.com>
>
> BugLink: http://bugs.launchpad.net/bugs/541030
>
> Signed-off-by: Robert Nelson<robert.nelson@digikey.com>
> ---
>   debian.ti-omap/config/config.common.ubuntu |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/debian.ti-omap/config/config.common.ubuntu b/debian.ti-omap/config/config.common.ubuntu
> index a23cc2f..465323d 100644
> --- a/debian.ti-omap/config/config.common.ubuntu
> +++ b/debian.ti-omap/config/config.common.ubuntu
> @@ -1751,7 +1751,7 @@ CONFIG_NLS_KOI8_R=m
>   CONFIG_NLS_KOI8_U=m
>   CONFIG_NLS_UTF8=m
>   CONFIG_NOP_TRACER=y
> -CONFIG_NOP_USB_XCEIV=m
> +CONFIG_NOP_USB_XCEIV=y
>   CONFIG_NO_HZ=y
>   # CONFIG_NTFS_DEBUG is not set
>   CONFIG_NTFS_FS=m
> @@ -2478,7 +2478,7 @@ CONFIG_TUN=m
>   CONFIG_TWL4030_CODEC=y
>   CONFIG_TWL4030_CORE=y
>   CONFIG_TWL4030_POWER=y
> -CONFIG_TWL4030_USB=m
> +CONFIG_TWL4030_USB=y
>   CONFIG_TWL4030_WATCHDOG=m
>   # CONFIG_UACCESS_WITH_MEMCPY is not set
>   CONFIG_UBIFS_FS=y
> @@ -2533,7 +2533,7 @@ CONFIG_USB_DABUSB=m
>   # CONFIG_USB_DEVICE_CLASS is not set
>   CONFIG_USB_DSBR=m
>   # CONFIG_USB_DYNAMIC_MINORS is not set
> -CONFIG_USB_EHCI_HCD=m
> +CONFIG_USB_EHCI_HCD=y
>   # CONFIG_USB_EHCI_ROOT_HUB_TT is not set
>   # CONFIG_USB_EHCI_TT_NEWSCHED is not set
>   CONFIG_USB_EMI26=m
> @@ -2645,7 +2645,7 @@ CONFIG_USB_MICROTEK=m
>   # CONFIG_USB_MON is not set
>   CONFIG_USB_MR800=m
>   # CONFIG_USB_MUSB_DEBUG is not set
> -CONFIG_USB_MUSB_HDRC=m
> +CONFIG_USB_MUSB_HDRC=y
>   CONFIG_USB_MUSB_HDRC_HCD=y
>   CONFIG_USB_MUSB_HOST=y
>   # CONFIG_USB_MUSB_OTG is not set

Your LP report states that the ehci/musb port is not setup due to 
misconfiguration, yet all relevant config options are defined as 
modules. Can you go into a bit more depth as to why they have to be 
built-in as opposed to being modules?

rtg
robertcnelson@gmail.com - March 19, 2010, 12:48 p.m.
On Fri, Mar 19, 2010 at 7:29 AM, Tim Gardner <tim.gardner@canonical.com> wrote:
> On 03/19/2010 06:06 AM, robertcnelson@gmail.com wrote:

>
> Your LP report states that the ehci/musb port is not setup due to
> misconfiguration, yet all relevant config options are defined as modules.
> Can you go into a bit more depth as to why they have to be built-in as
> opposed to being modules?
>
> rtg
>

Hi Tim,

Sure, and i can edit the commit to add more information.

Basically, as the config currently is, neither my beagle Bx & C4 will
register a usb subsystem (via lsusb).

This also fixes the use case where a user:

Has a kernel in Nand or on the SD card and has the rootfs on an
external usb drive.

Regards,
Oliver Grawert - March 19, 2010, 1:04 p.m.
hi,
> Your LP report states that the ehci/musb port is not setup due to 
> misconfiguration, yet all relevant config options are defined as 
> modules. Can you go into a bit more depth as to why they have to be 
> built-in as opposed to being modules?

if you boot without initramfs or only with a bare kernel (only using
vmlinuz/uImage but not the /lib/modules dir due to not having the
package installed in the rootfs), you might need to have them built in.

indeed thats a corner case given that ubuntu default images will use
initramfs and have the modules available early enough but imho a valid
request.

ciao
	oli
Tim Gardner - March 19, 2010, 1:21 p.m.
On 03/19/2010 06:48 AM, Robert Nelson wrote:
> On Fri, Mar 19, 2010 at 7:29 AM, Tim Gardner<tim.gardner@canonical.com>  wrote:
>> On 03/19/2010 06:06 AM, robertcnelson@gmail.com wrote:
>
>>
>> Your LP report states that the ehci/musb port is not setup due to
>> misconfiguration, yet all relevant config options are defined as modules.
>> Can you go into a bit more depth as to why they have to be built-in as
>> opposed to being modules?
>>
>> rtg
>>
>
> Hi Tim,
>
> Sure, and i can edit the commit to add more information.
>
> Basically, as the config currently is, neither my beagle Bx&  C4 will
> register a usb subsystem (via lsusb).
>
> This also fixes the use case where a user:
>
> Has a kernel in Nand or on the SD card and has the rootfs on an
> external usb drive.
>
> Regards,
>

Amit informs me that OMAP will eventually have an initramfs, which ought 
to cover the case for modular boot essential drivers. I'll leave it up 
to him to decide what to do in the meantime.

rtg

Patch

diff --git a/debian.ti-omap/config/config.common.ubuntu b/debian.ti-omap/config/config.common.ubuntu
index a23cc2f..465323d 100644
--- a/debian.ti-omap/config/config.common.ubuntu
+++ b/debian.ti-omap/config/config.common.ubuntu
@@ -1751,7 +1751,7 @@  CONFIG_NLS_KOI8_R=m
 CONFIG_NLS_KOI8_U=m
 CONFIG_NLS_UTF8=m
 CONFIG_NOP_TRACER=y
-CONFIG_NOP_USB_XCEIV=m
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_NO_HZ=y
 # CONFIG_NTFS_DEBUG is not set
 CONFIG_NTFS_FS=m
@@ -2478,7 +2478,7 @@  CONFIG_TUN=m
 CONFIG_TWL4030_CODEC=y
 CONFIG_TWL4030_CORE=y
 CONFIG_TWL4030_POWER=y
-CONFIG_TWL4030_USB=m
+CONFIG_TWL4030_USB=y
 CONFIG_TWL4030_WATCHDOG=m
 # CONFIG_UACCESS_WITH_MEMCPY is not set
 CONFIG_UBIFS_FS=y
@@ -2533,7 +2533,7 @@  CONFIG_USB_DABUSB=m
 # CONFIG_USB_DEVICE_CLASS is not set
 CONFIG_USB_DSBR=m
 # CONFIG_USB_DYNAMIC_MINORS is not set
-CONFIG_USB_EHCI_HCD=m
+CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_ROOT_HUB_TT is not set
 # CONFIG_USB_EHCI_TT_NEWSCHED is not set
 CONFIG_USB_EMI26=m
@@ -2645,7 +2645,7 @@  CONFIG_USB_MICROTEK=m
 # CONFIG_USB_MON is not set
 CONFIG_USB_MR800=m
 # CONFIG_USB_MUSB_DEBUG is not set
-CONFIG_USB_MUSB_HDRC=m
+CONFIG_USB_MUSB_HDRC=y
 CONFIG_USB_MUSB_HDRC_HCD=y
 CONFIG_USB_MUSB_HOST=y
 # CONFIG_USB_MUSB_OTG is not set