From patchwork Fri Mar 19 04:59:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TeLeMan X-Patchwork-Id: 48110 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CD143B7C98 for ; Fri, 19 Mar 2010 16:05:51 +1100 (EST) Received: from localhost ([127.0.0.1]:48968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsUKr-0000LB-Lc for incoming@patchwork.ozlabs.org; Fri, 19 Mar 2010 01:01:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NsUIz-0000I9-F6 for qemu-devel@nongnu.org; Fri, 19 Mar 2010 00:59:29 -0400 Received: from [199.232.76.173] (port=60699 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsUIy-0000Hc-Kl for qemu-devel@nongnu.org; Fri, 19 Mar 2010 00:59:28 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NsUIx-00037R-Pj for qemu-devel@nongnu.org; Fri, 19 Mar 2010 00:59:28 -0400 Received: from mail-px0-f176.google.com ([209.85.216.176]:56252) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NsUIx-00037M-GW for qemu-devel@nongnu.org; Fri, 19 Mar 2010 00:59:27 -0400 Received: by pxi6 with SMTP id 6so2006454pxi.18 for ; Thu, 18 Mar 2010 21:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=xhvu75ZRsAOb7QyRQNQRmsQHU024LkTvdBwjZwAuLS4=; b=fd4Kw1nqQAYdbZABZlmaf6bN73DfB/Kb4kx0DZsCDn8dYI3mNZlQJVmh8Xoz2Y2LHH oZZKMq230EjRjEKMSNPIb2YqQwBRW4OzL/yWG1QCs0BBeeHI11aS8zXEc2B3C3a/u3vW UlJHp6BK+pk7vauKXEmQlf2NOWWp0i9DMtR4w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=cTP2Jyd+8CTFyFT6wWgcX1Xz+c3kr6Wy2GHyB73KuANip1dNSGA/1fGCIyJ0rPznAP sTCf8OEpEnIXtoS8os9Yi2epLoxYaolcFIZcMpH9ufmWkmCigJt/BwNO254vpTaJ7htH C6u+mPUFFjhOY7h9teQ/hyX6dUwNIdIIPz52w= MIME-Version: 1.0 Received: by 10.141.188.37 with SMTP id q37mr729453rvp.212.1268974765003; Thu, 18 Mar 2010 21:59:25 -0700 (PDT) Date: Fri, 19 Mar 2010 12:59:24 +0800 Message-ID: From: TeLeMan To: qemu-devel X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH] usb-bus: fix no params X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The "params" is never NULL and the usb hid devices have no params. Signed-off-by: TeLeMan --- hw/usb-bus.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index ce8a694..f3f1ed6 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -299,10 +299,6 @@ USBDevice *usbdevice_create(const char *cmdline) } if (!usb->usbdevice_init) { - if (params) { - error_report("usbdevice %s accepts no params", driver); - return NULL; - } return usb_create_simple(bus, usb->qdev.name); } return usb->usbdevice_init(params);