From patchwork Thu Mar 18 16:33:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 48076 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 921B6B7D71 for ; Fri, 19 Mar 2010 04:15:02 +1100 (EST) Received: from localhost ([127.0.0.1]:59158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsJJD-0000Ez-Gi for incoming@patchwork.ozlabs.org; Thu, 18 Mar 2010 13:14:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NsIf9-00004t-Mc for qemu-devel@nongnu.org; Thu, 18 Mar 2010 12:33:36 -0400 Received: from [199.232.76.173] (port=40357 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsIf7-0008Ta-BF for qemu-devel@nongnu.org; Thu, 18 Mar 2010 12:33:33 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NsIf0-0005Mx-7B for qemu-devel@nongnu.org; Thu, 18 Mar 2010 12:33:33 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]:56563) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NsIey-0005MU-HO for qemu-devel@nongnu.org; Thu, 18 Mar 2010 12:33:24 -0400 Received: from blackfin.pond.sub.org (pD9E3ACC8.dip.t-dialin.net [217.227.172.200]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 29D5D2DD35D for ; Thu, 18 Mar 2010 17:33:22 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 500) id 10453DB; Thu, 18 Mar 2010 17:33:16 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 18 Mar 2010 17:33:14 +0100 Message-Id: <1268929996-28763-8-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.6.6.1 In-Reply-To: <1268929996-28763-1-git-send-email-armbru@redhat.com> References: <1268929996-28763-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Markus Armbruster --- hw/qdev.c | 2 +- monitor.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 35460eb..c3a00d2 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -207,7 +207,7 @@ DeviceState *qdev_device_add(QemuOpts *opts) /* find driver */ info = qdev_find_info(NULL, driver); if (!info || info->no_user) { - qerror_report(QERR_INVALID_PARAMETER, "driver"); + qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "a driver name"); error_printf_unless_qmp("Try with argument '?' for a list.\n"); return NULL; } diff --git a/monitor.c b/monitor.c index 822dc27..35cbce7 100644 --- a/monitor.c +++ b/monitor.c @@ -970,7 +970,8 @@ static int do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data) { int index = qdict_get_int(qdict, "index"); if (mon_set_cpu(index) < 0) { - qerror_report(QERR_INVALID_PARAMETER, "index"); + qerror_report(QERR_INVALID_PARAMETER_VALUE, "index", + "a CPU number"); return -1; } return 0; @@ -2489,7 +2490,8 @@ static int do_getfd(Monitor *mon, const QDict *qdict, QObject **ret_data) } if (qemu_isdigit(fdname[0])) { - qerror_report(QERR_INVALID_PARAMETER, "fdname"); + qerror_report(QERR_INVALID_PARAMETER_VALUE, "fdname", + "a name not starting with a digit"); return -1; }