| Message ID | 20150604015219.2895.80478.stgit@ahduyck-vm-fedora22 |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Alexander Duyck <alexander.h.duyck@redhat.com> Date: Wed, 03 Jun 2015 18:53:17 -0700 > While reviewing the code I noticed that one of the commits added an if > statement followed by a for loop, but the if statement was missing the > braces around the loop. This change corrects the coding style error. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> I assume that I will get this via Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-06-03 at 23:57 -0700, David Miller wrote: > From: Alexander Duyck <alexander.h.duyck@redhat.com> > Date: Wed, 03 Jun 2015 18:53:17 -0700 > > > While reviewing the code I noticed that one of the commits added an if > > statement followed by a for loop, but the if statement was missing the > > braces around the loop. This change corrects the coding style error. > > > > Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> > > I assume that I will get this via Jeff. Yeah, I have this queued up.
Acked-by: Jacob Keller <jacob.e.keller@intel.com> Thanks Alex. Regards, Jake On Wed, 2015-06-03 at 18:53 -0700, Alexander Duyck wrote: > While reviewing the code I noticed that one of the commits added an if > statement followed by a for loop, but the if statement was missing the > braces around the loop. This change corrects the coding style error. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> > --- > drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > index 4b9d9f88af70..a9670e00cf03 100644 > --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > @@ -143,12 +143,13 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data) > p += ETH_GSTRING_LEN; > } > > - if (interface->hw.mac.type != fm10k_mac_vf) > + if (interface->hw.mac.type != fm10k_mac_vf) { > for (i = 0; i < FM10K_PF_STATS_LEN; i++) { > memcpy(p, fm10k_gstrings_pf_stats[i].stat_string, > ETH_GSTRING_LEN); > p += ETH_GSTRING_LEN; > } > + } > > for (i = 0; i < interface->hw.mac.max_queues; i++) { > sprintf(p, "tx_queue_%u_packets", i); > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@lists.osuosl.org > http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c index 4b9d9f88af70..a9670e00cf03 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c @@ -143,12 +143,13 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data) p += ETH_GSTRING_LEN; } - if (interface->hw.mac.type != fm10k_mac_vf) + if (interface->hw.mac.type != fm10k_mac_vf) { for (i = 0; i < FM10K_PF_STATS_LEN; i++) { memcpy(p, fm10k_gstrings_pf_stats[i].stat_string, ETH_GSTRING_LEN); p += ETH_GSTRING_LEN; } + } for (i = 0; i < interface->hw.mac.max_queues; i++) { sprintf(p, "tx_queue_%u_packets", i);
While reviewing the code I noticed that one of the commits added an if statement followed by a for loop, but the if statement was missing the braces around the loop. This change corrects the coding style error. Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> --- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html