Patchwork netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail.

login
register
mail settings
Submitter amit salecha
Date March 18, 2010, 9:28 a.m.
Message ID <99737F4847ED0A48AECC9F4A1974A4B80CFEFED052@MNEXMB2.qlogic.org>
Download mbox | patch
Permalink /patch/48012/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

amit salecha - March 18, 2010, 9:28 a.m.
>> But you shouldn't add support of device which is not supported.
Sorry for confusion. I don't know, what I was thinking

Actually you may be right, let me verify. 

-----Original Message-----
From: Amit Salecha 
Sent: Thursday, March 18, 2010 2:26 PM
To: 'Eric W. Biederman'; David Miller
Cc: netdev@vger.kernel.org; Ameen Rahman
Subject: RE: [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail.

Sorry for all the problem you faced.

But you shouldn't add support of device which is not supported.
Netxen is now owned by Qlogic. You should first contact Qlogic to solve your problem.
Qlogic will take needed action based on problem.

Please write to me, with detail problem description.

-----Original Message-----
From: Eric W. Biederman [mailto:ebiederm@xmission.com] 
Sent: Thursday, March 18, 2010 1:55 PM
To: David Miller
Cc: netdev@vger.kernel.org; Amit Salecha
Subject: [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail.


I haven't been able to get link up on a NX_P3_B1 since 2.6.31.  The
driver complains about a firmware hang instead.  When I asked I was
told rev 0x41 was a preproduction rev.  So disable support in the
driver so no one is surprised the code doesn't work.

Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
---
 drivers/net/netxen/netxen_nic_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 08780ef..9a7a0f3 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1246,8 +1246,8 @@  netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	int pci_func_id = PCI_FUNC(pdev->devfn);
 	uint8_t revision_id;
 
-	if (pdev->revision >= NX_P3_A0 && pdev->revision < NX_P3_B1) {
-		pr_warning("%s: chip revisions between 0x%x-0x%x"
+	if (pdev->revision >= NX_P3_A0 && pdev->revision <= NX_P3_B1) {
+		pr_warning("%s: chip revisions between 0x%x-0x%x "
 				"will not be enabled.\n",
 				module_name(THIS_MODULE), NX_P3_A0, NX_P3_B1);
 		return -ENODEV;