From patchwork Fri Oct 17 05:37:05 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Friesen X-Patchwork-Id: 4800 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id E7566DE044 for ; Fri, 17 Oct 2008 16:37:54 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from zcars04f.nortel.com (zcars04f.nortel.com [47.129.242.57]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "", Issuer "NORTEL" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 29128DDDFD for ; Fri, 17 Oct 2008 16:37:18 +1100 (EST) Received: from zcarhxs1.corp.nortel.com (zcarhxs1.corp.nortel.com [47.129.230.89]) by zcars04f.nortel.com (Switch-2.2.6/Switch-2.2.0) with ESMTP id m9H5b7h06139; Fri, 17 Oct 2008 05:37:07 GMT Received: from localhost.localdomain ([47.130.82.250] RDNS failed) by zcarhxs1.corp.nortel.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 17 Oct 2008 01:37:07 -0400 Message-ID: <48F82481.8070201@nortel.com> Date: Thu, 16 Oct 2008 23:37:05 -0600 From: "Chris Friesen" User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: Josh Boyer Subject: Re: [PATCH 0/2] ftrace: fixes for PPC References: <20080906050602.409299112@goodmis.org> <20080906120346.GA30964@elte.hu> <20081016181452.GA29739@yoda.jdub.homelinux.org> In-Reply-To: <20081016181452.GA29739@yoda.jdub.homelinux.org> X-OriginalArrivalTime: 17 Oct 2008 05:37:07.0123 (UTC) FILETIME=[64904830:01C9301A] Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Steven Rostedt , David Miller , linuxppc-dev@ozlabs.org, Thomas Gleixner , Ingo Molnar , Andrew Morton X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Josh Boyer wrote: > Are these two merged yet? I just spent the better part of the morning > trying to figure out why various Fedora kernels based on 2.6.27-rcX and > 2.6.27 final hung on my G5 and finally got one booting with FTRACE > disabled. Until recently I could boot my G5 with FTRACE enabled, but it totally screwed up load balancing. As of a couple days ago, -tip hung on boot due to the following genirq issue: Chris diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 570d1ea..1c178ae 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -132,7 +132,7 @@ int set_irq_type(unsigned int irq, unsigned int type) return 0; spin_lock_irqsave(&desc->lock, flags); - ret = __irq_set_trigger(desc, irq, flags); + ret = __irq_set_trigger(desc, irq, type); spin_unlock_irqrestore(&desc->lock, flags); return ret; }