diff mbox

[v1,8/8] target-microblaze: Remove dead code

Message ID e1cf24a77d0d3ad134ad55dcb8be0b391b57b30e.1433314301.git.alistair.francis@xilinx.com
State New
Headers show

Commit Message

Alistair Francis June 3, 2015, 7:01 a.m. UTC
This code is already being run in the mb_cpu_realizefn()
function. As PVR registers are preserved on reset this
code is not required.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
 target-microblaze/cpu.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Comments

Edgar E. Iglesias June 5, 2015, 12:48 a.m. UTC | #1
On Thu, Jun 04, 2015 at 11:25:49AM +1000, Alistair Francis wrote:
> This code is already being run in the mb_cpu_realizefn()
> function. As PVR registers are preserved on reset this
> code is not required.

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>  target-microblaze/cpu.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 329d4d5..437250d 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -129,10 +129,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
>  
>      env->sregs[SR_PC] = cpu->cfg.base_vectors;
>  
> -#if defined(CONFIG_USER_ONLY)
> -    env->pvr.regs[10] = 0x0c000000; /* Spartan 3a dsp.  */
> -#endif
> -
>      mcc->parent_realize(dev, errp);
>  }
>  
> -- 
> 1.7.1
>
diff mbox

Patch

diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
index 329d4d5..437250d 100644
--- a/target-microblaze/cpu.c
+++ b/target-microblaze/cpu.c
@@ -129,10 +129,6 @@  static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
 
     env->sregs[SR_PC] = cpu->cfg.base_vectors;
 
-#if defined(CONFIG_USER_ONLY)
-    env->pvr.regs[10] = 0x0c000000; /* Spartan 3a dsp.  */
-#endif
-
     mcc->parent_realize(dev, errp);
 }